Completed
Branch develop (8f72cf)
by John
07:52
created
Alpha/Controller/Controller.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -511,19 +511,19 @@  discard block
 block discarded – undo
511 511
             }
512 512
             // found the current job
513 513
             if ($this->name == $jobs[$i]) {
514
-                if (isset($jobs[$i - 1])) {
514
+                if (isset($jobs[$i-1])) {
515 515
                     // set the previous job if it exists
516
-                    $this->previousJob = $jobs[$i - 1];
516
+                    $this->previousJob = $jobs[$i-1];
517 517
                     self::$logger->debug('Previous job ['.$this->previousJob.']');
518 518
                 }
519
-                if (isset($jobs[$i + 1])) {
519
+                if (isset($jobs[$i+1])) {
520 520
                     // set the next job if it exists
521
-                    $this->nextJob = $jobs[$i + 1];
521
+                    $this->nextJob = $jobs[$i+1];
522 522
                     self::$logger->debug('Next job ['.$this->nextJob.']');
523 523
                 }
524 524
             }
525 525
             // the last job in the sequence
526
-            if ($i == ($numOfJobs - 1)) {
526
+            if ($i == ($numOfJobs-1)) {
527 527
                 $this->lastJob = $jobs[$i];
528 528
             }
529 529
         }
@@ -687,9 +687,9 @@  discard block
 block discarded – undo
687 687
             $this->unitEndTime->getYear()
688 688
             );
689 689
 
690
-        self::$logger->debug('<<getUnitDuration ['.$intEndTime - $intStartTime.']');
690
+        self::$logger->debug('<<getUnitDuration ['.$intEndTime-$intStartTime.']');
691 691
 
692
-        return $intEndTime - $intStartTime;
692
+        return $intEndTime-$intStartTime;
693 693
     }
694 694
 
695 695
     /**
@@ -1159,7 +1159,7 @@  discard block
 block discarded – undo
1159 1159
              */
1160 1160
 
1161 1161
             // the server hostname + today's date less 1 hour (i.e. yesterday where time is < 1:00AM)
1162
-            $var1 = rtrim(strtr(base64_encode(SecurityUtils::encrypt($host.date('Ymd', (time() - 3600)))), '+/', '-_'), '=');
1162
+            $var1 = rtrim(strtr(base64_encode(SecurityUtils::encrypt($host.date('Ymd', (time()-3600)))), '+/', '-_'), '=');
1163 1163
             // the server's IP plus $var1
1164 1164
             $var2 = rtrim(strtr(base64_encode(SecurityUtils::encrypt($ip.$var1)), '+/', '-_'), '=');
1165 1165
 
Please login to merge, or discard this patch.
Doc Comments   +11 added lines, -3 removed lines patch added patch discarded remove patch
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
     /**
298 298
      * Get the record for this controller (if any).
299 299
      *
300
-     * @return mixed
300
+     * @return ActiveRecord
301 301
      *
302 302
      * @since 1.0
303 303
      */
@@ -632,7 +632,7 @@  discard block
 block discarded – undo
632 632
     /**
633 633
      * Getter for the unit of work MAX duration.
634 634
      *
635
-     * @return int
635
+     * @return Integer
636 636
      *
637 637
      * @since 1.0
638 638
      */
@@ -1179,7 +1179,7 @@  discard block
 block discarded – undo
1179 1179
     /**
1180 1180
      * Generates the two security fields to prevent remote form processing.
1181 1181
      *
1182
-     * @return array An array containing the two fields
1182
+     * @return string[] An array containing the two fields
1183 1183
      *
1184 1184
      * @since 1.0
1185 1185
      */
@@ -1432,6 +1432,7 @@  discard block
 block discarded – undo
1432 1432
      * @since 2.0
1433 1433
      *
1434 1434
      * @throws \Alpha\Exception\NotImplementedException
1435
+     * @param Request $request
1435 1436
      */
1436 1437
     public function doHEAD($request)
1437 1438
     {
@@ -1444,6 +1445,7 @@  discard block
 block discarded – undo
1444 1445
      * @since 2.0
1445 1446
      *
1446 1447
      * @throws \Alpha\Exception\NotImplementedException
1448
+     * @param Request $request
1447 1449
      */
1448 1450
     public function doGET($request)
1449 1451
     {
@@ -1456,6 +1458,7 @@  discard block
 block discarded – undo
1456 1458
      * @since 2.0
1457 1459
      *
1458 1460
      * @throws \Alpha\Exception\NotImplementedException
1461
+     * @param Request $request
1459 1462
      */
1460 1463
     public function doPOST($request)
1461 1464
     {
@@ -1468,6 +1471,7 @@  discard block
 block discarded – undo
1468 1471
      * @since 2.0
1469 1472
      *
1470 1473
      * @throws \Alpha\Exception\NotImplementedException
1474
+     * @param Request $request
1471 1475
      */
1472 1476
     public function doPUT($request)
1473 1477
     {
@@ -1480,6 +1484,7 @@  discard block
 block discarded – undo
1480 1484
      * @since 2.0
1481 1485
      *
1482 1486
      * @throws \Alpha\Exception\NotImplementedException
1487
+     * @param Request $request
1483 1488
      */
1484 1489
     public function doPATCH($request)
1485 1490
     {
@@ -1492,6 +1497,7 @@  discard block
 block discarded – undo
1492 1497
      * @since 2.0
1493 1498
      *
1494 1499
      * @throws \Alpha\Exception\NotImplementedException
1500
+     * @param Request $request
1495 1501
      */
1496 1502
     public function doDELETE($request)
1497 1503
     {
@@ -1502,6 +1508,7 @@  discard block
 block discarded – undo
1502 1508
      * {@inheritdoc}
1503 1509
      *
1504 1510
      * @since 2.0
1511
+     * @param Request $request
1505 1512
      */
1506 1513
     public function doOPTIONS($request)
1507 1514
     {
@@ -1529,6 +1536,7 @@  discard block
 block discarded – undo
1529 1536
      * {@inheritdoc}
1530 1537
      *
1531 1538
      * @since 2.0.2
1539
+     * @param Request $request
1532 1540
      */
1533 1541
     public function doTRACE($request)
1534 1542
     {
Please login to merge, or discard this patch.
Alpha/Controller/SearchController.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
         $config = ConfigProvider::getInstance();
200 200
 
201 201
         // used to track when our pagination range ends
202
-        $end = ($this->startPoint + $config->get('app.list.page.amount'));
202
+        $end = ($this->startPoint+$config->get('app.list.page.amount'));
203 203
 
204 204
         $body = '';
205 205
 
@@ -289,14 +289,14 @@  discard block
 block discarded – undo
289 289
 
290 290
         $body = '';
291 291
 
292
-        $end = ($this->startPoint + $config->get('app.list.page.amount'));
292
+        $end = ($this->startPoint+$config->get('app.list.page.amount'));
293 293
 
294 294
         if ($end > $this->resultCount) {
295 295
             $end = $this->resultCount;
296 296
         }
297 297
 
298 298
         if ($this->resultCount > 0) {
299
-            $body .= '<p align="center">Displaying '.($this->startPoint + 1).' to '.$end.' of <strong>'.$this->resultCount.'</strong>.&nbsp;&nbsp;';
299
+            $body .= '<p align="center">Displaying '.($this->startPoint+1).' to '.$end.' of <strong>'.$this->resultCount.'</strong>.&nbsp;&nbsp;';
300 300
         } else {
301 301
             if (!empty($this->query)) {
302 302
                 $body .= View::displayUpdateMessage('There were no search results for your query.');
@@ -308,9 +308,9 @@  discard block
 block discarded – undo
308 308
         if ($this->startPoint > 0) {
309 309
             // handle secure URLs
310 310
             if (isset($params['tk'])) {
311
-                $body .= '<li><a href="'.FrontController::generateSecureURL('act=Search&q='.$this->query.'&start='.($this->startPoint - $config->get('app.list.page.amount'))).'">&laquo;</a></li>';
311
+                $body .= '<li><a href="'.FrontController::generateSecureURL('act=Search&q='.$this->query.'&start='.($this->startPoint-$config->get('app.list.page.amount'))).'">&laquo;</a></li>';
312 312
             } else {
313
-                $body .= '<li><a href="'.$config->get('app.url').'/search/'.$this->query.'/'.($this->startPoint - $config->get('app.list.page.amount')).'">&laquo;</a></li>';
313
+                $body .= '<li><a href="'.$config->get('app.url').'/search/'.$this->query.'/'.($this->startPoint-$config->get('app.list.page.amount')).'">&laquo;</a></li>';
314 314
             }
315 315
         } elseif ($this->resultCount > $config->get('app.list.page.amount')) {
316 316
             $body .= '<li class="disabled"><a href="#">&laquo;</a></li>';
@@ -336,9 +336,9 @@  discard block
 block discarded – undo
336 336
         if ($this->resultCount > $end) {
337 337
             // handle secure URLs
338 338
             if (isset($params['tk'])) {
339
-                $body .= '<li><a href="'.FrontController::generateSecureURL('act=Search&q='.$this->query.'&start='.($this->startPoint + $config->get('app.list.page.amount'))).'">Next-&gt;&gt;</a></li>';
339
+                $body .= '<li><a href="'.FrontController::generateSecureURL('act=Search&q='.$this->query.'&start='.($this->startPoint+$config->get('app.list.page.amount'))).'">Next-&gt;&gt;</a></li>';
340 340
             } else {
341
-                $body .= '<li><a href="'.$config->get('app.url').'/search/'.$this->query.'/'.($this->startPoint + $config->get('app.list.page.amount')).'">&raquo;</a></li>';
341
+                $body .= '<li><a href="'.$config->get('app.url').'/search/'.$this->query.'/'.($this->startPoint+$config->get('app.list.page.amount')).'">&raquo;</a></li>';
342 342
             }
343 343
         } elseif ($this->resultCount > $config->get('app.list.page.amount')) {
344 344
             $body .= '<li class="disabled"><a href="#">&raquo;</a></li>';
Please login to merge, or discard this patch.
Alpha/Util/Extension/MarkdownFacade.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
         foreach ($attachments[0] as $attachmentURL) {
123 123
             $start = mb_strpos($attachmentURL, '/');
124 124
             $end = mb_strrpos($attachmentURL, '"');
125
-            $fileName = mb_substr($attachmentURL, $start + 1, $end - ($start + 1));
125
+            $fileName = mb_substr($attachmentURL, $start+1, $end-($start+1));
126 126
 
127 127
             if (method_exists($this->BO, 'getAttachmentSecureURL')) {
128 128
                 $this->content = str_replace($attachmentURL, 'href="'.$this->BO->getAttachmentSecureURL($fileName).'" rel="nofollow"', $this->content);
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
                     $type = 'png';
151 151
                 }
152 152
 
153
-                $img = new Image($path, $image_details[0], $image_details[1], $type, 0.95, false, (boolean) $config->get('cms.images.widget.secure'));
153
+                $img = new Image($path, $image_details[0], $image_details[1], $type, 0.95, false, (boolean)$config->get('cms.images.widget.secure'));
154 154
 
155 155
                 $this->content = str_replace($attachmentURL, $img->renderHTMLLink(), $this->content);
156 156
             } else {
Please login to merge, or discard this patch.
Alpha/Util/Security/SecurityUtils.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@
 block discarded – undo
72 72
             $iv
73 73
         );
74 74
 
75
-        return $iv . $encryptedData;
75
+        return $iv.$encryptedData;
76 76
     }
77 77
 
78 78
     /**
Please login to merge, or discard this patch.
Alpha/Controller/PhpinfoController.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -6,7 +6,6 @@
 block discarded – undo
6 6
 use Alpha\Util\Config\ConfigProvider;
7 7
 use Alpha\Util\Http\Request;
8 8
 use Alpha\Util\Http\Response;
9
-use Alpha\Util\Http\Session\SessionProviderFactory;
10 9
 use Alpha\View\View;
11 10
 use Alpha\Controller\Front\FrontController;
12 11
 
Please login to merge, or discard this patch.
Alpha/Model/Type/Timestamp.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -629,15 +629,15 @@
 block discarded – undo
629 629
         $unixTS = $this->getUnixValue();
630 630
 
631 631
         if ($now > $unixTS) {
632
-            $difference = $now - $unixTS;
632
+            $difference = $now-$unixTS;
633 633
             $tense = 'ago';
634 634
         } else {
635
-            $difference = $unixTS - $now;
635
+            $difference = $unixTS-$now;
636 636
             $tense = 'from now';
637 637
         }
638 638
 
639
-        for ($i = 0; $difference >= $lengths[$i] && $i < count($lengths) - 1; ++$i) {
640
-            $difference = round($difference / $lengths[$i]);
639
+        for ($i = 0; $difference >= $lengths[$i] && $i < count($lengths)-1; ++$i) {
640
+            $difference = round($difference/$lengths[$i]);
641 641
         }
642 642
 
643 643
         $difference = round($difference);
Please login to merge, or discard this patch.
Alpha/Controller/ControllerInterface.php 1 patch
Doc Comments   +6 added lines, -7 removed lines patch added patch discarded remove patch
@@ -60,37 +60,36 @@  discard block
 block discarded – undo
60 60
     /**
61 61
      * Handles GET HTTP requests.
62 62
      *
63
-     * @param \Alpha\Util\Http\Request $request
64 63
      *
65 64
      * @since Alpha\Util\Http\Response
66 65
      * @since 1.0
66
+     * @return \Alpha\Util\Http\Response|null
67 67
      */
68 68
     public function doGET($params);
69 69
 
70 70
     /**
71 71
      * Handles POST HTTP requests.
72 72
      *
73
-     * @param \Alpha\Util\Http\Request $request
74 73
      *
75 74
      * @since Alpha\Util\Http\Response
76 75
      * @since 1.0
76
+     * @return \Alpha\Util\Http\Response|null
77 77
      */
78 78
     public function doPOST($params);
79 79
 
80 80
     /**
81 81
      * Handles PUT HTTP requests.
82 82
      *
83
-     * @param \Alpha\Util\Http\Request $request
84 83
      *
85 84
      * @since Alpha\Util\Http\Response
86 85
      * @since 1.0
86
+     * @return \Alpha\Util\Http\Response
87 87
      */
88 88
     public function doPUT($params);
89 89
 
90 90
     /**
91 91
      * Handles PATCH HTTP requests.
92 92
      *
93
-     * @param \Alpha\Util\Http\Request $request
94 93
      *
95 94
      * @since Alpha\Util\Http\Response
96 95
      * @since 1.0
@@ -100,30 +99,30 @@  discard block
 block discarded – undo
100 99
     /**
101 100
      * Handles DELETE HTTP requests.
102 101
      *
103
-     * @param \Alpha\Util\Http\Request $request
104 102
      *
105 103
      * @since Alpha\Util\Http\Response
106 104
      * @since 1.0
105
+     * @return \Alpha\Util\Http\Response
107 106
      */
108 107
     public function doDELETE($params);
109 108
 
110 109
     /**
111 110
      * Handles OPTIONS HTTP requests.
112 111
      *
113
-     * @param \Alpha\Util\Http\Request $request
114 112
      *
115 113
      * @since Alpha\Util\Http\Response
116 114
      * @since 1.0
115
+     * @return \Alpha\Util\Http\Response
117 116
      */
118 117
     public function doOPTIONS($params);
119 118
 
120 119
     /**
121 120
      * Handles TRACE HTTP requests.
122 121
      *
123
-     * @param \Alpha\Util\Http\Request $request
124 122
      *
125 123
      * @since Alpha\Util\Http\Response
126 124
      * @since 2.0.2
125
+     * @return \Alpha\Util\Http\Response
127 126
      */
128 127
     public function doTRACE($params);
129 128
 }
Please login to merge, or discard this patch.
Alpha/Controller/InstallController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -454,7 +454,7 @@
 block discarded – undo
454 454
      * Custom version of the check rights method that only checks for a session for the config admin username/password,
455 455
      * when the system database is not set-up.
456 456
      *
457
-     * @return bool
457
+     * @return boolean|null
458 458
      *
459 459
      * @since 1.0
460 460
      */
Please login to merge, or discard this patch.
Alpha/Model/ActiveRecordProviderFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
      * A static method that attempts to return a ActiveRecordProviderInterface instance
68 68
      * based on the name of the provider class supplied.
69 69
      *
70
-     * @param $providerName The fully-qualified class name of the provider class.
70
+     * @param string $providerName The fully-qualified class name of the provider class.
71 71
      * @param $BO The (optional) active record instance to pass to the persistance provider for mapping.
72 72
      *
73 73
      * @throws \Alpha\Exception\IllegalArguementException
Please login to merge, or discard this patch.