Alnutile\Codereview\GithubClientProvider

Complexity

Total Complexity

20

Size/Duplication

Total Lines	173
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getLatestCommits()	0	15	1
A	getGithubToken()	0	7	2
A	setGithubToken()	0	7	2
A	getClient()	0	4	1
A	setClient()	0	4	1
A	returnResults()	0	10	2
A	getQueryString()	0	4	1
A	setQueryString()	0	18	3
A	transformResults()	0	9	2
A	getResult()	0	8	1
A	isGuzzleResponse()	0	4	2
A	getDate()	0	4	1

<?php


namespace Alnutile\Codereview;

use Carbon\Carbon;
use GuzzleHttp\Client;

class GithubClientProvider extends Application
{


    protected $github_token = "";

    protected $client;

    protected $base_url = "https://api.github.com/search/commits";

    protected $query_string = "";


    /**
     * GithubClientProvider constructor.
     * @param null|\Silly\Edition\Pimple\Application $app
     * @param Client $client
     * @codeCoverageIgnore
     */
    public function __construct($app, Client $client)
    {
        parent::__construct($app);

        $this->client = $client;
    }


    public function getLatestCommits($query = [])
    {

        $this->setQueryString($query);

        $url = sprintf(
            "%s?%s",
            $this->base_url,
            $this->getQueryString()
        );

        $results = $this->getClient()->get($url);

        return $this->returnResults($results);
    }

    /**
     * @return string
     * @codeCoverageIgnore
     */
    public function getGithubToken()
    {
        if (!$this->github_token) {
            $this->setGithubToken();
        }
        return $this->github_token;
    }

    /**
     * @param string $github_token
     */
    public function setGithubToken($github_token = null)
    {
        if (!$github_token) {

The expression $github_token of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $github_token = $this->app->getConfigValueByKey('github_token');

The method getConfigValueByKey() does not seem to exist on object<Silly\Edition\Pimple\Application>.

        }
        $this->github_token = $github_token;
    }

    /**
     * @return Client
     * @codeCoverageIgnore
     */
    public function getClient()
    {
        return $this->client;
    }

    /**
     * @param Client $client
     * @codeCoverageIgnore
     */
    public function setClient($client)
    {
        $this->client = $client;
    }

    /**
     * @param $results
     * @return array|mixed
     * @codeCoverageIgnore
     */
    private function returnResults($results)
    {
        if ($this->isGuzzleResponse($results)) {
            $results = json_decode($results->getBody(), true);
        }

        $results = $this->transformResults($results);

        return $results;
    }

    public function getQueryString()
    {
        return $this->query_string;
    }



    /**
     * @param string $query_string

There is no parameter named $query_string. Was it maybe removed?

     */
    public function setQueryString($query = [])
    {
        if (isset($query['committer'])) {
            $items[] = sprintf("committer:%s", $query['committer']);

$items was never initialized. Although not strictly required by PHP, it is generally a good practice to add $items = array(); before regardless.

        }

        $items[] = 'sort:committer-date-desc';

The variable $items does not seem to be defined for all execution paths leading up to this point.

        if (isset($query['org'])) {
            $items[] = sprintf("org:%s", $query['org']);
        }

        $query = sprintf("q=%s", implode("+", $items));

        $query = sprintf('%s&access_token=%s', $query, $this->getGithubToken());

        $this->query_string = $query;
    }

    private function transformResults($results = [])
    {
        $items = [];
        foreach ($results['items'] as $key => $value) {
            $items[] = $this->getResult($value);
        }

        return $items;
    }

    /**
     * @param $value
     * @return array
     * @codeCoverageIgnore
     */
    private function getResult($value)
    {
        return [
            'repository' => $value['repository']['html_url'],
            'commit' => $value['html_url'],
            'date' => $this->getDate($value)
        ];
    }

    /**
     * @param $results
     * @return bool
     * @codeCoverageIgnore
     */
    private function isGuzzleResponse($results)
    {
        return is_object($results) && get_class($results) == 'GuzzleHttp\Psr7\Response';
    }

    /**
     * @param $value
     * @return string
     * @codeCoverageIgnore
     */
    private function getDate($value)
    {
        return Carbon::parse($value['commit']['committer']['date'])->format('Y/m/d H:i');
    }
}