MapFormCreator::build() - Code Metrics - Inspection of "Fix issues with map editing and aliases" - allejo/bzion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6eaf7d...374325 )

by Vladimir

created 2017-09-18 04:54 UTC

MapFormCreator::build() A

↳ Parent: MapFormCreator

Complexity

Conditions	3
Paths	2

Size

Total Lines	71
Code Lines	48

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	71
rs	9.1369
cc	3
eloc	48
nc	2
nop	1

How to fix Long Method

<?php
/**
 * This file contains a form creator for Teams
 *
 * @license    https://github.com/allejo/bzion/blob/master/LICENSE.md GNU General Public License Version 3
 */

namespace BZIon\Form\Creator;

use BZIon\Form\Constraint\UniqueAlias;
use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
use Symfony\Component\Form\Extension\Core\Type\FileType;
use Symfony\Component\Form\Extension\Core\Type\IntegerType;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\Form\Extension\Core\Type\TextareaType;
use Symfony\Component\Form\Extension\Core\Type\TextType;
use Symfony\Component\Validator\Constraints\Image;
use Symfony\Component\Validator\Constraints\Length;
use Symfony\Component\Validator\Constraints\NotBlank;
use Symfony\Component\Validator\Constraints\Type;

/**
 * Form creator for teams
 *
 * @property \Map $editing
 */
class MapFormCreator extends ModelFormCreator
{
    /**
     * {@inheritdoc}
     */
    protected function build($builder)
    {
        $builder
            ->add('name', TextType::class, array(
                'constraints' => [
                    new NotBlank(),
                    new Length([
                        'min' => 2,
                        'max' => 40,
                    ]),
                ],
                'data'      => $this->editing->getName(),
                'required' => true,
            ))
            ->add('alias', TextType::class, array(
                'constraints' => [
                    new Length([
                        'max' => 40,
                    ]),
                    new UniqueAlias('Map', $this->editing),
                    new Type([
                        'type' => 'alpha'
                    ]),
                ],
                'data'     => $this->editing->getAlias(),
                'required' => true
            ))
            ->add('description', TextareaType::class, array(
                'constraints' => [
                    new NotBlank(),
                    new Length([
                        'min' => 10
                    ]),
                ],
                'data'     => $this->editing->getDescription(),
                'required' => true,
            ))
            ->add('avatar', FileType::class, array(
                'constraints' => new Image(array(
                    'minWidth'  => 60,
                    'minHeight' => 60,
                    'maxSize'   => '8M'
                )),
                'required' => ($this->editing === null || $this->editing->hasAvatar())
            ))
            ->add('shot_count', IntegerType::class, [
                'data'     => $this->editing->getShotCount(),
                'label'    => 'Max shot count',
                'required' => true,
            ])
            ->add('jumping', CheckboxType::class, [
                'data'     => $this->editing->isJumpingEnabled(),
                'label'    => 'Map allows jumping',
                'required' => false,
            ])
            ->add('ricochet', CheckboxType::class, [
                'data'     => $this->editing->isRicochetEnabled(),
                'label'    => 'Map allows ricochet',
                'required' => false,
            ])
        ;

        if ($this->editing) {
            // We are editing the map, not creating it
            $builder->add('delete_avatar', SubmitType::class);
        }

        return $builder->add('submit', SubmitType::class, [
            'label' => 'Save'
        ]);
    }

    /**
     * {@inheritdoc}
     */
    public function enter($form)
    {
        return
            \Map::addMap(
                $form->get('name')->getData(),
                $form->get('alias')->getData(),
                $form->get('description')->getData()
            )
            ->setAvatarFile($form->get('avatar')->getData())
            ->setShotCount($form->get('shot_count')->getData())
            ->setJumpingEnabled($form->get('jumping')->getData())
            ->setRicochetEnabled($form->get('ricochet')->getData())
        ;
    }

    /**
     * {@inheritdoc}
     *
     * @param \Map $map
     */
    public function update($form, $map)
    {
        $map->setName($form->get('name')->getData());
        $map->setAlias($form->get('alias')->getData());
        $map->setDescription($form->get('description')->getData());
        $map->setShotCount($form->get('shot_count')->getData());
        $map->setJumpingEnabled($form->get('jumping')->getData());
        $map->setRicochetEnabled($form->get('ricochet')->getData());

        if ($form->has('delete_avatar') && $form->get('delete_avatar')->isClicked()) {
            $map->resetAvatar();
        } else {
            $map->setAvatarFile($form->get('avatar')->getData());
        }

        return $map;
    }
}


1			<?php
2			/**
3			* This file contains a form creator for Teams
4			*
5			* @license https://github.com/allejo/bzion/blob/master/LICENSE.md GNU General Public License Version 3
6			*/
7
8			namespace BZIon\Form\Creator;
9
10			use BZIon\Form\Constraint\UniqueAlias;
11			use Symfony\Component\Form\Extension\Core\Type\CheckboxType;
12			use Symfony\Component\Form\Extension\Core\Type\FileType;
13			use Symfony\Component\Form\Extension\Core\Type\IntegerType;
14			use Symfony\Component\Form\Extension\Core\Type\SubmitType;
15			use Symfony\Component\Form\Extension\Core\Type\TextareaType;
16			use Symfony\Component\Form\Extension\Core\Type\TextType;
17			use Symfony\Component\Validator\Constraints\Image;
18			use Symfony\Component\Validator\Constraints\Length;
19			use Symfony\Component\Validator\Constraints\NotBlank;
20			use Symfony\Component\Validator\Constraints\Type;
21
22			/**
23			* Form creator for teams
24			*
25			* @property \Map $editing
26			*/
27			class MapFormCreator extends ModelFormCreator
28			{
29			/**
30			* {@inheritdoc}
31			*/
32			protected function build($builder)
33			{
34			$builder
35			->add('name', TextType::class, array(
36			'constraints' => [
37			new NotBlank(),
38			new Length([
39			'min' => 2,
40			'max' => 40,
41			]),
42			],
43			'data' => $this->editing->getName(),
44			'required' => true,
45			))
46			->add('alias', TextType::class, array(
47			'constraints' => [
48			new Length([
49			'max' => 40,
50			]),
51			new UniqueAlias('Map', $this->editing),
52			new Type([
53			'type' => 'alpha'
54			]),
55			],
56			'data' => $this->editing->getAlias(),
57			'required' => true
58			))
59			->add('description', TextareaType::class, array(
60			'constraints' => [
61			new NotBlank(),
62			new Length([
63			'min' => 10
64			]),
65			],
66			'data' => $this->editing->getDescription(),
67			'required' => true,
68			))
69			->add('avatar', FileType::class, array(
70			'constraints' => new Image(array(
71			'minWidth' => 60,
72			'minHeight' => 60,
73			'maxSize' => '8M'
74			)),
75			'required' => ($this->editing === null \|\| $this->editing->hasAvatar())
76			))
77			->add('shot_count', IntegerType::class, [
78			'data' => $this->editing->getShotCount(),
79			'label' => 'Max shot count',
80			'required' => true,
81			])
82			->add('jumping', CheckboxType::class, [
83			'data' => $this->editing->isJumpingEnabled(),
84			'label' => 'Map allows jumping',
85			'required' => false,
86			])
87			->add('ricochet', CheckboxType::class, [
88			'data' => $this->editing->isRicochetEnabled(),
89			'label' => 'Map allows ricochet',
90			'required' => false,
91			])
92			;
93
94			if ($this->editing) {
95			// We are editing the map, not creating it
96			$builder->add('delete_avatar', SubmitType::class);
97			}
98
99			return $builder->add('submit', SubmitType::class, [
100			'label' => 'Save'
101			]);
102			}
103
104			/**
105			* {@inheritdoc}
106			*/
107			public function enter($form)
108			{
109			return
110			\Map::addMap(
111			$form->get('name')->getData(),
112			$form->get('alias')->getData(),
113			$form->get('description')->getData()
114			)
115			->setAvatarFile($form->get('avatar')->getData())
116			->setShotCount($form->get('shot_count')->getData())
117			->setJumpingEnabled($form->get('jumping')->getData())
118			->setRicochetEnabled($form->get('ricochet')->getData())
119			;
120			}
121
122			/**
123			* {@inheritdoc}
124			*
125			* @param \Map $map
126			*/
127			public function update($form, $map)
128			{
129			$map->setName($form->get('name')->getData());
130			$map->setAlias($form->get('alias')->getData());
131			$map->setDescription($form->get('description')->getData());
132			$map->setShotCount($form->get('shot_count')->getData());
133			$map->setJumpingEnabled($form->get('jumping')->getData());
134			$map->setRicochetEnabled($form->get('ricochet')->getData());
135
136			if ($form->has('delete_avatar') && $form->get('delete_avatar')->isClicked()) {
137			$map->resetAvatar();
138			} else {
139			$map->setAvatarFile($form->get('avatar')->getData());
140			}
141
142			return $map;
143			}
144			}
145

allejo / bzion

Push — master ( 6eaf7d...374325 )

MapFormCreator::build() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like