Season::getWinterSeason() - Code Metrics - Inspection of "Add Season object and Player::getElo()" - allejo/bzion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/player-elo-v3 ( e6aec1 )

by Vladimir

created 2017-08-07 18:35 UTC

Season::getWinterSeason() A

↳ Parent: Season

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

use Carbon\Carbon;

class Season
{
    const WINTER = 'winter';
    const SPRING = 'spring';
    const SUMMER = 'summer';
    const FALL = 'fall';

    public static function getCurrentSeason()
    {
        $now = Carbon::now()->month;

        if (1 <= $now && $now <= 3) {
            return self::WINTER;
        } elseif (4 <= $now && $now <= 6) {
            return self::SPRING;
        } elseif (7 <= $now && $now <= 9) {
            return self::SUMMER;
        }

        return self::FALL;
    }

    public static function getCurrentSeasonRange()
    {
        $season = self::getCurrentSeason();

        switch ($season) {
            case self::WINTER:
                return self::getWinterSeason();

            case self::SPRING:
                return self::getSpringSeason();

            case self::SUMMER:
                return self::getSummerSeason();

            default:
                return self::getFallSeason();
        }
    }

    public static function getWinterSeason()
    {
        return (new MonthDateRange('January', 'March'));
    }

    public static function getSpringSeason()
    {
        return (new MonthDateRange('April', 'June'));
    }

    public static function getSummerSeason()
    {
        return (new MonthDateRange('July', 'September'));
    }

    public static function getFallSeason()
    {
        return (new MonthDateRange('October', 'December'));
    }
}


1			<?php
2
3			use Carbon\Carbon;
4
5			class Season
6			{
7			const WINTER = 'winter';
8			const SPRING = 'spring';
9			const SUMMER = 'summer';
10			const FALL = 'fall';
11
12			public static function getCurrentSeason()
13			{
14			$now = Carbon::now()->month;
15
16			if (1 <= $now && $now <= 3) {
17			return self::WINTER;
18			} elseif (4 <= $now && $now <= 6) {
19			return self::SPRING;
20			} elseif (7 <= $now && $now <= 9) {
21			return self::SUMMER;
22			}
23
24			return self::FALL;
25			}
26
27			public static function getCurrentSeasonRange()
28			{
29			$season = self::getCurrentSeason();
30
31			switch ($season) {
32			case self::WINTER:
33			return self::getWinterSeason();
34
35			case self::SPRING:
36			return self::getSpringSeason();
37
38			case self::SUMMER:
39			return self::getSummerSeason();
40
41			default:
42			return self::getFallSeason();
43			}
44			}
45
46			public static function getWinterSeason()
47			{
48			return (new MonthDateRange('January', 'March'));
49			}
50
51			public static function getSpringSeason()
52			{
53			return (new MonthDateRange('April', 'June'));
54			}
55
56			public static function getSummerSeason()
57			{
58			return (new MonthDateRange('July', 'September'));
59			}
60
61			public static function getFallSeason()
62			{
63			return (new MonthDateRange('October', 'December'));
64			}
65			}
66

allejo / bzion

Push — feature/player-elo-v3 ( e6aec1 )

Season::getWinterSeason() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like