BZIon\Event\ConversationSubscriber

Complexity

Total Complexity

4

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	5
Bugs	0	Features	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	onTeamMembershipChange()	0	8	2
A	getSubscribedEvents()	0	13	1
A	onTeamLeave()	0	12	1

<?php
/**
 * This file contains a class that responds to events
 *
 * @license    https://github.com/allejo/bzion/blob/master/LICENSE.md GNU General Public License Version 3
 */

namespace BZIon\Event;

use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * An event subscriber for events related to conversations
 */
class ConversationSubscriber implements EventSubscriberInterface
{
    /**
     * Returns all the events that this subscriber handles, and which method
     * handles each one
     *
     * @return array
     */
    public static function getSubscribedEvents()
    {
        return array(
            'team.abandon' => array(
                array('onTeamMembershipChange'),
                array('onTeamLeave')
            ),
            'team.kick' => array(
                array('onTeamMembershipChange'),
                array('onTeamLeave')
            )
        );
    }

    /**
     * Called every time a member is added/removed from a team
     *
     * @param TeamAbandonEvent|TeamJoinEvent|TeamKickEvent $event The event
     * @param string $type The type of the event
     */
    public function onTeamMembershipChange(Event $event, $type)
    {
        $query = \Conversation::getQueryBuilder()->forTeam($event->getTeam());

It seems like you code against a specific sub-type and not the parent class BZIon\Event\Event as the method getTeam() does only exist in the following sub-classes of BZIon\Event\Event: BZIon\Event\TeamAbandonEvent, BZIon\Event\TeamDeleteEvent, BZIon\Event\TeamJoinEvent, BZIon\Event\TeamKickEvent, BZIon\Event\TeamLeaderChangeEvent. Maybe you want to instanceof check for one of these explicitly?

        foreach ($query->getModels() as $conversation) {
            \ConversationEvent::storeEvent($conversation->getId(), $event, $type);
        }
    }

    /**
     * When a player leaves a team, remove them from every conversation that
     * includes that team
     *
     * @param TeamAbandonEvent|TeamKickEvent $event The event
     */
    public function onTeamLeave(Event $event)
    {
        // We don't need to check which conversations include the player; a
        // player_conversations entry will have `distinct` set to 0 only if the
        // player belongs to a conversation because they are a member of this
        // team
        \Database::getInstance()->execute(
            "DELETE FROM `player_conversations`
                WHERE player = ?
                AND `distinct` = 0", array($event->getPlayer()->getId())

It seems like you code against a specific sub-type and not the parent class BZIon\Event\Event as the method getPlayer() does only exist in the following sub-classes of BZIon\Event\Event: BZIon\Event\ConversationRenameEvent, BZIon\Event\TeamAbandonEvent, BZIon\Event\TeamJoinEvent, BZIon\Event\TeamKickEvent, BZIon\Event\WelcomeEvent. Maybe you want to instanceof check for one of these explicitly?

        );
    }
}