ColorTeam

Complexity

Total Complexity

11

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getId()	0	4	1
A	getName()	0	4	1
A	getAvatar()	0	4	1
A	isValid()	0	4	1
A	isLastMatch()	0	4	1
A	supportsMatchCount()	0	4	1
A	isValidTeamColor()	0	4	1
A	isSameAs()	0	6	3

<?php
/**
 * This file contains functionality relating to the fun match teams
 *
 * @package    BZiON\Models
 * @license    https://github.com/allejo/bzion/blob/master/LICENSE.md GNU General Public License Version 3
 */

/**
 * A team identified by its color in BZFlag
 * @package    BZiON\Models
 */
class ColorTeam implements TeamInterface
{
    /**
     * The color of the team
     *
     * @var string
     */
    protected $color;

    /**
     * Define a new ColorTeam
     * @param string $color The color of the team
     */
    public function __construct($color)
    {
        $this->color = strtolower($color);
    }

    /**
     * Get a unique identifier for the team
     *
     * @return string
     */
    public function getId()
    {
        return $this->color;
    }

    /**
     * {@inheritdoc}
     */
    public function getName()
    {
        return ucwords($this->color) . " Team";
    }

    /**
     * {@inheritdoc}
     */
    public function getAvatar()
    {
        return "assets/imgs/team_" . $this->color . ".png";
    }

    /**
     * {@inheritdoc}
     */
    public function isValid()
    {
        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function isLastMatch($match)
    {
        return true;
    }

    /**
     * {@inheritdoc}
     */
    public function supportsMatchCount()
    {
        return false;
    }

    /**
     * Return whether a team color is valid
     *
     * @param string $color The color to check
     */
    public static function isValidTeamColor($color)
    {
        return in_array($color, array('red', 'green', 'blue', 'purple'));
    }

    /**
     * {@inheritdoc}
     */
    public function isSameAs($team)
    {
        $sameType = $this instanceof $team || $team instanceof $this;

        return $sameType && $this->color === $team->color;

Accessing color on the interface TeamInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

    }
}