Completed
Pull Request — master (#186)
by Vladimir
05:50 queued 02:55
created

MapsStatusColumnConversion   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 52
Duplicated Lines 92.31 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 0
Metric Value
wmc 2
lcom 1
cbo 2
dl 48
loc 52
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
B up() 27 27 1
A down() 21 21 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
use Phinx\Migration\AbstractMigration;
4
5
class MapsStatusColumnConversion extends AbstractMigration
6
{
7 View Code Duplication
    public function up()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
8
    {
9
        $mapsTable = $this->table('maps');
10
        $mapsTable
11
            ->addColumn('is_inactive', 'boolean', [
12
                'after' => 'game_mode',
13
                'null' => false,
14
                'default' => false,
15
                'comment' => 'Whether or not this map has been marked as inactive, meaning a map is no longer in active rotation on servers',
16
            ])
17
            ->addColumn('is_deleted', 'boolean', [
18
                'after' => 'is_inactive',
19
                'null' => false,
20
                'default' => false,
21
                'comment' => 'Whether or not this map has been soft deleted'
22
            ])
23
            ->update()
24
        ;
25
26
        $this->query("UPDATE maps SET is_inactive = 1 WHERE status = 'hidden' OR status = 'disabled';");
27
        $this->query("UPDATE maps SET is_deleted = 1 WHERE status = 'deleted';");
28
29
        $mapsTable
30
            ->removeColumn('status')
31
            ->update()
32
        ;
33
    }
34
35 View Code Duplication
    public function down()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
36
    {
37
        $mapsTable = $this->table('maps');
38
        $mapsTable
39
            ->addColumn('status', 'set', [
40
                'values' => ['active', 'hidden', 'disabled', 'deleted'],
41
                'null' => false,
42
                'default' => 'active',
43
                'comment' => 'The status of the map',
44
            ])
45
            ->update()
46
        ;
47
48
        $this->query("UPDATE maps SET status = 'hidden' WHERE is_inactive = 1;");
49
        $this->query("UPDATE maps SET status = 'deleted' WHERE is_deleted = 1;");
50
51
        $mapsTable
52
            ->removeColumn('is_inactive')
53
            ->removeColumn('is_deleted')
54
        ;
55
    }
56
}
57