MatchFormCreator::build() - Code Metrics - Inspection of "Add a test for fun matches" - allejo/bzion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — fm-support ( 0de470...22a3ee )

by Konstantinos

created 2016-08-28 22:27 UTC

MatchFormCreator::build() B

↳ Parent: MatchFormCreator

Complexity

Conditions	6
Paths	2

Size

Total Lines	50
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	28
CRAP Score	6.0014

Importance

Changes	5
Bugs	2	Features	1

Metric	Value
c	5
b	2
f	1
dl	0
loc	50
ccs	28
cts	29
cp	0.9655
rs	8.6315
cc	6
eloc	36
nc	2
nop	1
crap	6.0014

<?php
/**
 * This file contains a form creator for Matches
 *
 * @license    https://github.com/allejo/bzion/blob/master/LICENSE.md GNU General Public License Version 3
 */

namespace BZIon\Form\Creator;

use BZIon\Form\Type\DatetimeWithTimezoneType;
use BZIon\Form\Type\MatchTeamType;
use BZIon\Form\Type\ModelType;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Validator\Constraints\LessThan;
use Symfony\Component\Validator\Constraints\NotBlank;

/**
 * Form creator for matches
 */
class MatchFormCreator extends ModelFormCreator
{
    /**
     * {@inheritdoc}
     */
    protected function build($builder)
    {
        $durations = \Service::getParameter('bzion.league.duration');
        foreach ($durations as $duration => &$value) {
            $durations[$duration] = $duration;
        }

        return $builder
            ->add('first_team', new MatchTeamType(), array(
                'disableTeam' => $this->isEdit() && $this->editing->isOfficial()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ))
            ->add('second_team', new MatchTeamType(), array(
                'disableTeam' => $this->isEdit() && $this->editing->isOfficial()
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            ))
            ->add('duration', 'choice', array(
                'choices'     => $durations,
                'constraints' => new NotBlank(),
                'expanded'    => true
            ))
            ->add('server_address', 'text', array(
                'required' => false,
                'attr'     => array('placeholder' => 'brad.guleague.org:5100'),
            ))
            ->add('time', new DatetimeWithTimezoneType(), array(
                'constraints' => array(
                    new NotBlank(),
                    new LessThan(array(
                        'value'   => \TimeDate::now()->addMinutes(10),
                        'message' => 'The timestamp of the match must not be in the future'
                    ))
                ),
                'data' => ($this->isEdit())
                    ? $this->editing->getTimestamp()->setTimezone(\Controller::getMe()->getTimezone())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    : \TimeDate::now(\Controller::getMe()->getTimezone()),
                'with_seconds' => $this->isEdit()
            ))
            ->add('map', new ModelType('Map'), array(
                'required' => false
            ))
            ->add('type', 'choice', array(
                'choices'  => array(
                    \Match::OFFICIAL => 'Official',
                    \Match::FUN => 'Fun match',
                    \Match::SPECIAL => 'Special event match',
                ),
                'disabled' => $this->editing && $this->editing->isOfficial(),
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                'label' => 'Match Type'
            ))
            ->add('enter', 'submit');
    }

    /**
     * {@inheritdoc}
     *
     * @param \Match $match
     */
    public function fill($form, $match)
    {
        $form->get('first_team')->setData(array(
            'team'         => $match->getTeamA(),
            'participants' => $match->getTeamAPlayers(),
            'score'        => $match->getTeamAPoints()
        ));
        $form->get('second_team')->setData(array(
            'team'         => $match->getTeamB(),
            'participants' => $match->getTeamBPlayers(),
            'score'        => $match->getTeamBPoints()
        ));

        $form->get('duration')->setData($match->getDuration());
        $form->get('server_address')->setData($match->getServerAddress());
        $form->get('time')->setData($match->getTimestamp());
        $form->get('map')->setData($match->getMap());
        $form->get('type')->setData($match->getMatchType());
    }

    /**
     * {@inheritdoc}
     *
     * @param \Match $match
     */
    public function update($form, $match)
    {
        if (($match->getDuration() != $form->get('duration')->getData())
            || $match->getTimestamp()->ne($form->get('time')->getData())) {
            // The timestamp of the match was changed, we might need to
            // recalculate its ELO
            $this->controller->recalculateNeeded = true;

        }

        $firstTeam  = $form->get('first_team');
        $secondTeam = $form->get('second_team');

        $serverInfo = $this->getServerInfo($form->get('server_address'));

        if (!$match->isOfficial()) {
            $match->setTeamColors(
                $firstTeam->get('team')->getData(),
                $secondTeam->get('team')->getData()
            );
        }

        $match->setTeamPlayers(
            $this->getPlayerList($firstTeam),
            $this->getPlayerList($secondTeam)
        );

        $match->setTeamPoints(
            $firstTeam->get('score')->getData(),
            $secondTeam->get('score')->getData()
        );

        $match->setDuration($form->get('duration')->getData())
            ->setServerAddress($serverInfo[0], $serverInfo[1])
            ->setTimestamp($form->get('time')->getData())
            ->setMap($form->get('map')->getData()->getId());

        if (!$match->isEloCorrect()) {
            $this->controller->recalculateNeeded = true;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function enter($form)
    {
        $firstTeam  = $form->get('first_team');
        $secondTeam = $form->get('second_team');

        $firstId = $firstTeam->get('team')->getData()->getId();
        $secondId = $secondTeam->get('team')->getData()->getId();

        $official = ($form->get('type')->getData() === \Match::OFFICIAL);
        $serverInfo = $this->getServerInfo($form->get('server_address'));

        $match = \Match::enterMatch(
            $official ? $firstId : null,
            $official ? $secondId : null,
            $firstTeam->get('score')->getData(),
            $secondTeam->get('score')->getData(),
            $form->get('duration')->getData(),
            $this->me->getId(),
            $form->get('time')->getData(),
            $this->getPlayerList($firstTeam),
            $this->getPlayerList($secondTeam),
            $serverInfo[0],
            $serverInfo[1],
            null,
            $form->get('map')->getData()->getId(),
            $form->get('type')->getData(),
            $official ? null : $firstId,
            $official ? null : $secondId
        );

        return $match;
    }

    /**
     * Get the player list of a team
     *
     * @param FormInterface $team A MatchTeamType form
     * @return array
     */
    private function getPlayerList(FormInterface $team)
    {
        return array_map($this->getModelToID(),  $team->get('participants')->getData());
    }

    /**
     * Get the server address and port of a match
     *
     * @param FormInterface $server A text form representing the server
     * @return array
     */
    private function getServerInfo(FormInterface $server)
    {
        $serverInfo = explode(':', $server->getData());
        if (!isset($serverInfo[1])) {
            $serverInfo[1] = 5154;
        }

        return $serverInfo;
    }

    /**
     * Get a function which converts models to their IDs
     *
     * Useful to store the match players into the database
     */
    private static function getModelToID()
    {
        return function ($model) {
            return $model->getId();
        };
    }
}


Push — fm-support ( 0de470...22a3ee )

MatchFormCreator::build() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		/**
3		* This file contains a form creator for Matches
4		*
5		* @license https://github.com/allejo/bzion/blob/master/LICENSE.md GNU General Public License Version 3
6		*/
7
8		namespace BZIon\Form\Creator;
9
10		use BZIon\Form\Type\DatetimeWithTimezoneType;
11		use BZIon\Form\Type\MatchTeamType;
12		use BZIon\Form\Type\ModelType;
13		use Symfony\Component\Form\FormInterface;
14		use Symfony\Component\Validator\Constraints\LessThan;
15		use Symfony\Component\Validator\Constraints\NotBlank;
16
17		/**
18		* Form creator for matches
19		*/
20		class MatchFormCreator extends ModelFormCreator
21		{
22		/**
23		* {@inheritdoc}
24		*/
25	1	protected function build($builder)
26		{
27	1	$durations = \Service::getParameter('bzion.league.duration');
28	1	foreach ($durations as $duration => &$value) {
29	1	$durations[$duration] = $duration;
30		}
31
32		return $builder
33	1	->add('first_team', new MatchTeamType(), array(
34	1	'disableTeam' => $this->isEdit() && $this->editing->isOfficial()
		0 ignored issues – show Bug introduced 2016-08-22 14:49 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Model` as the method `isOfficial()` does only exist in the following sub-classes of `Model`: `Match`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
35		))
36	1	->add('second_team', new MatchTeamType(), array(
37	1	'disableTeam' => $this->isEdit() && $this->editing->isOfficial()
		0 ignored issues – show Bug introduced 2016-08-22 14:49 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Model` as the method `isOfficial()` does only exist in the following sub-classes of `Model`: `Match`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
38		))
39	1	->add('duration', 'choice', array(
40	1	'choices' => $durations,
41	1	'constraints' => new NotBlank(),
42		'expanded' => true
43		))
44	1	->add('server_address', 'text', array(
45	1	'required' => false,
46		'attr' => array('placeholder' => 'brad.guleague.org:5100'),
47		))
48	1	->add('time', new DatetimeWithTimezoneType(), array(
49		'constraints' => array(
50	1	new NotBlank(),
51	1	new LessThan(array(
52	1	'value' => \TimeDate::now()->addMinutes(10),
53	1	'message' => 'The timestamp of the match must not be in the future'
54		))
55		),
56	1	'data' => ($this->isEdit())
57		? $this->editing->getTimestamp()->setTimezone(\Controller::getMe()->getTimezone())
		0 ignored issues – show Bug introduced 2016-02-26 00:07 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Model` as the method `getTimestamp()` does only exist in the following sub-classes of `Model`: `AbstractMessage`, `ConversationEvent`, `Match`, `Message`, `Notification`, `Visit`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
58	1	: \TimeDate::now(\Controller::getMe()->getTimezone()),
59	1	'with_seconds' => $this->isEdit()
60		))
61	1	->add('map', new ModelType('Map'), array(
62		'required' => false
63	1	))
64	1	->add('type', 'choice', array(
65		'choices' => array(
66		\Match::OFFICIAL => 'Official',
67		\Match::FUN => 'Fun match',
68		\Match::SPECIAL => 'Special event match',
69	1	),
70	1	'disabled' => $this->editing && $this->editing->isOfficial(),
		0 ignored issues – show Bug introduced 2016-08-22 21:27 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Model` as the method `isOfficial()` does only exist in the following sub-classes of `Model`: `Match`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
71	1	'label' => 'Match Type'
72		))
73	1	->add('enter', 'submit');
74		}
75
76		/**
77		* {@inheritdoc}
78		*
79		* @param \Match $match
80		*/
81		public function fill($form, $match)
82		{
83		$form->get('first_team')->setData(array(
84		'team' => $match->getTeamA(),
85		'participants' => $match->getTeamAPlayers(),
86		'score' => $match->getTeamAPoints()
87		));
88		$form->get('second_team')->setData(array(
89		'team' => $match->getTeamB(),
90		'participants' => $match->getTeamBPlayers(),
91		'score' => $match->getTeamBPoints()
92		));
93
94		$form->get('duration')->setData($match->getDuration());
95		$form->get('server_address')->setData($match->getServerAddress());
96		$form->get('time')->setData($match->getTimestamp());
97		$form->get('map')->setData($match->getMap());
98		$form->get('type')->setData($match->getMatchType());
99		}
100
101		/**
102		* {@inheritdoc}
103		*
104		* @param \Match $match
105		*/
106		public function update($form, $match)
107		{
108		if (($match->getDuration() != $form->get('duration')->getData())
109		\|\| $match->getTimestamp()->ne($form->get('time')->getData())) {
110		// The timestamp of the match was changed, we might need to
111		// recalculate its ELO
112		$this->controller->recalculateNeeded = true;
		0 ignored issues – show Bug introduced 2016-02-20 00:57 UTC by Report Bug Copy Issue Report The property `recalculateNeeded` does not seem to exist in `Controller`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
113		}
114
115		$firstTeam = $form->get('first_team');
116		$secondTeam = $form->get('second_team');
117
118		$serverInfo = $this->getServerInfo($form->get('server_address'));
119
120		if (!$match->isOfficial()) {
121		$match->setTeamColors(
122		$firstTeam->get('team')->getData(),
123		$secondTeam->get('team')->getData()
124		);
125		}
126
127		$match->setTeamPlayers(
128		$this->getPlayerList($firstTeam),
129		$this->getPlayerList($secondTeam)
130		);
131
132		$match->setTeamPoints(
133		$firstTeam->get('score')->getData(),
134		$secondTeam->get('score')->getData()
135		);
136
137		$match->setDuration($form->get('duration')->getData())
138		->setServerAddress($serverInfo[0], $serverInfo[1])
139		->setTimestamp($form->get('time')->getData())
140		->setMap($form->get('map')->getData()->getId());
141
142		if (!$match->isEloCorrect()) {
143		$this->controller->recalculateNeeded = true;
144		}
145		}
146
147		/**
148		* {@inheritdoc}
149		*/
150	1	public function enter($form)
151		{
152	1	$firstTeam = $form->get('first_team');
153	1	$secondTeam = $form->get('second_team');
154
155	1	$firstId = $firstTeam->get('team')->getData()->getId();
156	1	$secondId = $secondTeam->get('team')->getData()->getId();
157
158	1	$official = ($form->get('type')->getData() === \Match::OFFICIAL);
159	1	$serverInfo = $this->getServerInfo($form->get('server_address'));
160
161	1	$match = \Match::enterMatch(
162	1	$official ? $firstId : null,
163	1	$official ? $secondId : null,
164	1	$firstTeam->get('score')->getData(),
165	1	$secondTeam->get('score')->getData(),
166	1	$form->get('duration')->getData(),
167	1	$this->me->getId(),
168	1	$form->get('time')->getData(),
169	1	$this->getPlayerList($firstTeam),
170	1	$this->getPlayerList($secondTeam),
171	1	$serverInfo[0],
172	1	$serverInfo[1],
173	1	null,
174	1	$form->get('map')->getData()->getId(),
175	1	$form->get('type')->getData(),
176	1	$official ? null : $firstId,
177	1	$official ? null : $secondId
178		);
179
180	1	return $match;
181		}
182
183		/**
184		* Get the player list of a team
185		*
186		* @param FormInterface $team A MatchTeamType form
187		* @return array
188		*/
189	1	private function getPlayerList(FormInterface $team)
190		{
191	1	return array_map($this->getModelToID(), $team->get('participants')->getData());
192		}
193
194		/**
195		* Get the server address and port of a match
196		*
197		* @param FormInterface $server A text form representing the server
198		* @return array
199		*/
200	1	private function getServerInfo(FormInterface $server)
201		{
202	1	$serverInfo = explode(':', $server->getData());
203	1	if (!isset($serverInfo[1])) {
204	1	$serverInfo[1] = 5154;
205		}
206
207	1	return $serverInfo;
208		}
209
210		/**
211		* Get a function which converts models to their IDs
212		*
213		* Useful to store the match players into the database
214		*/
215		private static function getModelToID()
216		{
217	1	return function ($model) {
218	1	return $model->getId();
219	1	};
220		}
221		}
222

allejo / bzion

Push — fm-support ( 0de470...22a3ee )

MatchFormCreator::build() B

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like