Role::modifyPerm() - Code Metrics - Inspection of "Add 'matchType' parameter for match reports" - allejo/bzion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — fm-matches ( f867e2...7fc64f )

by Vladimir

created 2016-06-28 21:09 UTC

Role::modifyPerm() D

↳ Parent: Role

Complexity

Conditions	9
Paths	10

Size

Total Lines	29
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	9

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	29
ccs	17
cts	17
cp	1
rs	4.909
cc	9
eloc	17
nc	10
nop	2
crap	9

<?php
/**
 * This file contains functionality relating to roles a player can have on the website to perform certain tasks
 *
 * @package    BZiON\Models
 * @license    https://github.com/allejo/bzion/blob/master/LICENSE.md GNU General Public License Version 3
 */

/**
 * A role a player is assigned
 * @package    BZiON\Models
 */
class Role extends UrlModel implements NamedModel
{
    const DEVELOPER     = 1;
    const ADMINISTRATOR = 2;
    const COP           = 3;
    const REFEREE       = 4;
    const SYSADMIN      = 5;
    const PLAYER        = 6;
    const PLAYER_NO_PM  = 7;

    /**
     * The name of the role
     * @var string
     */
    protected $name;

    /**
     * Whether or not a role is reusable, when a player has a unique role, they will have their own role that isn't
     * reusable by other players
     * @var bool
     */
    protected $reusable;

    /**
     * Whether or not the role is protected from being deleted from the web interface
     * @var bool
     */
    protected $protected;

    /**
     * Whether or not to display this role on the 'Admins' page where it lists the league's leaders
     * @var bool
     */
    protected $display;

    /**
     * A Font Awesome CSS class for the icon to be used for the conversation
     *
     * @var string
     */
    protected $displayIcon;

    /**
     * A CSS class that will represent the color of the conversation in their tab
     *
     * @var string
     */
    protected $displayColor;

    /**
     * The collective name the conversation will be called if this role is displayed on the 'Admins' page
     * @var string
     */
    protected $displayName;

    /**
     * The order in which the role will be displayed on the 'Admins' page
     * @var int
     */
    protected $displayOrder;

    /**
     * An array of permissions a role has
     * @var bool[]
     */
    protected $permissions;

    /**
     * The name of the database table used for queries
     */
    const TABLE = "roles";

    const CREATE_PERMISSION = Permission::CREATE_ROLE;
    const EDIT_PERMISSION = Permission::EDIT_ROLE;
    const SOFT_DELETE_PERMISSION = Permission::SOFT_DELETE_ROLE;
    const HARD_DELETE_PERMISSION = Permission::HARD_DELETE_ROLE;

    /**
     * {@inheritdoc}
     */
    protected function assignResult($role)
    {
        $this->name         = $role['name'];
        $this->reusable     = $role['reusable'];
        $this->protected    = $role['protected'];
        $this->display      = $role['display'];
        $this->displayIcon  = $role['display_icon'];
        $this->displayColor = $role['display_color'];
        $this->displayName  = $role['display_name'];
        $this->displayOrder = $role['display_order'];
        $this->permissions  = array();

        $permissions = parent::fetchIds(
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            "JOIN role_permission ON role_permission.perm_id = permissions.id WHERE role_permission.role_id = ?", "i",
            array($this->id), "permissions", "name");

        foreach ($permissions as $permission) {
            $this->permissions[$permission] = true;
        }
    }

    /**
     * Check whether or not this role should appear on the "Admins" page
     *
     * @return bool True if the role should be displayed on the "Admins" page
     */
    public function displayAsLeader()
    {
        return (bool) $this->display;
    }

    /**
     * Get the color this role will have as the background in their badge
     *
     * @return string The color this role will have in their badge. If there is no color set, it will return green which has chosen
     *                randomly by a fair dice roll.
     */
    public function getDisplayColor()
    {
        return $this->displayColor;
    }

    /**
     * Get the "display name" of a role. The display name differs from the name of the role where the "Administrators"
     * role can be displayed as "League Council" when the role is used to displayed players assigned to this role.
     *
     * @return string Returns the display name. If the display name is blank, the role name will be returned.
     */
    public function getDisplayName()
    {
        return $this->displayName;
    }

    /**
     * Get the order this role should be displayed on the "Admins" page
     *
     * @return int The order the role should be displayed on the "Admins" page
     */
    public function getDisplayOrder()
    {
        return $this->displayOrder;
    }

    /**
     * Get the Font Awesome class that will be used as the symbol for the role on the "Admins" page
     *
     * @return string The Font Awesome class for the symbol
     */
    public function getDisplayIcon()
    {
        return $this->displayIcon;
    }

    /**
     * Get an array of players who have this role assigned to them
     *
     * @return Player[] An array of players with this role assigned to them
     */
    public function getUsers()
    {
        return Player::arrayIdToModel(
            parent::fetchIds(
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
                "JOIN player_roles ON player_roles.role_id = roles.id WHERE player_roles.role_id = ?", "i",
                array($this->getId()), "roles", "player_roles.user_id"
            )
        );
    }

    /**
     * Get the name of the role as displayed in the admin interface
     *
     * @return string The name of the conversation
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Check if this role is for a conversation of users or if it's a role for a single user
     *
     * @return bool True if multiple users can be assigned this role
     */
    public function isReusable()
    {
        return (bool) $this->reusable;
    }

    /**
     * Check if this role is protected from being deleted
     *
     * @return bool True if this role is protected from being deleted
     */
    public function isProtected()
    {
        return (bool) $this->protected;
    }

    /**
     * Add a permission to a role
     *
     * @param string $perm_name The name of the permission to add
     *
     * @return bool Whether or not the operation was successful
     */
    public function addPerm($perm_name)
    {
        return $this->modifyPerm($perm_name, "add");
    }

    /**
     * Get the permissions a role has
     *
     * @return bool[] An array of permissions
     */
    public function getPerms()
    {
        return $this->permissions;
    }

    /**
     * Return the permissions a role has as IDs
     *
     * @return int[]
     */
    protected function getPermIDs()
    {
        return parent::fetchIdsFrom("role_id", array($this->id), "i", false, "", "role_permission", "perm_id");
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Return the permissions a role has as models
     *
     * @return Permission[]
     */
    public function getPermObjects()
    {
        return Permission::arrayIdToModel($this->getPermIDs());
    }

    /**
     * Check whether a role has a specified permission
     *
     * @param string $permission The permission to check for
     *
     * @return bool Whether or not the role has the permission
     */
    public function hasPerm($permission)
    {
        return isset($this->permissions[$permission]);
    }

    /**
     * Revoke a permission from a role
     *
     * @param string $perm_name The permission to remove
     *
     * @return bool Whether or not the operation was successful
     */
    public function removePerm($perm_name)
    {
        return $this->modifyPerm($perm_name, "remove");
    }

    /**
     * Modify a permission a role has by either adding a new one or removing an old one
     *
     * @param string $perm_name The permission to add or remove
     * @param string $action    Whether to "add" or "remove" a permission
     *
     * @return bool
     */
    private function modifyPerm($perm_name, $action)
    {
        $name = ($perm_name instanceof Permission) ? $perm_name->getName() : $perm_name;

        if (($action == "remove" && !$this->hasPerm($name)) ||
            ($action == "add" && $this->hasPerm($name))) {
            return false;
        }

        $permission = Permission::getPermissionFromName($perm_name);

        if ($permission->isValid()) {
            if ($action == "add") {
                $this->db->query("INSERT INTO role_permission (role_id, perm_id) VALUES (?, ?)", "ii",
                    array($this->getId(), $permission->getId()));

                $this->permissions[$name] = true;
            } elseif ($action == "remove") {
                $this->db->query("DELETE FROM role_permission WHERE role_id = ? AND perm_id = ? LIMIT 1", "ii",
                    array($this->getId(), $permission->getId()));

                unset($this->permissions[$name]);
            }

            return true;
        }

        return false;
    }

    /**
     * Set the permissions of the role
     *
     * @todo   Consolidate this with Bans
     * @param  Permission[] $perms The permissions to set
     * @return self
     */
    public function setPerms($perms)
    {
        foreach ($perms as &$perm) {
            $perm = $perm->getId();
        }
        unset($perm);

        $oldPerms = $this->getPermIDs();

        $newPerms     = array_diff($perms, $oldPerms);
        $removedPerms = array_diff($oldPerms, $perms);

        foreach ($newPerms as $perm) {
            $this->addPerm(Permission::get($perm));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        foreach ($removedPerms as $perm) {
            $this->removePerm(Permission::get($perm));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return $this;
    }

    /**
     * Set the name of the role
     *
     * @param  string $name The new name of the role
     * @return self
     */
    public function setName($name)
    {
        return $this->updateProperty($this->name, 'name', $name, 's');
    }

    /**
     * Set whether the Role is displayed as a leader role
     *
     * @param  bool $display
     * @return self
     */
    public function setDisplayAsLeader($display)
    {
        return $this->updateProperty($this->display, 'display', (int) $display, 'i');
    }

    /**
     * Set the icon class of the role
     *
     * @param  string $displayIcon
     * @return self
     */
    public function setDisplayIcon($displayIcon)
    {
        return $this->updateProperty($this->displayIcon, 'display_icon', $displayIcon, 's');
    }

    /**
     * Set the color of the role
     *
     * @param  string $displayColor
     * @return self
     */
    public function setDisplayColor($displayColor)
    {
        return $this->updateProperty($this->displayColor, 'display_color', $displayColor, 's');
    }

    /**
     * Set the display name of the role
     *
     * @param  string $displayName
     * @return self
     */
    public function setDisplayName($displayName)
    {
        return $this->updateProperty($this->displayName, 'display_name', $displayName, 's');
    }

    /**
     * Set the display order of the role
     *
     * @param  int $displayOrder
     * @return self
     */
    public function setDisplayOrder($displayOrder)
    {
        return $this->updateProperty($this->displayOrder, 'display_order', $displayOrder, 'i');
    }

    /**
     * Create a new role
     *
     * @param string $name         The name of new role to be created
     * @param bool   $reusable     Whether or not to have the role
     * @param bool   $display      Whether or not to display the role on the 'Admins' page
     * @param string $displayIcon
     * @param string $displayColor
     * @param null   $displayName  The name that will be used on the 'Admins' page, if $display is set to true
     * @param int    $displayOrder The order the role will be displayed on, if $display is set to true
     *
     * @return \Role
     */
    public static function createNewRole($name, $reusable, $display = false, $displayIcon = "", $displayColor = "", $displayName = null, $displayOrder = 0)
    {
        return self::create(array(
            'name'          => $name,
            'reusable'      => $reusable,
            'protected'     => 0,
            'display'       => $display,
            'display_icon'  => $displayIcon,
            'display_color' => $displayColor,
            'display_name'  => $displayName,
            'display_order' => $displayOrder
        ), 'siiisssi');
    }

    /**
     * Get the roles a player has
     *
     * @param int $user_id The user ID to get the roles for
     *
     * @return Role[] An array of Roles a player belongs to
     */
    public static function getRoles($user_id)
    {
        return parent::arrayIdToModel(
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            parent::fetchIds(
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
                "JOIN player_roles ON player_roles.role_id = roles.id WHERE player_roles.user_id = ?", "i",
                array($user_id), "roles", "roles.id"
            )
        );
    }

    /**
     * Get the roles that should be displayed on the "Admins" page
     *
     * @return Role[] An array of Roles that should be displayed on the "Admins" page
     */
    public static function getLeaderRoles()
    {
        return parent::arrayIdToModel(
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            parent::fetchIds(
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
                "WHERE display = 1 ORDER BY display_order ASC"
            )
        );
    }

    /**
     * Get a query builder for Roles
     *
     * @return QueryBuilder
     */
    public static function getQueryBuilder()
    {
        return new QueryBuilder('Role', array(
            'columns' => array(
                'name'          => 'name',
                'display_order' => 'display_order'
            ),
            'name' => 'name'
        ));
    }
}


1		<?php
2		/**
3		* This file contains functionality relating to roles a player can have on the website to perform certain tasks
4		*
5		* @package BZiON\Models
6		* @license https://github.com/allejo/bzion/blob/master/LICENSE.md GNU General Public License Version 3
7		*/
8
9		/**
10		* A role a player is assigned
11		* @package BZiON\Models
12		*/
13		class Role extends UrlModel implements NamedModel
14		{
15		const DEVELOPER = 1;
16		const ADMINISTRATOR = 2;
17		const COP = 3;
18		const REFEREE = 4;
19		const SYSADMIN = 5;
20		const PLAYER = 6;
21		const PLAYER_NO_PM = 7;
22
23		/**
24		* The name of the role
25		* @var string
26		*/
27		protected $name;
28
29		/**
30		* Whether or not a role is reusable, when a player has a unique role, they will have their own role that isn't
31		* reusable by other players
32		* @var bool
33		*/
34		protected $reusable;
35
36		/**
37		* Whether or not the role is protected from being deleted from the web interface
38		* @var bool
39		*/
40		protected $protected;
41
42		/**
43		* Whether or not to display this role on the 'Admins' page where it lists the league's leaders
44		* @var bool
45		*/
46		protected $display;
47
48		/**
49		* A Font Awesome CSS class for the icon to be used for the conversation
50		*
51		* @var string
52		*/
53		protected $displayIcon;
54
55		/**
56		* A CSS class that will represent the color of the conversation in their tab
57		*
58		* @var string
59		*/
60		protected $displayColor;
61
62		/**
63		* The collective name the conversation will be called if this role is displayed on the 'Admins' page
64		* @var string
65		*/
66		protected $displayName;
67
68		/**
69		* The order in which the role will be displayed on the 'Admins' page
70		* @var int
71		*/
72		protected $displayOrder;
73
74		/**
75		* An array of permissions a role has
76		* @var bool[]
77		*/
78		protected $permissions;
79
80		/**
81		* The name of the database table used for queries
82		*/
83		const TABLE = "roles";
84
85		const CREATE_PERMISSION = Permission::CREATE_ROLE;
86		const EDIT_PERMISSION = Permission::EDIT_ROLE;
87		const SOFT_DELETE_PERMISSION = Permission::SOFT_DELETE_ROLE;
88		const HARD_DELETE_PERMISSION = Permission::HARD_DELETE_ROLE;
89
90		/**
91		* {@inheritdoc}
92		*/
93	5	protected function assignResult($role)
94		{
95	5	$this->name = $role['name'];
96	5	$this->reusable = $role['reusable'];
97	5	$this->protected = $role['protected'];
98	5	$this->display = $role['display'];
99	5	$this->displayIcon = $role['display_icon'];
100	5	$this->displayColor = $role['display_color'];
101	5	$this->displayName = $role['display_name'];
102	5	$this->displayOrder = $role['display_order'];
103	5	$this->permissions = array();
104
105	5	$permissions = parent::fetchIds(
		0 ignored issues – show Comprehensibility Bug introduced 2015-12-02 06:58 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`fetchIds()` instead of `assignResult()`). Are you sure this is correct? If so, you might want to change this to `$this->fetchIds()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
106	5	"JOIN role_permission ON role_permission.perm_id = permissions.id WHERE role_permission.role_id = ?", "i",
107	5	array($this->id), "permissions", "name");
108
109	5	foreach ($permissions as $permission) {
110	4	$this->permissions[$permission] = true;
111		}
112	5	}
113
114		/**
115		* Check whether or not this role should appear on the "Admins" page
116		*
117		* @return bool True if the role should be displayed on the "Admins" page
118		*/
119	2	public function displayAsLeader()
120		{
121	2	return (bool) $this->display;
122		}
123
124		/**
125		* Get the color this role will have as the background in their badge
126		*
127		* @return string The color this role will have in their badge. If there is no color set, it will return green which has chosen
128		* randomly by a fair dice roll.
129		*/
130	1	public function getDisplayColor()
131		{
132	1	return $this->displayColor;
133		}
134
135		/**
136		* Get the "display name" of a role. The display name differs from the name of the role where the "Administrators"
137		* role can be displayed as "League Council" when the role is used to displayed players assigned to this role.
138		*
139		* @return string Returns the display name. If the display name is blank, the role name will be returned.
140		*/
141	1	public function getDisplayName()
142		{
143	1	return $this->displayName;
144		}
145
146		/**
147		* Get the order this role should be displayed on the "Admins" page
148		*
149		* @return int The order the role should be displayed on the "Admins" page
150		*/
151	1	public function getDisplayOrder()
152		{
153	1	return $this->displayOrder;
154		}
155
156		/**
157		* Get the Font Awesome class that will be used as the symbol for the role on the "Admins" page
158		*
159		* @return string The Font Awesome class for the symbol
160		*/
161	1	public function getDisplayIcon()
162		{
163	1	return $this->displayIcon;
164		}
165
166		/**
167		* Get an array of players who have this role assigned to them
168		*
169		* @return Player[] An array of players with this role assigned to them
170		*/
171	1	public function getUsers()
172		{
173	1	return Player::arrayIdToModel(
174	1	parent::fetchIds(
		0 ignored issues – show Comprehensibility Bug introduced 2015-12-02 06:58 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`fetchIds()` instead of `getUsers()`). Are you sure this is correct? If so, you might want to change this to `$this->fetchIds()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
175	1	"JOIN player_roles ON player_roles.role_id = roles.id WHERE player_roles.role_id = ?", "i",
176	1	array($this->getId()), "roles", "player_roles.user_id"
177		)
178		);
179		}
180
181		/**
182		* Get the name of the role as displayed in the admin interface
183		*
184		* @return string The name of the conversation
185		*/
186	2	public function getName()
187		{
188	2	return $this->name;
189		}
190
191		/**
192		* Check if this role is for a conversation of users or if it's a role for a single user
193		*
194		* @return bool True if multiple users can be assigned this role
195		*/
196	1	public function isReusable()
197		{
198	1	return (bool) $this->reusable;
199		}
200
201		/**
202		* Check if this role is protected from being deleted
203		*
204		* @return bool True if this role is protected from being deleted
205		*/
206	2	public function isProtected()
207		{
208	2	return (bool) $this->protected;
209		}
210
211		/**
212		* Add a permission to a role
213		*
214		* @param string $perm_name The name of the permission to add
215		*
216		* @return bool Whether or not the operation was successful
217		*/
218	1	public function addPerm($perm_name)
219		{
220	1	return $this->modifyPerm($perm_name, "add");
221		}
222
223		/**
224		* Get the permissions a role has
225		*
226		* @return bool[] An array of permissions
227		*/
228	39	public function getPerms()
229		{
230	39	return $this->permissions;
231		}
232
233		/**
234		* Return the permissions a role has as IDs
235		*
236		* @return int[]
237		*/
238		protected function getPermIDs()
239		{
240		return parent::fetchIdsFrom("role_id", array($this->id), "i", false, "", "role_permission", "perm_id");
		0 ignored issues – show Comprehensibility Bug introduced 2016-03-14 01:13 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`fetchIdsFrom()` instead of `getPermIDs()`). Are you sure this is correct? If so, you might want to change this to `$this->fetchIdsFrom()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
241		}
242
243		/**
244		* Return the permissions a role has as models
245		*
246		* @return Permission[]
247		*/
248		public function getPermObjects()
249		{
250		return Permission::arrayIdToModel($this->getPermIDs());
251		}
252
253		/**
254		* Check whether a role has a specified permission
255		*
256		* @param string $permission The permission to check for
257		*
258		* @return bool Whether or not the role has the permission
259		*/
260	2	public function hasPerm($permission)
261		{
262	2	return isset($this->permissions[$permission]);
263		}
264
265		/**
266		* Revoke a permission from a role
267		*
268		* @param string $perm_name The permission to remove
269		*
270		* @return bool Whether or not the operation was successful
271		*/
272	1	public function removePerm($perm_name)
273		{
274	1	return $this->modifyPerm($perm_name, "remove");
275		}
276
277		/**
278		* Modify a permission a role has by either adding a new one or removing an old one
279		*
280		* @param string $perm_name The permission to add or remove
281		* @param string $action Whether to "add" or "remove" a permission
282		*
283		* @return bool
284		*/
285	1	private function modifyPerm($perm_name, $action)
286		{
287	1	$name = ($perm_name instanceof Permission) ? $perm_name->getName() : $perm_name;
288
289	1	if (($action == "remove" && !$this->hasPerm($name)) \|\|
290	1	($action == "add" && $this->hasPerm($name))) {
291	1	return false;
292		}
293
294	1	$permission = Permission::getPermissionFromName($perm_name);
295
296	1	if ($permission->isValid()) {
297	1	if ($action == "add") {
298	1	$this->db->query("INSERT INTO role_permission (role_id, perm_id) VALUES (?, ?)", "ii",
299	1	array($this->getId(), $permission->getId()));
300
301	1	$this->permissions[$name] = true;
302	1	} elseif ($action == "remove") {
303	1	$this->db->query("DELETE FROM role_permission WHERE role_id = ? AND perm_id = ? LIMIT 1", "ii",
304	1	array($this->getId(), $permission->getId()));
305
306	1	unset($this->permissions[$name]);
307		}
308
309	1	return true;
310		}
311
312	1	return false;
313		}
314
315		/**
316		* Set the permissions of the role
317		*
318		* @todo Consolidate this with Bans
319		* @param Permission[] $perms The permissions to set
320		* @return self
321		*/
322		public function setPerms($perms)
323		{
324		foreach ($perms as &$perm) {
325		$perm = $perm->getId();
326		}
327		unset($perm);
328
329		$oldPerms = $this->getPermIDs();
330
331		$newPerms = array_diff($perms, $oldPerms);
332		$removedPerms = array_diff($oldPerms, $perms);
333
334		foreach ($newPerms as $perm) {
335		$this->addPerm(Permission::get($perm));
		0 ignored issues – show Documentation introduced 2016-03-14 01:13 UTC by Report Bug Copy Issue Report `\Permission::get($perm)` is of type `object<Permission>\|null`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
336		}
337
338		foreach ($removedPerms as $perm) {
339		$this->removePerm(Permission::get($perm));
		0 ignored issues – show Documentation introduced 2016-03-14 01:13 UTC by Report Bug Copy Issue Report `\Permission::get($perm)` is of type `object<Permission>\|null`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
340		}
341
342		return $this;
343		}
344
345		/**
346		* Set the name of the role
347		*
348		* @param string $name The new name of the role
349		* @return self
350		*/
351		public function setName($name)
352		{
353		return $this->updateProperty($this->name, 'name', $name, 's');
354		}
355
356		/**
357		* Set whether the Role is displayed as a leader role
358		*
359		* @param bool $display
360		* @return self
361		*/
362		public function setDisplayAsLeader($display)
363		{
364		return $this->updateProperty($this->display, 'display', (int) $display, 'i');
365		}
366
367		/**
368		* Set the icon class of the role
369		*
370		* @param string $displayIcon
371		* @return self
372		*/
373		public function setDisplayIcon($displayIcon)
374		{
375		return $this->updateProperty($this->displayIcon, 'display_icon', $displayIcon, 's');
376		}
377
378		/**
379		* Set the color of the role
380		*
381		* @param string $displayColor
382		* @return self
383		*/
384		public function setDisplayColor($displayColor)
385		{
386		return $this->updateProperty($this->displayColor, 'display_color', $displayColor, 's');
387		}
388
389		/**
390		* Set the display name of the role
391		*
392		* @param string $displayName
393		* @return self
394		*/
395		public function setDisplayName($displayName)
396		{
397		return $this->updateProperty($this->displayName, 'display_name', $displayName, 's');
398		}
399
400		/**
401		* Set the display order of the role
402		*
403		* @param int $displayOrder
404		* @return self
405		*/
406		public function setDisplayOrder($displayOrder)
407		{
408		return $this->updateProperty($this->displayOrder, 'display_order', $displayOrder, 'i');
409		}
410
411		/**
412		* Create a new role
413		*
414		* @param string $name The name of new role to be created
415		* @param bool $reusable Whether or not to have the role
416		* @param bool $display Whether or not to display the role on the 'Admins' page
417		* @param string $displayIcon
418		* @param string $displayColor
419		* @param null $displayName The name that will be used on the 'Admins' page, if $display is set to true
420		* @param int $displayOrder The order the role will be displayed on, if $display is set to true
421		*
422		* @return \Role
423		*/
424	2	public static function createNewRole($name, $reusable, $display = false, $displayIcon = "", $displayColor = "", $displayName = null, $displayOrder = 0)
425		{
426	2	return self::create(array(
427	2	'name' => $name,
428	2	'reusable' => $reusable,
429	2	'protected' => 0,
430	2	'display' => $display,
431	2	'display_icon' => $displayIcon,
432	2	'display_color' => $displayColor,
433	2	'display_name' => $displayName,
434	2	'display_order' => $displayOrder
435	2	), 'siiisssi');
436		}
437
438		/**
439		* Get the roles a player has
440		*
441		* @param int $user_id The user ID to get the roles for
442		*
443		* @return Role[] An array of Roles a player belongs to
444		*/
445	39	public static function getRoles($user_id)
446		{
447	39	return parent::arrayIdToModel(
		0 ignored issues – show Comprehensibility Bug introduced 2015-12-02 06:58 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`arrayIdToModel()` instead of `getRoles()`). Are you sure this is correct? If so, you might want to change this to `$this->arrayIdToModel()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
448	39	parent::fetchIds(
		0 ignored issues – show Comprehensibility Bug introduced 2015-12-02 06:58 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`fetchIds()` instead of `getRoles()`). Are you sure this is correct? If so, you might want to change this to `$this->fetchIds()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
449	39	"JOIN player_roles ON player_roles.role_id = roles.id WHERE player_roles.user_id = ?", "i",
450	39	array($user_id), "roles", "roles.id"
451		)
452		);
453		}
454
455		/**
456		* Get the roles that should be displayed on the "Admins" page
457		*
458		* @return Role[] An array of Roles that should be displayed on the "Admins" page
459		*/
460	1	public static function getLeaderRoles()
461		{
462	1	return parent::arrayIdToModel(
		0 ignored issues – show Comprehensibility Bug introduced 2015-12-02 06:58 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`arrayIdToModel()` instead of `getLeaderRoles()`). Are you sure this is correct? If so, you might want to change this to `$this->arrayIdToModel()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
463	1	parent::fetchIds(
		0 ignored issues – show Comprehensibility Bug introduced 2015-12-02 06:58 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`fetchIds()` instead of `getLeaderRoles()`). Are you sure this is correct? If so, you might want to change this to `$this->fetchIds()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
464	1	"WHERE display = 1 ORDER BY display_order ASC"
465		)
466		);
467		}
468
469		/**
470		* Get a query builder for Roles
471		*
472		* @return QueryBuilder
473		*/
474		public static function getQueryBuilder()
475		{
476		return new QueryBuilder('Role', array(
477		'columns' => array(
478		'name' => 'name',
479		'display_order' => 'display_order'
480		),
481		'name' => 'name'
482		));
483		}
484		}
485

allejo / bzion

Push — fm-matches ( f867e2...7fc64f )

Role::modifyPerm() D

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like