PlayerStatusColumnConversion::up() - Code Metrics - Inspection of "Fix lazy loading for new modals; break old models" - allejo/bzion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/pixie-port ( 8213a1...132a2b )

by Vladimir

created 2018-02-14 08:47 UTC

PlayerStatusColumnConversion::up() B

↳ Parent: PlayerStatusColumnConversion

Complexity

Conditions	1
Paths	1

Size

Total Lines	27
Code Lines	19

Duplication

Lines	27
Ratio	100 %

Importance

Changes

Metric	Value
dl	27
loc	27
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	19
nc	1
nop	0

<?php

use Phinx\Migration\AbstractMigration;

class PlayerStatusColumnConversion extends AbstractMigration

{
    public function up()
    {
        $playersTable = $this->table('players');
        $playersTable
            ->addColumn('is_disabled', 'boolean', [
                'after' => 'last_login',
                'null' => false,
                'default' => false,
                'comment' => 'Whether or not this account has been disabled by an admin and cannot log in',
            ])
            ->addColumn('is_deleted', 'boolean', [
                'after' => 'is_disabled',
                'null' => false,
                'default' => false,
                'comment' => 'Whether or not this player has been soft-deleted',
            ])
            ->update()
        ;

        $this->query("UPDATE players SET is_deleted = 1 WHERE status = 'deleted';");
        $this->query("UPDATE players SET is_disabled = 1 WHERE status = 'disabled';");

        $playersTable
            ->removeColumn('status')
            ->update()
        ;
    }

    public function down()
    {
        $playersTable = $this->table('players');
        $playersTable
            ->addColumn('status', 'set', [
                'values' => ['active','disabled','deleted','reported','banned','test'],
                'null' => false,
                'default' => 'active',
                'comment' => 'The status of this player',
            ])
            ->update()
        ;

        $this->query("UPDATE players SET status = 'deleted' WHERE is_deleted = 1;");
        $this->query("UPDATE players SET status = 'disabled' WHERE is_disabled = 1;");

        $playersTable
            ->removeColumn('is_disabled')
            ->removeColumn('is_deleted')
            ->update()
        ;
    }
}


1		<?php
2
3		use Phinx\Migration\AbstractMigration;
4
5	View Code Duplication	class PlayerStatusColumnConversion extends AbstractMigration
		0 ignored issues – show Duplication introduced 2018-02-14 09:01 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
6		{
7		public function up()
8		{
9		$playersTable = $this->table('players');
10		$playersTable
11		->addColumn('is_disabled', 'boolean', [
12		'after' => 'last_login',
13		'null' => false,
14		'default' => false,
15		'comment' => 'Whether or not this account has been disabled by an admin and cannot log in',
16		])
17		->addColumn('is_deleted', 'boolean', [
18		'after' => 'is_disabled',
19		'null' => false,
20		'default' => false,
21		'comment' => 'Whether or not this player has been soft-deleted',
22		])
23		->update()
24		;
25
26		$this->query("UPDATE players SET is_deleted = 1 WHERE status = 'deleted';");
27		$this->query("UPDATE players SET is_disabled = 1 WHERE status = 'disabled';");
28
29		$playersTable
30		->removeColumn('status')
31		->update()
32		;
33		}
34
35		public function down()
36		{
37		$playersTable = $this->table('players');
38		$playersTable
39		->addColumn('status', 'set', [
40		'values' => ['active','disabled','deleted','reported','banned','test'],
41		'null' => false,
42		'default' => 'active',
43		'comment' => 'The status of this player',
44		])
45		->update()
46		;
47
48		$this->query("UPDATE players SET status = 'deleted' WHERE is_deleted = 1;");
49		$this->query("UPDATE players SET status = 'disabled' WHERE is_disabled = 1;");
50
51		$playersTable
52		->removeColumn('is_disabled')
53		->removeColumn('is_deleted')
54		->update()
55		;
56		}
57		}
58

allejo / bzion

Push — feature/pixie-port ( 8213a1...132a2b )

PlayerStatusColumnConversion::up() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like