PlayerController

Complexity

Total Complexity

27

Size/Duplication

Total Lines	168
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	18

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
C	showAction()	0	52	8
A	editAction()	0	13	2
C	listAction()	0	75	15
A	handleAdminNotesForm()	0	13	2

<?php

use BZIon\Form\Creator\PlayerAdminNotesFormCreator as FormCreator;
use Carbon\Carbon;
use Symfony\Component\Form\Form;
use Symfony\Component\HttpFoundation\Request;

class PlayerController extends JSONController
{
    private $creator;

    public function showAction(Player $player, Player $me, Request $request)
    {
        $formView = null;

        if ($me->hasPermission(Permission::VIEW_VISITOR_LOG) && !$this->isDemoMode()) {
            $this->creator = new FormCreator($player);
            $form = $this->creator->create()->handleRequest($request);

            if ($form->isValid()) {
                $form = $this->handleAdminNotesForm($form, $player, $me);
            }

            $formView = $form->createView();
        }

        $periods = [];
        $season = Season::getCurrentSeasonRange();
        $periodLength = round($season->getEndOfRange()->diffInDays($season->getStartOfRange()) / 30);
        $seasonStart = $season->getStartOfRange();

        for ($i = 0; $i < $periodLength; $i++) {
            $periods[] = $seasonStart->firstOfMonth()->copy();
            $periods[] = $seasonStart->day(15)->copy();
            $periods[] = $seasonStart->lastOfMonth()->copy();

            $seasonStart->addMonth();
        }

        $currentPeriod = new ArrayIterator($periods);
        $playerEloSeason = $player->getEloSeasonHistory();
        $seasonSummary = [];

        foreach ($playerEloSeason as $elo) {
            if ($elo['month'] > $currentPeriod->current()->month || $elo['day'] > $currentPeriod->current()->day) {
                $currentPeriod->next();
            }

            $seasonSummary[$currentPeriod->current()->format('M d')] = $elo['elo'];
        }

        $bans = Ban::getQueryBuilder()
            ->where('player', '=', $player->getId())
            ->getModels($fast = true)
        ;

        return array(
            'bans' => $bans,
            'player'         => $player,
            'seasonSummary'  => $seasonSummary,
            'adminNotesForm' => $formView,
        );
    }

    public function editAction(Player $player, Player $me)
    {
        if (!$me->canEdit($player)) {
            throw new ForbiddenException("You are not allowed to edit other players");
        }

        $params = array(
            'me'   => $player,
            'self' => false,
        );

        return $this->forward('edit', $params, 'Profile');
    }

    public function listAction(Request $request, Player $me, Team $team = null)
    {
        $query = Player::getQueryBuilder();

        // Load all countries into the cache so they are ready for later
        Country::getQueryBuilder()->addToCache();

        if ($team) {
            $query->where('team', '=', $team);
        } else {
            // Add all teams to the cache
            Team::getQueryBuilder()
                ->where('members', '>', 0)
                ->addToCache()
            ;
        }

        if ($request->query->has('exceptMe')) {
            $query->except($me);
        }

        $groupBy = $request->query->get('groupBy');
        $sortBy = $request->query->get('sortBy');
        $sortOrder = $request->query->get('sortOrder');

        $query
            ->active()
            ->withMatchActivity()
            ->orderBy('username')
        ;

        if (!$request->query->get('showAll')) {
            $query->having('activity', '>', 0);
        }

        if ($sortBy || $sortOrder) {
            $sortBy = $sortBy ? 'activity' : 'callsign';
            $sortOrder = $sortOrder ? 'DESC' : 'ASC';

            $query->orderBy($sortBy, $sortOrder);
        }

        $players = $query->getModels($fast = true);

        if ($groupBy) {
            $grouped = [];

            /** @var Player $player */
            foreach ($players as $player) {
                $key = '';

                if ($groupBy == 'country') {
                    $key = $player->getCountry()->getName();

It seems like you code against a specific sub-type and not the parent class Model as the method getCountry() does only exist in the following sub-classes of Model: Player, Server. Maybe you want to instanceof check for one of these explicitly?

                } elseif ($groupBy == 'team') {
                    $key = $player->getTeam()->getEscapedName();

It seems like you code against a specific sub-type and not the parent class Model as the method getTeam() does only exist in the following sub-classes of Model: Invitation, Player. Maybe you want to instanceof check for one of these explicitly?

                    if ($key == '<em>None</em>') {
                        $key = ' ';
                    }
                } elseif ($groupBy == 'activity') {
                    $key = ($player->getMatchActivity() > 0.0) ? 'Active' : 'Inactive';

It seems like you code against a specific sub-type and not the parent class Model as the method getMatchActivity() does only exist in the following sub-classes of Model: Player. Maybe you want to instanceof check for one of these explicitly?

                }

                $grouped[$key][] = $player;
            }

            ksort($grouped);
            $players = $grouped;
        }

        return array(
            'grouped' => ($groupBy !== null),
            'players' => $players,
        );
    }

    /**
     * Handle the admin notes form
     * @param  Form   $form   The form
     * @param  Player $player The player in question
     * @param  Player $me     The currently logged in player
     * @return Form   The updated form
     */
    private function handleAdminNotesForm($form, $player, $me)
    {
        $notes = $form->get('notes')->getData();
        if ($form->get('save_and_sign')->isClicked()) {

The method isClicked() does not seem to exist on object<Symfony\Component\Form\Form>.

            $notes .= ' — ' . $me->getUsername() . ' on ' . TimeDate::now()->toRFC2822String();
        }

        $player->setAdminNotes($notes);
        $this->getFlashBag()->add('success', "The admin notes for {$player->getUsername()} have been updated");

        // Reset the form so that the user sees the updated admin notes
        return $this->creator->create();
    }
}