BZIon\Form\Transformer\MultipleAdvancedModelTransformer

Complexity

Total Complexity

13

Size/Duplication

Total Lines	89
Duplicated Lines	7.87 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

73.68%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	addInclude()	0	12	2
C	reverseTransform()	7	53	11

<?php

namespace BZIon\Form\Transformer;

class MultipleAdvancedModelTransformer extends AdvancedModelTransformer
{
    /**
     * A list of Models to include to the results, even if they are not
     * specified by the user
     *
     * @var array
     */
    private $included = array();

    /**
     * Transforms data to an object
     *
     * @param  string $data
     * @return \Model[]
     */
    public function reverseTransform($data)
    {
        // Handle the data provided by Javascript, if any
        $transformed = self::transformJSON($data, $this->included);

        if ($transformed !== false) {
            return $transformed;
        }

        $models = array();

        foreach ($this->types as $type) {
            if (trim($data[$type]) === '') {
                continue;
            }

            // Array to store IDs for quick access so we can be sure that no
            // duplicates are saved
            $ids = array();

            // Add force-included models
            if (isset($this->included[$type])) {
                foreach ($this->included[$type] as $model) {
                    $ids[$model->getID()] = true; // Prevent duplication
                    $models[] = $model;
                }
            }

            $input = explode(',', $data[$type]);
            $input = array_unique(array_map('trim', $input));

            foreach ($input as $name) {
                if ($name === '') {
                    continue;
                }

                $model = $this->getModelFromName($name, $type);

Are you sure the assignment to $model is correct as $this->getModelFromName($name, $type) (which targets BZIon\Form\Transformer\AdvancedModelTransformer::getModelFromName()) seems to always return null.

                if (!$model) {
                    // No model was found matching that name
                    $models[] = $this->invalidModel($type);
                } elseif (!$model->isValid() || !isset($ids[$model->getID()])) {

This code seems to be duplicated across your project.

                    // We can proceed, since we're not storing a duplicate
                    // (We don't check invalid models, since they might be
                    // corresponding to different names)
                    $models[] = $model;
                    $ids[$model->getID()] = true;
                }
            }
        }

        return $models;
    }

    /**
     * Add a model to the list of models that should be included in all cases
     *
     * @param  \Model $model The model to include
     * @throws \Exception When a model is of an unsupported type
     */
    public function addInclude(\Model $model)
    {
        $type = strtolower($model->getType());

        if (!in_array($type, $this->types)) {
            throw new \Exception(
                "Objects of type \"{$model->getTypeForHumans()}\" are not supported"
            );
        }

        $this->included[$type][] = $model;
    }
}