MapsStatusColumnConversion::down() - Code Metrics - Inspection of "Update Map model to use new QB" - allejo/bzion - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/pixie-port ( df821c...dee960 )

by Vladimir

created 2018-02-10 23:08 UTC

MapsStatusColumnConversion::down() A

↳ Parent: MapsStatusColumnConversion

Complexity

Conditions	1
Paths	1

Size

Total Lines	21
Code Lines	14

Duplication

Lines	21
Ratio	100 %

Importance

Changes

Metric	Value
dl	21
loc	21
rs	9.3142
c	0
b	0
f	0
cc	1
eloc	14
nc	1
nop	0

<?php

use Phinx\Migration\AbstractMigration;

class MapsStatusColumnConversion extends AbstractMigration
{
    public function up()

    {
        $mapsTable = $this->table('maps');
        $mapsTable
            ->addColumn('is_inactive', 'boolean', [
                'after' => 'game_mode',
                'null' => false,
                'default' => false,
                'comment' => 'Whether or not this map has been marked as inactive, meaning a map is no longer in active rotation on servers',
            ])
            ->addColumn('is_deleted', 'boolean', [
                'after' => 'is_inactive',
                'null' => false,
                'default' => false,
                'comment' => 'Whether or not this map has been soft deleted'
            ])
            ->update()
        ;

        $this->query("UPDATE maps SET is_inactive = 1 WHERE status = 'hidden' OR status = 'disabled';");
        $this->query("UPDATE maps SET is_deleted = 1 WHERE status = 'deleted';");

        $mapsTable
            ->removeColumn('status')
            ->update()
        ;
    }

    public function down()

    {
        $mapsTable = $this->table('maps');
        $mapsTable
            ->addColumn('status', 'set', [
                'values' => ['active', 'hidden', 'disabled', 'deleted'],
                'null' => false,
                'default' => 'active',
                'comment' => 'The status of the map',
            ])
            ->update()
        ;

        $this->query("UPDATE maps SET status = 'hidden' WHERE is_inactive = 1;");
        $this->query("UPDATE maps SET status = 'deleted' WHERE is_deleted = 1;");

        $mapsTable
            ->removeColumn('is_inactive')
            ->removeColumn('is_deleted')
        ;
    }
}


1		<?php
2
3		use Phinx\Migration\AbstractMigration;
4
5		class MapsStatusColumnConversion extends AbstractMigration
6		{
7	View Code Duplication	public function up()
		0 ignored issues – show Duplication introduced 2018-02-10 23:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		$mapsTable = $this->table('maps');
10		$mapsTable
11		->addColumn('is_inactive', 'boolean', [
12		'after' => 'game_mode',
13		'null' => false,
14		'default' => false,
15		'comment' => 'Whether or not this map has been marked as inactive, meaning a map is no longer in active rotation on servers',
16		])
17		->addColumn('is_deleted', 'boolean', [
18		'after' => 'is_inactive',
19		'null' => false,
20		'default' => false,
21		'comment' => 'Whether or not this map has been soft deleted'
22		])
23		->update()
24		;
25
26		$this->query("UPDATE maps SET is_inactive = 1 WHERE status = 'hidden' OR status = 'disabled';");
27		$this->query("UPDATE maps SET is_deleted = 1 WHERE status = 'deleted';");
28
29		$mapsTable
30		->removeColumn('status')
31		->update()
32		;
33		}
34
35	View Code Duplication	public function down()
		0 ignored issues – show Duplication introduced 2018-02-10 23:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$mapsTable = $this->table('maps');
38		$mapsTable
39		->addColumn('status', 'set', [
40		'values' => ['active', 'hidden', 'disabled', 'deleted'],
41		'null' => false,
42		'default' => 'active',
43		'comment' => 'The status of the map',
44		])
45		->update()
46		;
47
48		$this->query("UPDATE maps SET status = 'hidden' WHERE is_inactive = 1;");
49		$this->query("UPDATE maps SET status = 'deleted' WHERE is_deleted = 1;");
50
51		$mapsTable
52		->removeColumn('is_inactive')
53		->removeColumn('is_deleted')
54		;
55		}
56		}
57

allejo / bzion

Push — feature/pixie-port ( df821c...dee960 )

MapsStatusColumnConversion::down() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like