allejo /
bzion
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Player often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Player, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 16 | class Player extends AvatarModel implements NamedModel |
||
| 17 | { |
||
| 18 | /** |
||
| 19 | * These are built-in roles that cannot be deleted via the web interface so we will be storing these values as |
||
| 20 | * constant variables. Hopefully, a user won't be silly enough to delete them manually from the database. |
||
| 21 | * |
||
| 22 | * @TODO Deprecate these and use the Role constants |
||
| 23 | */ |
||
| 24 | const DEVELOPER = Role::DEVELOPER; |
||
| 25 | const ADMIN = Role::ADMINISTRATOR; |
||
| 26 | const COP = Role::COP; |
||
| 27 | const REFEREE = Role::REFEREE; |
||
| 28 | const S_ADMIN = Role::SYSADMIN; |
||
| 29 | const PLAYER = Role::PLAYER; |
||
| 30 | const PLAYER_NO_PM = Role::PLAYER_NO_PM; |
||
| 31 | |||
| 32 | /** |
||
| 33 | * The bzid of the player |
||
| 34 | * @var int |
||
| 35 | */ |
||
| 36 | protected $bzid; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * The id of the player's team |
||
| 40 | * @var int |
||
| 41 | */ |
||
| 42 | protected $team; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * The player's status |
||
| 46 | * @var string |
||
| 47 | */ |
||
| 48 | protected $status; |
||
| 49 | |||
| 50 | /** |
||
| 51 | * The player's e-mail address |
||
| 52 | * @var string |
||
| 53 | */ |
||
| 54 | protected $email; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * Whether the player has verified their e-mail address |
||
| 58 | * @var bool |
||
| 59 | */ |
||
| 60 | protected $verified; |
||
| 61 | |||
| 62 | /** |
||
| 63 | * What kind of events the player should be e-mailed about |
||
| 64 | * @var string |
||
| 65 | */ |
||
| 66 | protected $receives; |
||
| 67 | |||
| 68 | /** |
||
| 69 | * A confirmation code for the player's e-mail address verification |
||
| 70 | * @var string |
||
| 71 | */ |
||
| 72 | protected $confirmCode; |
||
| 73 | |||
| 74 | /** |
||
| 75 | * Whether the callsign of the player is outdated |
||
| 76 | * @var bool |
||
| 77 | */ |
||
| 78 | protected $outdated; |
||
| 79 | |||
| 80 | /** |
||
| 81 | * The player's profile description |
||
| 82 | * @var string |
||
| 83 | */ |
||
| 84 | protected $description; |
||
| 85 | |||
| 86 | /** |
||
| 87 | * The id of the player's country |
||
| 88 | * @var int |
||
| 89 | */ |
||
| 90 | protected $country; |
||
| 91 | |||
| 92 | /** |
||
| 93 | * The player's timezone PHP identifier, e.g. "Europe/Paris" |
||
| 94 | * @var string |
||
| 95 | */ |
||
| 96 | protected $timezone; |
||
| 97 | |||
| 98 | /** |
||
| 99 | * The date the player joined the site |
||
| 100 | * @var TimeDate |
||
| 101 | */ |
||
| 102 | protected $joined; |
||
| 103 | |||
| 104 | /** |
||
| 105 | * The date of the player's last login |
||
| 106 | * @var TimeDate |
||
| 107 | */ |
||
| 108 | protected $last_login; |
||
| 109 | |||
| 110 | /** |
||
| 111 | * The roles a player belongs to |
||
| 112 | * @var Role[] |
||
| 113 | */ |
||
| 114 | protected $roles; |
||
| 115 | |||
| 116 | /** |
||
| 117 | * The permissions a player has |
||
| 118 | * @var Permission[] |
||
| 119 | */ |
||
| 120 | protected $permissions; |
||
| 121 | |||
| 122 | /** |
||
| 123 | * A section for admins to write notes about players |
||
| 124 | * @var string |
||
| 125 | */ |
||
| 126 | protected $admin_notes; |
||
| 127 | |||
| 128 | /** |
||
| 129 | * The ban of the player, or null if the player is not banned |
||
| 130 | * @var Ban|null |
||
| 131 | */ |
||
| 132 | protected $player; |
||
| 133 | |||
| 134 | /** |
||
| 135 | * The cached match count for a player |
||
| 136 | * |
||
| 137 | * @var int |
||
| 138 | */ |
||
| 139 | private $cachedMatchCount = null; |
||
| 140 | |||
| 141 | /** |
||
| 142 | * The name of the database table used for queries |
||
| 143 | */ |
||
| 144 | const TABLE = "players"; |
||
| 145 | |||
| 146 | /** |
||
| 147 | * The location where avatars will be stored |
||
| 148 | */ |
||
| 149 | const AVATAR_LOCATION = "/web/assets/imgs/avatars/players/"; |
||
| 150 | |||
| 151 | const EDIT_PERMISSION = Permission::EDIT_USER; |
||
| 152 | const SOFT_DELETE_PERMISSION = Permission::SOFT_DELETE_USER; |
||
| 153 | const HARD_DELETE_PERMISSION = Permission::HARD_DELETE_USER; |
||
| 154 | |||
| 155 | /** |
||
| 156 | * {@inheritdoc} |
||
| 157 | */ |
||
| 158 | 39 | protected function assignResult($player) |
|
| 168 | |||
| 169 | /** |
||
| 170 | * {@inheritdoc} |
||
| 171 | */ |
||
| 172 | 39 | protected function assignLazyResult($player) |
|
| 188 | |||
| 189 | /** |
||
| 190 | * Add a player a new role |
||
| 191 | * |
||
| 192 | * @param Role|int $role_id The role ID to add a player to |
||
| 193 | * |
||
| 194 | * @return bool Whether the operation was successful or not |
||
| 195 | */ |
||
| 196 | 39 | public function addRole($role_id) |
|
| 216 | |||
| 217 | /** |
||
| 218 | * Get the notes admins have left about a player |
||
| 219 | * @return string The notes |
||
| 220 | */ |
||
| 221 | public function getAdminNotes() |
||
| 227 | |||
| 228 | /** |
||
| 229 | * Get the player's BZID |
||
| 230 | * @return int The BZID |
||
| 231 | */ |
||
| 232 | public function getBZID() |
||
| 236 | |||
| 237 | /** |
||
| 238 | * Get the country a player belongs to |
||
| 239 | * |
||
| 240 | * @return Country The country belongs to |
||
| 241 | */ |
||
| 242 | 1 | public function getCountry() |
|
| 246 | |||
| 247 | /** |
||
| 248 | * Get the e-mail address of the player |
||
| 249 | * |
||
| 250 | * @return string The address |
||
| 251 | */ |
||
| 252 | public function getEmailAddress() |
||
| 258 | |||
| 259 | /** |
||
| 260 | * Returns whether the player has verified their e-mail address |
||
| 261 | * |
||
| 262 | * @return bool `true` for verified players |
||
| 263 | */ |
||
| 264 | public function isVerified() |
||
| 270 | |||
| 271 | /** |
||
| 272 | * Returns the confirmation code for the player's e-mail address verification |
||
| 273 | * |
||
| 274 | * @return string The player's confirmation code |
||
| 275 | */ |
||
| 276 | public function getConfirmCode() |
||
| 282 | |||
| 283 | /** |
||
| 284 | * Returns what kind of events the player should be e-mailed about |
||
| 285 | * |
||
| 286 | * @return string The type of notifications |
||
| 287 | */ |
||
| 288 | public function getReceives() |
||
| 294 | |||
| 295 | /** |
||
| 296 | * Finds out whether the specified player wants and can receive an e-mail |
||
| 297 | * message |
||
| 298 | * |
||
| 299 | * @param string $type |
||
| 300 | * @return bool `true` if the player should be sent an e-mail |
||
| 301 | */ |
||
| 302 | 1 | public function canReceive($type) |
|
| 317 | |||
| 318 | /** |
||
| 319 | * Find out whether the specified confirmation code is correct |
||
| 320 | * |
||
| 321 | * This method protects against timing attacks |
||
| 322 | * |
||
| 323 | * @return bool `true` for a correct e-mail verification code |
||
| 324 | */ |
||
| 325 | public function isCorrectConfirmCode($code) |
||
| 335 | |||
| 336 | /** |
||
| 337 | * Get the player's sanitized description |
||
| 338 | * @return string The description |
||
| 339 | */ |
||
| 340 | public function getDescription() |
||
| 346 | |||
| 347 | /** |
||
| 348 | * Get the joined date of the player |
||
| 349 | * @return TimeDate The joined date of the player |
||
| 350 | */ |
||
| 351 | public function getJoinedDate() |
||
| 357 | |||
| 358 | /** |
||
| 359 | * Get all of the known IPs used by the player |
||
| 360 | * |
||
| 361 | * @return string[][] An array containing IPs and hosts |
||
| 362 | */ |
||
| 363 | public function getKnownIPs() |
||
| 367 | |||
| 368 | /** |
||
| 369 | * Get the last login for a player |
||
| 370 | * @return TimeDate The date of the last login |
||
| 371 | */ |
||
| 372 | public function getLastLogin() |
||
| 378 | |||
| 379 | /** |
||
| 380 | * Get all of the callsigns a player has used to log in to the website |
||
| 381 | * @return string[] An array containing all of the past callsigns recorded for a player |
||
| 382 | */ |
||
| 383 | public function getPastCallsigns() |
||
| 387 | |||
| 388 | /** |
||
| 389 | * Get the player's team |
||
| 390 | * @return Team The object representing the team |
||
| 391 | */ |
||
| 392 | 2 | public function getTeam() |
|
| 396 | |||
| 397 | /** |
||
| 398 | * Get the player's timezone PHP identifier (example: "Europe/Paris") |
||
| 399 | * @return string The timezone |
||
| 400 | */ |
||
| 401 | 1 | public function getTimezone() |
|
| 407 | |||
| 408 | /** |
||
| 409 | * Rebuild the list of permissions a user has been granted |
||
| 410 | */ |
||
| 411 | 39 | private function updateUserPermissions() |
|
| 420 | |||
| 421 | /** |
||
| 422 | * Check if a player has a specific permission |
||
| 423 | * |
||
| 424 | * @param string|null $permission The permission to check for |
||
| 425 | * |
||
| 426 | * @return bool Whether or not the player has the permission |
||
| 427 | */ |
||
| 428 | 2 | public function hasPermission($permission) |
|
| 438 | |||
| 439 | /** |
||
| 440 | * Check whether the callsign of the player is outdated |
||
| 441 | * |
||
| 442 | * Returns true if this player has probably changed their callsign, making |
||
| 443 | * the current username stored in the database obsolete |
||
| 444 | * |
||
| 445 | * @return bool Whether or not the player is disabled |
||
| 446 | */ |
||
| 447 | public function isOutdated() |
||
| 453 | |||
| 454 | /** |
||
| 455 | * Check if a player's account has been disabled |
||
| 456 | * |
||
| 457 | * @return bool Whether or not the player is disabled |
||
| 458 | */ |
||
| 459 | public function isDisabled() |
||
| 463 | |||
| 464 | /** |
||
| 465 | * Check if everyone can log in as this user on a test environment |
||
| 466 | * |
||
| 467 | * @return bool |
||
| 468 | */ |
||
| 469 | 1 | public function isTestUser() |
|
| 473 | |||
| 474 | /** |
||
| 475 | * Check if a player is teamless |
||
| 476 | * |
||
| 477 | * @return bool True if the player is teamless |
||
| 478 | */ |
||
| 479 | 18 | public function isTeamless() |
|
| 483 | |||
| 484 | /** |
||
| 485 | * Mark a player's account as banned |
||
| 486 | */ |
||
| 487 | 1 | public function markAsBanned() |
|
| 495 | |||
| 496 | /** |
||
| 497 | * Mark a player's account as unbanned |
||
| 498 | */ |
||
| 499 | public function markAsUnbanned() |
||
| 507 | |||
| 508 | /** |
||
| 509 | * Find out if a player is banned |
||
| 510 | * |
||
| 511 | * @return bool |
||
| 512 | */ |
||
| 513 | 2 | public function isBanned() |
|
| 517 | |||
| 518 | /** |
||
| 519 | * Get the ban of the player |
||
| 520 | * |
||
| 521 | * This method performs a load of all the lazy parameters of the Player |
||
| 522 | * |
||
| 523 | * @return Ban|null The current ban of the player, or null if the player is |
||
| 524 | * is not banned |
||
| 525 | */ |
||
| 526 | public function getBan() |
||
| 532 | |||
| 533 | /** |
||
| 534 | * Remove a player from a role |
||
| 535 | * |
||
| 536 | * @param int $role_id The role ID to add or remove |
||
| 537 | * |
||
| 538 | * @return bool Whether the operation was successful or not |
||
| 539 | */ |
||
| 540 | public function removeRole($role_id) |
||
| 547 | |||
| 548 | /** |
||
| 549 | * Set the player's email address and reset their verification status |
||
| 550 | * @param string $email The address |
||
| 551 | */ |
||
| 552 | public function setEmailAddress($email) |
||
| 567 | |||
| 568 | /** |
||
| 569 | * Set whether the player has verified their e-mail address |
||
| 570 | * |
||
| 571 | * @param bool $verified Whether the player is verified or not |
||
| 572 | * @return self |
||
| 573 | */ |
||
| 574 | public function setVerified($verified) |
||
| 584 | |||
| 585 | /** |
||
| 586 | * Generate a new random confirmation token for e-mail address verification |
||
| 587 | * |
||
| 588 | * @return self |
||
| 589 | */ |
||
| 590 | public function generateNewConfirmCode() |
||
| 597 | |||
| 598 | /** |
||
| 599 | * Set the confirmation token for e-mail address verification |
||
| 600 | * |
||
| 601 | * @param string $code The confirmation code |
||
| 602 | * @return self |
||
| 603 | */ |
||
| 604 | private function setConfirmCode($code) |
||
| 610 | |||
| 611 | /** |
||
| 612 | * Set what kind of events the player should be e-mailed about |
||
| 613 | * |
||
| 614 | * @param string $receives The type of notification |
||
| 615 | * @return self |
||
| 616 | */ |
||
| 617 | public function setReceives($receives) |
||
| 623 | |||
| 624 | /** |
||
| 625 | * Set whether the callsign of the player is outdated |
||
| 626 | * |
||
| 627 | * @param bool $outdated Whether the callsign is outdated |
||
| 628 | * @return self |
||
| 629 | */ |
||
| 630 | 39 | public function setOutdated($outdated) |
|
| 636 | |||
| 637 | /** |
||
| 638 | * Set the player's description |
||
| 639 | * @param string $description The description |
||
| 640 | */ |
||
| 641 | public function setDescription($description) |
||
| 646 | |||
| 647 | /** |
||
| 648 | * Set the player's timezone |
||
| 649 | * @param string $timezone The timezone |
||
| 650 | */ |
||
| 651 | public function setTimezone($timezone) |
||
| 656 | |||
| 657 | /** |
||
| 658 | * Set the player's team |
||
| 659 | * @param int $team The team's ID |
||
| 660 | */ |
||
| 661 | 18 | public function setTeam($team) |
|
| 666 | |||
| 667 | /** |
||
| 668 | * Set the player's status |
||
| 669 | * @param string $status The new status |
||
| 670 | */ |
||
| 671 | public function setStatus($status) |
||
| 675 | |||
| 676 | /** |
||
| 677 | * Set the player's admin notes |
||
| 678 | * @param string $admin_notes The new admin notes |
||
| 679 | * @return self |
||
| 680 | */ |
||
| 681 | public function setAdminNotes($admin_notes) |
||
| 685 | |||
| 686 | /** |
||
| 687 | * Set the player's country |
||
| 688 | * @param int $country The ID of the new country |
||
| 689 | * @return self |
||
| 690 | */ |
||
| 691 | public function setCountry($country) |
||
| 695 | |||
| 696 | /** |
||
| 697 | * Updates this player's last login |
||
| 698 | */ |
||
| 699 | public function updateLastLogin() |
||
| 703 | |||
| 704 | /** |
||
| 705 | * Get the player's username |
||
| 706 | * @return string The username |
||
| 707 | */ |
||
| 708 | 1 | public function getUsername() |
|
| 712 | |||
| 713 | /** |
||
| 714 | * Get the player's username, safe for use in your HTML |
||
| 715 | * @return string The username |
||
| 716 | */ |
||
| 717 | 1 | public function getEscapedUsername() |
|
| 721 | |||
| 722 | /** |
||
| 723 | * Alias for Player::setUsername() |
||
| 724 | * |
||
| 725 | * @param string $username The new username |
||
| 726 | * @return self |
||
| 727 | */ |
||
| 728 | public function setName($username) |
||
| 732 | |||
| 733 | /** |
||
| 734 | * Mark all the unread messages of a player as read |
||
| 735 | * |
||
| 736 | * @return void |
||
| 737 | */ |
||
| 738 | public function markMessagesAsRead() |
||
| 745 | |||
| 746 | /** |
||
| 747 | * Set the roles of a user |
||
| 748 | * |
||
| 749 | * @todo Is it worth making this faster? |
||
| 750 | * @param Role[] $roles The new roles of the user |
||
| 751 | * @return self |
||
| 752 | */ |
||
| 753 | public function setRoles($roles) |
||
| 776 | |||
| 777 | /** |
||
| 778 | * Give or remove a role to/form a player |
||
| 779 | * |
||
| 780 | * @param int $role_id The role ID to add or remove |
||
| 781 | * @param string $action Whether to "add" or "remove" a role for a player |
||
| 782 | * |
||
| 783 | * @return bool Whether the operation was successful or not |
||
| 784 | */ |
||
| 785 | 39 | private function modifyRole($role_id, $action) |
|
| 803 | |||
| 804 | /** |
||
| 805 | * Given a player's BZID, get a player object |
||
| 806 | * |
||
| 807 | * @param int $bzid The player's BZID |
||
| 808 | * @return Player |
||
| 809 | */ |
||
| 810 | 1 | public static function getFromBZID($bzid) |
|
| 814 | |||
| 815 | /** |
||
| 816 | * Get a single player by their username |
||
| 817 | * |
||
| 818 | * @param string $username The username to look for |
||
| 819 | * @return Player |
||
| 820 | */ |
||
| 821 | 1 | public static function getFromUsername($username) |
|
| 827 | |||
| 828 | /** |
||
| 829 | * Get all the players in the database that have an active status |
||
| 830 | * @return Player[] An array of player BZIDs |
||
| 831 | */ |
||
| 832 | public static function getPlayers() |
||
| 838 | |||
| 839 | /** |
||
| 840 | * Show the number of notifications the user hasn't read yet |
||
| 841 | * @return int |
||
| 842 | */ |
||
| 843 | 1 | public function countUnreadNotifications() |
|
| 847 | |||
| 848 | /** |
||
| 849 | * Count the number of matches a player has participated in |
||
| 850 | * @return int |
||
| 851 | */ |
||
| 852 | public function getMatchCount() |
||
| 863 | |||
| 864 | /** |
||
| 865 | * Get the (victory/total matches) ratio of the player |
||
| 866 | * @return float |
||
| 867 | */ |
||
| 868 | public function getMatchWinRatio() |
||
| 882 | |||
| 883 | /** |
||
| 884 | * Show the number of messages the user hasn't read yet |
||
| 885 | * @return int |
||
| 886 | */ |
||
| 887 | 1 | public function countUnreadMessages() |
|
| 893 | |||
| 894 | /** |
||
| 895 | * Get all of the members belonging to a team |
||
| 896 | * @param int $teamID The ID of the team to fetch the members of |
||
| 897 | * @return Player[] An array of Player objects of the team members |
||
| 898 | */ |
||
| 899 | 2 | public static function getTeamMembers($teamID) |
|
| 905 | |||
| 906 | /** |
||
| 907 | * {@inheritdoc} |
||
| 908 | */ |
||
| 909 | 1 | public static function getActiveStatuses() |
|
| 913 | |||
| 914 | /** |
||
| 915 | * {@inheritdoc} |
||
| 916 | */ |
||
| 917 | 39 | public static function getEagerColumns() |
|
| 921 | |||
| 922 | /** |
||
| 923 | * {@inheritdoc} |
||
| 924 | */ |
||
| 925 | 39 | public static function getLazyColumns() |
|
| 929 | |||
| 930 | /** |
||
| 931 | * Get a query builder for players |
||
| 932 | * @return QueryBuilder |
||
| 933 | */ |
||
| 934 | View Code Duplication | public static function getQueryBuilder() |
|
| 946 | |||
| 947 | /** |
||
| 948 | * Enter a new player to the database |
||
| 949 | * @param int $bzid The player's bzid |
||
| 950 | * @param string $username The player's username |
||
| 951 | * @param int $team The player's team |
||
| 952 | * @param string $status The player's status |
||
| 953 | * @param int $role_id The player's role when they are first created |
||
| 954 | * @param string $avatar The player's profile avatar |
||
| 955 | * @param string $description The player's profile description |
||
| 956 | * @param int $country The player's country |
||
| 957 | * @param string $timezone The player's timezone |
||
| 958 | * @param string|\TimeDate $joined The date the player joined |
||
| 959 | * @param string|\TimeDate $last_login The timestamp of the player's last login |
||
| 960 | * @return Player An object representing the player that was just entered |
||
| 961 | */ |
||
| 962 | 39 | public static function newPlayer($bzid, $username, $team = null, $status = "active", $role_id = self::PLAYER, $avatar = "", $description = "", $country = 1, $timezone = null, $joined = "now", $last_login = "now") |
|
| 988 | |||
| 989 | /** |
||
| 990 | * Determine if a player exists in the database |
||
| 991 | * @param int $bzid The player's bzid |
||
| 992 | * @return bool Whether the player exists in the database |
||
| 993 | */ |
||
| 994 | public static function playerBZIDExists($bzid) |
||
| 998 | |||
| 999 | /** |
||
| 1000 | * Change a player's callsign and add it to the database if it does not |
||
| 1001 | * exist as a past callsign |
||
| 1002 | * |
||
| 1003 | * @param string $username The new username of the player |
||
| 1004 | * @return self |
||
| 1005 | */ |
||
| 1006 | 39 | public function setUsername($username) |
|
| 1037 | |||
| 1038 | /** |
||
| 1039 | * Alphabetical order function for use in usort (case-insensitive) |
||
| 1040 | * @return Closure The sort function |
||
| 1041 | */ |
||
| 1042 | public static function getAlphabeticalSort() |
||
| 1048 | |||
| 1049 | /** |
||
| 1050 | * {@inheritdoc} |
||
| 1051 | * @todo Add a constraint that does this automatically |
||
| 1052 | */ |
||
| 1053 | 39 | public function wipe() |
|
| 1059 | |||
| 1060 | /** |
||
| 1061 | * Find whether the player can delete a model |
||
| 1062 | * |
||
| 1063 | * @param PermissionModel $model The model that will be seen |
||
| 1064 | * @param bool $showDeleted Whether to show deleted models to admins |
||
| 1065 | * @return bool |
||
| 1066 | */ |
||
| 1067 | 1 | public function canSee($model, $showDeleted = false) |
|
| 1071 | |||
| 1072 | /** |
||
| 1073 | * Find whether the player can delete a model |
||
| 1074 | * |
||
| 1075 | * @param PermissionModel $model The model that will be deleted |
||
| 1076 | * @param bool $hard Whether to check for hard-delete perms, as opposed |
||
| 1077 | * to soft-delete ones |
||
| 1078 | * @return bool |
||
| 1079 | */ |
||
| 1080 | 1 | public function canDelete($model, $hard = false) |
|
| 1088 | |||
| 1089 | /** |
||
| 1090 | * Find whether the player can create a model |
||
| 1091 | * |
||
| 1092 | * @param string $modelName The PHP class identifier of the model type |
||
| 1093 | * @return bool |
||
| 1094 | */ |
||
| 1095 | 1 | public function canCreate($modelName) |
|
| 1099 | |||
| 1100 | /** |
||
| 1101 | * Find whether the player can edit a model |
||
| 1102 | * |
||
| 1103 | * @param PermissionModel $model The model which will be edited |
||
| 1104 | * @return bool |
||
| 1105 | */ |
||
| 1106 | 1 | public function canEdit($model) |
|
| 1110 | } |
||
| 1111 |
Loading history...
In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:
Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: