allejo /
bzion
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 27 |
| Code Lines | 19 |
| Lines | 27 |
| Ratio | 100 % |
| Changes | 0 | ||
| 1 | <?php |
||
| 7 | public function up() |
||
| 8 | { |
||
| 9 | $mapsTable = $this->table('maps'); |
||
| 10 | $mapsTable |
||
| 11 | ->addColumn('is_inactive', 'boolean', [ |
||
| 12 | 'after' => 'game_mode', |
||
| 13 | 'null' => false, |
||
| 14 | 'default' => false, |
||
| 15 | 'comment' => 'Whether or not this map has been marked as inactive, meaning a map is no longer in active rotation on servers', |
||
| 16 | ]) |
||
| 17 | ->addColumn('is_deleted', 'boolean', [ |
||
| 18 | 'after' => 'is_inactive', |
||
| 19 | 'null' => false, |
||
| 20 | 'default' => false, |
||
| 21 | 'comment' => 'Whether or not this map has been soft deleted' |
||
| 22 | ]) |
||
| 23 | ->update() |
||
| 24 | ; |
||
| 25 | |||
| 26 | $this->query("UPDATE maps SET is_inactive = 1 WHERE status = 'hidden' OR status = 'disabled';"); |
||
| 27 | $this->query("UPDATE maps SET is_deleted = 1 WHERE status = 'deleted';"); |
||
| 28 | |||
| 29 | $mapsTable |
||
| 30 | ->removeColumn('status') |
||
| 31 | ->update() |
||
| 32 | ; |
||
| 33 | } |
||
| 34 | |||
| 57 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.