ConversationInviteFormCreator - Code Metrics - allejo/bzion - Measure and Improve Code Quality continuously with Scrutinizer

ConversationInviteFormCreator A
last analyzed 2018-04-10 03:56 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	24
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	2
c	0
b	0
f	0
lcom	1
cbo	4
dl	24
loc	24
ccs	7
cts	7
cp	1
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	build()	10	10	1
A	getName()	4	4	1

How to fix Duplicated Code

<?php
/**
 * This file contains a form creator for player invitations to Conversations
 *
 * @license    https://github.com/allejo/bzion/blob/master/LICENSE.md GNU General Public License Version 3
 */

namespace BZIon\Form\Creator;

use BZIon\Form\Type\AdvancedModelType;
use Symfony\Component\Validator\Constraints\NotBlank;

/**
 * Form creator for conversation invitations
 */
class ConversationInviteFormCreator extends ModelFormCreator

{
    /**
     * {@inheritdoc}
     */
    protected function build($builder)
    {
        return $builder
            ->add('players', new AdvancedModelType(array('player', 'team')), array(
                'constraints' => new NotBlank(),
                'multiple'    => true,
            ))
            ->add('Invite', 'submit')
            ->setAction($this->editing->getUrl());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * {@inheritdoc}
     */
    protected function getName()
    {
        return 'invite_form';
    }
}


1			<?php
2			/**
3			* This file contains a form creator for player invitations to Conversations
4			*
5			* @license https://github.com/allejo/bzion/blob/master/LICENSE.md GNU General Public License Version 3
6			*/
7
8			namespace BZIon\Form\Creator;
9
10			use BZIon\Form\Type\AdvancedModelType;
11			use Symfony\Component\Validator\Constraints\NotBlank;
12
13			/**
14			* Form creator for conversation invitations
15			*/
16		View Code Duplication	class ConversationInviteFormCreator extends ModelFormCreator
			0 ignored issues – show Duplication introduced 2015-12-02 06:58 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17			{
18			/**
19			* {@inheritdoc}
20			*/
21	1		protected function build($builder)
22			{
23			return $builder
24	1		->add('players', new AdvancedModelType(array('player', 'team')), array(
25	1		'constraints' => new NotBlank(),
26			'multiple' => true,
27			))
28	1		->add('Invite', 'submit')
29	1		->setAction($this->editing->getUrl());
			0 ignored issues – show Bug introduced 2016-03-14 01:13 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Model` as the method `getUrl()` does only exist in the following sub-classes of `Model`: `AliasModel`, `AvatarModel`, `Ban`, `Conversation`, `Invitation`, `Map`, `Match`, `News`, `NewsCategory`, `Page`, `Player`, `Role`, `Server`, `Team`, `UrlModel`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
30			}
31
32			/**
33			* {@inheritdoc}
34			*/
35	1		protected function getName()
36			{
37	1		return 'invite_form';
38			}
39			}
40

allejo / bzion

ConversationInviteFormCreator A last analyzed 2018-04-10 03:56 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like

ConversationInviteFormCreator A
last analyzed 2018-04-10 03:56 UTC