Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class PulseColumnStatusValue extends PulseColumnValue |
||
| 12 | { |
||
| 13 | /** |
||
| 14 | * The index of the orange status |
||
| 15 | */ |
||
| 16 | const Orange = 0; |
||
|
|
|||
| 17 | |||
| 18 | /** |
||
| 19 | * The index of the light green status |
||
| 20 | */ |
||
| 21 | const L_Green = 1; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * The index of the red status |
||
| 25 | */ |
||
| 26 | const Red = 2; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * The index of the blue status |
||
| 30 | */ |
||
| 31 | const Blue = 3; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * The index of the purple status |
||
| 35 | */ |
||
| 36 | const Purple = 4; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * The index of the grey status |
||
| 40 | */ |
||
| 41 | const Grey = 5; |
||
| 42 | const Gray = self::Grey; // just an alias |
||
| 43 | |||
| 44 | /** |
||
| 45 | * The index of the green status |
||
| 46 | */ |
||
| 47 | const Green = 6; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * The index of the light blue status |
||
| 51 | */ |
||
| 52 | const L_Blue = 7; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * The index of the gold status |
||
| 56 | */ |
||
| 57 | const Gold = 8; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * The index of the yellow status |
||
| 61 | */ |
||
| 62 | const Yellow = 9; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * The index of the black status |
||
| 66 | */ |
||
| 67 | const Black = 10; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * Get the numerical representation of the color that a status column is set to. |
||
| 71 | * |
||
| 72 | * @api |
||
| 73 | * |
||
| 74 | * @since 0.1.0 |
||
| 75 | * |
||
| 76 | * @return int The color value of a column |
||
| 77 | */ |
||
| 78 | View Code Duplication | public function getValue () |
|
| 92 | |||
| 93 | /** |
||
| 94 | * Update the status of a status column |
||
| 95 | * |
||
| 96 | * It is highly recommended that you use the constants available in the **PulseColumnColorValue** class to match the |
||
| 97 | * colors; keep in mind this value cannot be higher than 11. |
||
| 98 | * |
||
| 99 | * @api |
||
| 100 | * |
||
| 101 | * @param int $color The numerical value of the new color value |
||
| 102 | * |
||
| 103 | * @see PulseColumnStatusValue::Orange PulseColumnStatusValue::Orange |
||
| 104 | * @see PulseColumnStatusValue::L_Green PulseColumnStatusValue::L_Green |
||
| 105 | * @see PulseColumnStatusValue::Red PulseColumnStatusValue::Red |
||
| 106 | * @see PulseColumnStatusValue::Blue PulseColumnStatusValue::Blue |
||
| 107 | * @see PulseColumnStatusValue::Purple PulseColumnStatusValue::Purple |
||
| 108 | * @see PulseColumnStatusValue::Grey PulseColumnStatusValue::Grey |
||
| 109 | * @see PulseColumnStatusValue::Green PulseColumnStatusValue::Green |
||
| 110 | * @see PulseColumnStatusValue::L_Blue PulseColumnStatusValue::L_Blue |
||
| 111 | * @see PulseColumnStatusValue::Gold PulseColumnStatusValue::Gold |
||
| 112 | * @see PulseColumnStatusValue::Yellow PulseColumnStatusValue::Yellow |
||
| 113 | * @see PulseColumnStatusValue::Black PulseColumnStatusValue::Black |
||
| 114 | * |
||
| 115 | * @since 0.1.0 |
||
| 116 | * |
||
| 117 | * @throws \InvalidArgumentException if the $color is not an int or is not between 0-10 |
||
| 118 | */ |
||
| 119 | public function updateValue ($color) |
||
| 135 | |||
| 136 | /** |
||
| 137 | * Get the hex value of the color used on DaPulse to represent the different statuses. |
||
| 138 | * |
||
| 139 | * @api |
||
| 140 | * |
||
| 141 | * @param int $numericalValue The numerical value of the column |
||
| 142 | * |
||
| 143 | * @since 0.1.0 |
||
| 144 | * |
||
| 145 | * @return string A hex value **without** the leading # |
||
| 146 | */ |
||
| 147 | public static function getHexColor ($numericalValue) |
||
| 165 | |||
| 166 | protected function setValue ($response) |
||
| 174 | } |