Complex classes like ApiObject often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ApiObject, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
20 | abstract class ApiObject implements \JsonSerializable |
||
21 | { |
||
22 | /** |
||
23 | * The namespace used for all main PhpPulse objects. This is value is prepended before PhpPulse objects when being |
||
24 | * checked with `instanceof`. |
||
25 | * |
||
26 | * @internal |
||
27 | */ |
||
28 | const OBJ_NAMESPACE = "\\allejo\\DaPulse\\"; |
||
29 | |||
30 | /** |
||
31 | * The default API protocol used for URL calls |
||
32 | * |
||
33 | * @internal |
||
34 | */ |
||
35 | const API_PROTOCOL = "https"; |
||
36 | |||
37 | /** |
||
38 | * The API end point for URL calls |
||
39 | * |
||
40 | * @internal |
||
41 | */ |
||
42 | const API_ENDPOINT = "api.monday.com"; |
||
43 | |||
44 | /** |
||
45 | * The API version used for URL calls |
||
46 | * |
||
47 | * @internal |
||
48 | */ |
||
49 | const API_VERSION = "v1"; |
||
50 | |||
51 | /** |
||
52 | * The suffix that is appended to the URL to access functionality for certain objects |
||
53 | * |
||
54 | * @internal |
||
55 | */ |
||
56 | const API_PREFIX = ""; |
||
57 | |||
58 | /** |
||
59 | * The API key used to make the URL calls |
||
60 | * |
||
61 | * @var string |
||
62 | */ |
||
63 | protected static $apiKey; |
||
64 | |||
65 | /** |
||
66 | * When set to true, the object can only be constructed from an associative array of data. It will not attempt |
||
67 | * to fetch the data with an API call; this is intended for objects are not directly accessible via the API. |
||
68 | * |
||
69 | * @var bool |
||
70 | */ |
||
71 | protected $arrayConstructionOnly = false; |
||
72 | |||
73 | /** |
||
74 | * Set to true if the object has been deleted via an API call but the instance still exists. This variable will |
||
75 | * prevent further API calls to a nonexistent object. |
||
76 | * |
||
77 | * @var bool |
||
78 | */ |
||
79 | protected $deletedObject = false; |
||
80 | |||
81 | /** |
||
82 | * An associative array representing the original JSON response from DaPulse |
||
83 | * |
||
84 | * @var array |
||
85 | */ |
||
86 | protected $jsonResponse; |
||
87 | |||
88 | protected $urlEndPoint; |
||
89 | |||
90 | /** |
||
91 | * The ID for the object we're handling |
||
92 | * |
||
93 | * @var int |
||
94 | */ |
||
95 | protected $id; |
||
96 | |||
97 | /** |
||
98 | * Create an object from an API call |
||
99 | * |
||
100 | * @param int|array $idOrArray Either the numerical ID of an object or an associative array representing a JSON |
||
101 | * response from an API call |
||
102 | * @param bool $lazyLoad When set to true, an initial API call will not be made. An API call will be made when |
||
103 | * the information is requested |
||
104 | * |
||
105 | * @throws \InvalidArgumentException The specified object cannot be created directly from an API call but instead |
||
106 | * requires an associative array of information gathered from other API calls. |
||
107 | * |
||
108 | * @since 0.1.0 |
||
109 | */ |
||
110 | 33 | public function __construct ($idOrArray, $lazyLoad = false) |
|
150 | |||
151 | /** |
||
152 | * Access the JSON response from DaPulse used to create this wrapper object |
||
153 | * |
||
154 | * If a wrapper getter function isn't available for a certain value, use this function to access the value directly. |
||
155 | * |
||
156 | * @api |
||
157 | * @since 0.2.0 |
||
158 | * @return mixed |
||
159 | */ |
||
160 | public function jsonSerialize () |
||
161 | { |
||
162 | return $this->jsonResponse; |
||
163 | } |
||
164 | |||
165 | 33 | protected function lazyLoad () |
|
166 | { |
||
167 | 33 | if (empty($this->jsonResponse)) |
|
168 | { |
||
169 | 33 | $this->jsonResponse = $this->sendGet($this->urlEndPoint); |
|
|
|||
170 | 33 | $this->assignResults(); |
|
171 | } |
||
172 | 33 | } |
|
173 | |||
174 | // ================================================================================================================ |
||
175 | // Helper functions |
||
176 | // ================================================================================================================ |
||
177 | |||
178 | /** |
||
179 | * Assign an associative array from a JSON response and map them to instance variables |
||
180 | * |
||
181 | * @since 0.1.0 |
||
182 | */ |
||
183 | 33 | final protected function assignResults () |
|
184 | { |
||
185 | 33 | foreach ($this->jsonResponse as $key => $val) |
|
186 | { |
||
187 | 33 | if (property_exists(get_called_class(), $key)) |
|
188 | { |
||
189 | 33 | $this->$key = $val; |
|
190 | } |
||
191 | } |
||
192 | 33 | } |
|
193 | |||
194 | /** |
||
195 | * Check if the current object has been marked as deleted from DaPulse. If so, throw an exception. |
||
196 | * |
||
197 | * @throws InvalidObjectException |
||
198 | */ |
||
199 | 1 | final protected function checkInvalid () |
|
200 | { |
||
201 | 1 | if ($this->deletedObject) |
|
202 | { |
||
203 | throw new InvalidObjectException("This object no longer exists on DaPulse", 2); |
||
204 | } |
||
205 | 1 | } |
|
206 | |||
207 | /** |
||
208 | * Mark an object as deleted |
||
209 | * |
||
210 | * @internal |
||
211 | */ |
||
212 | final public function _markInvalid () |
||
213 | { |
||
214 | $this->deletedObject = true; |
||
215 | } |
||
216 | |||
217 | /** |
||
218 | * Store the value in an array if the value is not null. This function is a shortcut of setting values in an array |
||
219 | * only if they are not null, if not leave them unset; used ideally for PUT requests. |
||
220 | * |
||
221 | * @param array $array The array that will store all of the POST parameters |
||
222 | * @param string $name The name of the field |
||
223 | * @param mixed $value The value to be stored in a given field |
||
224 | */ |
||
225 | 1 | final protected static function setIfNotNullOrEmpty (&$array, $name, $value) |
|
226 | { |
||
227 | 1 | if (!is_null($value) && !empty($value)) |
|
228 | { |
||
229 | $array[$name] = $value; |
||
230 | } |
||
231 | 1 | } |
|
232 | |||
233 | // ================================================================================================================ |
||
234 | // Empty functions |
||
235 | // ================================================================================================================ |
||
236 | |||
237 | /** |
||
238 | * Overload this function if any class variables need to be initialized to a default value |
||
239 | */ |
||
240 | 23 | protected function initializeValues () |
|
243 | |||
244 | // ================================================================================================================ |
||
245 | // Lazy loading functions |
||
246 | // ================================================================================================================ |
||
247 | |||
248 | /** |
||
249 | * Inject data into the array that will be mapped into individual instance variables. This function must be called |
||
250 | * **before** lazyCastAll() is called and maps the associative array to objects. |
||
251 | * |
||
252 | * @param array $target An array of associative arrays with data to be converted into objects |
||
253 | * @param array $array An associative array containing data to be merged with the key being the name of the |
||
254 | * instance variable. |
||
255 | * |
||
256 | * @throws \InvalidArgumentException If either parameters are not arrays |
||
257 | * |
||
258 | * @since 0.1.0 |
||
259 | */ |
||
260 | 1 | final protected static function lazyInject (&$target, $array) |
|
261 | { |
||
262 | 1 | if (!is_array($target) || !is_array($array)) |
|
263 | { |
||
264 | throw new \InvalidArgumentException("Both the target and array must be arrays"); |
||
265 | } |
||
266 | |||
267 | // If the first element is an array, let's assume $target hasn't been lazily casted into objects |
||
268 | 1 | if (is_array($target[0])) |
|
269 | { |
||
270 | 1 | foreach ($target as &$element) |
|
271 | { |
||
272 | 1 | $element = array_merge($element, $array); |
|
273 | } |
||
274 | } |
||
275 | 1 | } |
|
276 | |||
277 | /** |
||
278 | * Convert the specified array into an array of object types if needed |
||
279 | * |
||
280 | * @param string $objectType The class name of the Objects the items should be |
||
281 | * @param array $array The array to check |
||
282 | * |
||
283 | * @since 0.2.0 |
||
284 | */ |
||
285 | 4 | final protected static function lazyCastAll (&$array, $objectType) |
|
292 | |||
293 | /** |
||
294 | * Convert the specified item into the specified object if needed |
||
295 | * |
||
296 | * @param mixed $target The item to check |
||
297 | * @param string $objectType The class name of the Objects the items should be |
||
298 | * |
||
299 | * @since 0.2.0 |
||
300 | */ |
||
301 | 6 | final protected static function lazyCast (&$target, $objectType) |
|
309 | |||
310 | /** |
||
311 | * Check whether it is required for an array of JSON data to be converted into an array of the specified objects |
||
312 | * |
||
313 | * @param string $objectType The class name of the Objects the items should be |
||
314 | * @param array $array The array to check |
||
315 | * |
||
316 | * @since 0.2.0 |
||
317 | * |
||
318 | * @return bool True if the array needs to converted into an array of objects |
||
319 | */ |
||
320 | 4 | final protected static function lazyCastNeededOnArray ($objectType, $array) |
|
331 | |||
332 | /** |
||
333 | * Check if an individual item needs to be lazily converted into an object |
||
334 | * |
||
335 | * @param mixed $target The item to check |
||
336 | * @param string $objectType The class name of the Objects the items should be |
||
337 | * |
||
338 | * @since 0.2.0 |
||
339 | * |
||
340 | * @return bool |
||
341 | */ |
||
342 | 9 | final protected static function lazyCastNeeded ($target, $objectType) |
|
348 | |||
349 | /** |
||
350 | * Sends a GET request for a JSON array and casts the response into an array of objects |
||
351 | * |
||
352 | * @param string $url The API endpoint to call to get the JSON response from |
||
353 | * @param string $className The class name of the Object type to cast to |
||
354 | * @param array $params An associative array of URL parameters that will be passed to the specific call. For |
||
355 | * example, limiting the number of results or the pagination of results. **Warning** The |
||
356 | * API key does NOT need to be passed here |
||
357 | * |
||
358 | * @since 0.2.0 |
||
359 | * |
||
360 | * @return array |
||
361 | */ |
||
362 | 22 | final protected static function fetchAndCastToObjectArray ($url, $className, $params = []) |
|
368 | |||
369 | /** |
||
370 | * Convert an array of associative arrays into a specific object |
||
371 | * |
||
372 | * @param string $className The class name of the Object type |
||
373 | * @param array $objects An associative array to be converted into an object |
||
374 | * |
||
375 | * @since 0.2.0 |
||
376 | * |
||
377 | * @return array An array of the specified objects |
||
378 | */ |
||
379 | 23 | final protected static function castArrayToObjectArray ($className, $objects) |
|
391 | |||
392 | // ================================================================================================================ |
||
393 | // URL jobs functions |
||
394 | // ================================================================================================================ |
||
395 | |||
396 | /** |
||
397 | * Send a GET request to fetch the data from the specified URL |
||
398 | * |
||
399 | * @param string $url The API endpoint to call |
||
400 | * @param array $params An associative array of URL parameters that will be passed to the specific call. For |
||
401 | * example, limiting the number of results or the pagination of results. **Warning** The API |
||
402 | * key does NOT need to be passed here |
||
403 | * |
||
404 | * @since 0.1.0 |
||
405 | * |
||
406 | * @return mixed An associative array of the JSON response from DaPulse |
||
407 | */ |
||
408 | 33 | final protected static function sendGet ($url, $params = []) |
|
416 | |||
417 | /** |
||
418 | * Send a POST request to a specified URL |
||
419 | * |
||
420 | * @param string $url |
||
421 | * @param array $postParams |
||
422 | * @param array $getParams |
||
423 | * |
||
424 | * @since 0.1.0 |
||
425 | * |
||
426 | * @return mixed |
||
427 | */ |
||
428 | 4 | final protected static function sendPost ($url, $postParams, $getParams = []) |
|
429 | { |
||
430 | 4 | return self::sendRequest("POST", $url, $postParams, $getParams); |
|
431 | } |
||
432 | |||
433 | /** |
||
434 | * Send a PUT request to a specified URL |
||
435 | * |
||
436 | * @param string $url |
||
437 | * @param array $postParams |
||
438 | * @param array $getParams |
||
439 | * |
||
440 | * @since 0.1.0 |
||
441 | * |
||
442 | * @return mixed |
||
443 | */ |
||
444 | 1 | final protected static function sendPut ($url, $postParams, $getParams = []) |
|
448 | |||
449 | /** |
||
450 | * Send a DELETE request to a specified URL |
||
451 | * |
||
452 | * @param string $url |
||
453 | * @param array $getParams |
||
454 | * |
||
455 | * @since 0.1.0 |
||
456 | * |
||
457 | * @return mixed |
||
458 | */ |
||
459 | 2 | final protected static function sendDelete ($url, $getParams = []) |
|
463 | |||
464 | /** |
||
465 | * Send the appropriate URL request |
||
466 | * |
||
467 | * @param string $type |
||
468 | * @param string $url |
||
469 | * @param array $postParams |
||
470 | * @param array $getParams |
||
471 | * |
||
472 | * @throws \InvalidArgumentException if $type not 'POST', 'PUT', or 'DELETE' |
||
473 | * |
||
474 | * @since 0.1.0 |
||
475 | * |
||
476 | * @return mixed |
||
477 | */ |
||
478 | 7 | private static function sendRequest ($type, $url, $postParams, $getParams) |
|
479 | { |
||
480 | 7 | $getParams["api_key"] = self::$apiKey; |
|
481 | |||
482 | 7 | $urlQuery = new UrlQuery($url, $getParams); |
|
483 | |||
484 | switch ($type) |
||
485 | { |
||
486 | 7 | case "POST": |
|
487 | 4 | return $urlQuery->sendPost($postParams); |
|
488 | |||
489 | 3 | case "PUT": |
|
490 | 1 | return $urlQuery->sendPut($postParams); |
|
491 | |||
492 | 2 | case "DELETE": |
|
493 | 2 | return $urlQuery->sendDelete(); |
|
494 | |||
495 | default: |
||
496 | throw new \InvalidArgumentException(); |
||
497 | } |
||
498 | } |
||
499 | |||
500 | // ================================================================================================================ |
||
501 | // API key functions |
||
502 | // ================================================================================================================ |
||
503 | |||
504 | /** |
||
505 | * Get the base URL to use in all of the API calls |
||
506 | * |
||
507 | * @param string|null $apiPrefix If the API end point is different from the class's constant, this value will be |
||
508 | * used as the suffix for the API endpoint |
||
509 | * |
||
510 | * @since 0.1.0 |
||
511 | * |
||
512 | * @return string The base URL to call |
||
513 | */ |
||
514 | 33 | final protected static function apiEndpoint ($apiPrefix = null) |
|
520 | |||
521 | /** |
||
522 | * Set the API for all calls to the API |
||
523 | * |
||
524 | * @param string $apiKey The API key used to access the DaPulse API |
||
525 | * |
||
526 | * @since 0.1.0 |
||
527 | */ |
||
528 | final public static function setApiKey ($apiKey) |
||
532 | } |
||
533 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..