Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php | ||
| 23 | class PulseBoard extends ApiObject | ||
| 24 | { | ||
| 25 | /** | ||
| 26 | * The suffix that is appended to the URL to access functionality for certain objects | ||
| 27 | * | ||
| 28 | * @internal | ||
| 29 | */ | ||
| 30 | const API_PREFIX = "boards"; | ||
| 31 | |||
| 32 | // ================================================================================================================= | ||
| 33 | // Instance Variables | ||
| 34 | // ================================================================================================================= | ||
| 35 | |||
| 36 | /** | ||
| 37 | * The resource's URL. | ||
| 38 | * | ||
| 39 | * @var string | ||
| 40 | */ | ||
| 41 | protected $url; | ||
| 42 | |||
| 43 | /** | ||
| 44 | * The board's unique identifier. | ||
| 45 | * | ||
| 46 | * @var int | ||
| 47 | */ | ||
| 48 | protected $id; | ||
| 49 | |||
| 50 | /** | ||
| 51 | * The board's name. | ||
| 52 | * | ||
| 53 | * @var string | ||
| 54 | */ | ||
| 55 | protected $name; | ||
| 56 | |||
| 57 | /** | ||
| 58 | * The board's description. | ||
| 59 | * | ||
| 60 | * @var string | ||
| 61 | */ | ||
| 62 | protected $description; | ||
| 63 | |||
| 64 | /** | ||
| 65 | * The board's visible columns. | ||
| 66 | * | ||
| 67 | * @var array | ||
| 68 | */ | ||
| 69 | protected $columns; | ||
| 70 | |||
| 71 | /** | ||
| 72 | * Creation time. | ||
| 73 | * | ||
| 74 | * @var \DateTime | ||
| 75 | */ | ||
| 76 | protected $created_at; | ||
| 77 | |||
| 78 | /** | ||
| 79 | * Last update time. | ||
| 80 | * | ||
| 81 | * @var \DateTime | ||
| 82 | */ | ||
| 83 | protected $updated_at; | ||
| 84 | |||
| 85 | // ================================================================================================================= | ||
| 86 | // Getter functions | ||
| 87 | // ================================================================================================================= | ||
| 88 | |||
| 89 | /** | ||
| 90 | * The resource's URL. | ||
| 91 | * | ||
| 92 | * @api | ||
| 93 | * | ||
| 94 | * @since 0.1.0 | ||
| 95 | * | ||
| 96 | * @return string | ||
| 97 | */ | ||
| 98 | public function getUrl() | ||
| 102 | |||
| 103 | /** | ||
| 104 | * The board's unique identifier. | ||
| 105 | * | ||
| 106 | * @api | ||
| 107 | * | ||
| 108 | * @since 0.1.0 | ||
| 109 | * | ||
| 110 | * @return int | ||
| 111 | */ | ||
| 112 | public function getId() | ||
| 116 | |||
| 117 | /** | ||
| 118 | * The board's name. | ||
| 119 | * | ||
| 120 | * @api | ||
| 121 | * | ||
| 122 | * @since 0.1.0 | ||
| 123 | * | ||
| 124 | * @return string | ||
| 125 | */ | ||
| 126 | public function getName() | ||
| 130 | |||
| 131 | /** | ||
| 132 | * The board's description. | ||
| 133 | * | ||
| 134 | * @api | ||
| 135 | * | ||
| 136 | * @since 0.1.0 | ||
| 137 | * | ||
| 138 | * @return string | ||
| 139 | */ | ||
| 140 | public function getDescription() | ||
| 144 | |||
| 145 | /** | ||
| 146 | * The board's visible columns. | ||
| 147 | * | ||
| 148 | * @api | ||
| 149 | * | ||
| 150 | * @since 0.1.0 | ||
| 151 | * | ||
| 152 | * @return PulseColumn[] | ||
| 153 | */ | ||
| 154 | public function getColumns() | ||
| 163 | |||
| 164 | /** | ||
| 165 | * Creation time. | ||
| 166 | * | ||
| 167 | * @api | ||
| 168 | * | ||
| 169 | * @since 0.1.0 | ||
| 170 | * | ||
| 171 | * @return \DateTime | ||
| 172 | */ | ||
| 173 | public function getCreatedAt() | ||
| 179 | |||
| 180 | /** | ||
| 181 | * Last update time. | ||
| 182 | * | ||
| 183 | * @api | ||
| 184 | * | ||
| 185 | * @since 0.1.0 | ||
| 186 | * | ||
| 187 | * @return \DateTime | ||
| 188 | */ | ||
| 189 | public function getUpdatedAt() | ||
| 195 | |||
| 196 | // ================================================================================================================= | ||
| 197 | // Subscriber functions | ||
| 198 | // ================================================================================================================= | ||
| 199 | |||
| 200 | /** | ||
| 201 | * Get the users who are subscribed to this board | ||
| 202 | * | ||
| 203 | * @api | ||
| 204 | * | ||
| 205 | * @param array $params | ||
| 206 | * | ||
| 207 | * @since 0.1.0 | ||
| 208 | * | ||
| 209 | * @return PulseUser[] | ||
| 210 | */ | ||
| 211 | public function getSubscribers ($params = array()) | ||
| 217 | |||
| 218 | /** | ||
| 219 | * Subscriber a user to a board | ||
| 220 | * | ||
| 221 | * @api | ||
| 222 | * | ||
| 223 | * @param int|PulseUser $user_id The user that will be subscribed to the board | ||
| 224 | * @param bool|null $as_admin Set to true if the user will be an admin of the board | ||
| 225 | * | ||
| 226 | * @since 0.1.0 | ||
| 227 | */ | ||
| 228 | public function addSubscriber ($user_id, $as_admin = NULL) | ||
| 243 | |||
| 244 | /** | ||
| 245 | * Unsubscribe a user from this board | ||
| 246 | * | ||
| 247 | * @api | ||
| 248 | * | ||
| 249 | * @param int|PulseUser $user_id The user that will be unsubscribed from the board | ||
| 250 | * | ||
| 251 | * @since 0.1.0 | ||
| 252 | */ | ||
| 253 | View Code Duplication | public function removeSubscriber ($user_id) | |
| 264 | |||
| 265 | // ================================================================================================================= | ||
| 266 | // Columns functions | ||
| 267 | // ================================================================================================================= | ||
| 268 | |||
| 269 | /** | ||
| 270 | * Create a new column for the current board. | ||
| 271 | * | ||
| 272 | * If you are creating a status column, use the constants available in the **PulseColumnColorValue** class to match | ||
| 273 | * the colors. Keep in mind this array cannot have a key higher than 11 nor can it be an associative array. Here's | ||
| 274 | * an example of how to match statuses with specific colors. | ||
| 275 | * | ||
| 276 | * ```php | ||
| 277 | * $labels = array( | ||
| 278 | * PulseColumnColorValue::Orange => "Working on it", | ||
| 279 | * PulseColumnColorValue::L_Green => "Done", | ||
| 280 | * PulseColumnColorValue::Red => "Delayed" | ||
| 281 | * ); | ||
| 282 | * ``` | ||
| 283 | * | ||
| 284 | * @api | ||
| 285 | * | ||
| 286 | * @param string $title The title of the column. This title will automatically be "slugified" and become the ID | ||
| 287 | * of the column. | ||
| 288 | * @param string $type The type of value that this column will use. Either use the available constants in the | ||
| 289 | * PulseColumn class or use the following strings: "date", "person", "status", "text". | ||
| 290 | * @param array $labels If the column type will be "status," then this array will be the values for each of the | ||
| 291 | * colors. | ||
| 292 | * | ||
| 293 | * @see PulseColumn::Date PulseColumn::Date | ||
| 294 | * @see PulseColumn::Person PulseColumn::Person | ||
| 295 | * @see PulseColumn::Status PulseColumn::Status | ||
| 296 | * @see PulseColumn::Text PulseColumn::Text | ||
| 297 | * @see PulseColumnColorValue::Orange PulseColumnColorValue::Orange | ||
| 298 | * @see PulseColumnColorValue::L_Green PulseColumnColorValue::L_Green | ||
| 299 | * @see PulseColumnColorValue::Red PulseColumnColorValue::Red | ||
| 300 | * @see PulseColumnColorValue::Blue PulseColumnColorValue::Blue | ||
| 301 | * @see PulseColumnColorValue::Purple PulseColumnColorValue::Purple | ||
| 302 | * @see PulseColumnColorValue::Grey PulseColumnColorValue::Grey | ||
| 303 | * @see PulseColumnColorValue::Green PulseColumnColorValue::Green | ||
| 304 | * @see PulseColumnColorValue::L_Blue PulseColumnColorValue::L_Blue | ||
| 305 | * @see PulseColumnColorValue::Gold PulseColumnColorValue::Gold | ||
| 306 | * @see PulseColumnColorValue::Yellow PulseColumnColorValue::Yellow | ||
| 307 | * @see PulseColumnColorValue::Black PulseColumnColorValue::Black | ||
| 308 | * | ||
| 309 | * @since 0.1.0 | ||
| 310 | * | ||
| 311 | * @throws ArgumentMismatchException Status definitions were defined yet the type of the column was not a status | ||
| 312 | * type column | ||
| 313 | * @throws InvalidArraySizeException The array containing the value of statuses has a key larger than the | ||
| 314 | * supported 10 indices | ||
| 315 | * | ||
| 316 | * @return $this This instance will be updated to have updated information to reflect the new column that was | ||
| 317 | * created | ||
| 318 | */ | ||
| 319 | public function createColumn ($title, $type, $labels = array()) | ||
| 344 | |||
| 345 | // ================================================================================================================= | ||
| 346 | // Group functions | ||
| 347 | // ================================================================================================================= | ||
| 348 | |||
| 349 | /** | ||
| 350 | * Get all of the groups belonging to a board. | ||
| 351 | * | ||
| 352 | * A group is defined as the colorful headers that split up pulses into categories. | ||
| 353 | * | ||
| 354 | * @api | ||
| 355 | * | ||
| 356 | * @param bool $show_archived Set to true if you would like to get archived groups in a board as well | ||
| 357 | * | ||
| 358 | * @since 0.1.0 | ||
| 359 | * | ||
| 360 | * @return PulseGroup[] | ||
| 361 | */ | ||
| 362 | public function getGroups ($show_archived = NULL) | ||
| 371 | |||
| 372 | /** | ||
| 373 | * Create a new group in a board | ||
| 374 | * | ||
| 375 | * @api | ||
| 376 | * | ||
| 377 | * @param string $title The title of the board | ||
| 378 | * | ||
| 379 | * @since 0.1.0 | ||
| 380 | * | ||
| 381 | * @return PulseGroup | ||
| 382 | */ | ||
| 383 | public function createGroup ($title) | ||
| 394 | |||
| 395 | /** | ||
| 396 | * Delete a group from a board | ||
| 397 | * | ||
| 398 | * @api | ||
| 399 | * | ||
| 400 | * @param string $group_id The group ID to be deleted | ||
| 401 | * | ||
| 402 | * @since 0.1.0 | ||
| 403 | */ | ||
| 404 | public function deleteGroup ($group_id) | ||
| 410 | |||
| 411 | // ================================================================================================================= | ||
| 412 | // Pulse functions | ||
| 413 | // ================================================================================================================= | ||
| 414 | |||
| 415 | /** | ||
| 416 | * @return Pulse[] | ||
| 417 | */ | ||
| 418 | public function getPulses () | ||
| 433 | |||
| 434 | public function createPulse ($name, $owner, $group_id = null) | ||
| 451 | |||
| 452 | View Code Duplication | private function pulseInjection (&$result) | |
| 459 | |||
| 460 | // ================================================================================================================= | ||
| 461 | // Board functions | ||
| 462 | // ================================================================================================================= | ||
| 463 | |||
| 464 | View Code Duplication | public function archiveBoard () | |
| 473 | |||
| 474 | public static function createBoard ($name, $user_id, $description = NULL) | ||
| 488 | |||
| 489 | public static function getBoards ($params = array()) | ||
| 495 | } | 
This check marks property names that have not been written in camelCase.
In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes
databaseConnectionString.