allejo\DaPulse\Objects\PulseColumnStatusValue

Complexity

Total Complexity

5

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getValue()	0	9	2
A	updateValue()	0	17	3

<?php

namespace allejo\DaPulse\Objects;

/**
 * Class PulseColumnColorValue
 *
 * @package allejo\DaPulse\Objects
 */
class PulseColumnStatusValue extends PulseColumnValue
{
    /**
     * The index of the orange status
     */
    const Orange = 0;

This class constant is not uppercase (expected ORANGE).

    /**
     * The index of the light green status
     */
    const L_Green = 1;

This class constant is not uppercase (expected L_GREEN).

    /**
     * The index of the red status
     */
    const Red = 2;

This class constant is not uppercase (expected RED).

    /**
     * The index of the blue status
     */
    const Blue = 3;

This class constant is not uppercase (expected BLUE).

    /**
     * The index of the purple status
     */
    const Purple = 4;

This class constant is not uppercase (expected PURPLE).

    /**
     * The index of the grey status
     */
    const Grey = 5;

This class constant is not uppercase (expected GREY).

    /**
     * The index of the green status
     */
    const Green = 6;

This class constant is not uppercase (expected GREEN).

    /**
     * The index of the light blue status
     */
    const L_Blue = 7;

This class constant is not uppercase (expected L_BLUE).

    /**
     * The index of the gold status
     */
    const Gold = 8;

This class constant is not uppercase (expected GOLD).

    /**
     * The index of the yellow status
     */
    const Yellow = 9;

This class constant is not uppercase (expected YELLOW).

    /**
     * The index of the black status
     */
    const Black = 10;

This class constant is not uppercase (expected BLACK).

    public function getValue ()
    {
        if (!isset($this->column_value))
        {
            $this->column_value = $this->jsonResponse["value"]["index"];
        }

        return $this->column_value;
    }

    public function updateValue ($color)
    {
        if ($color < 0 && $color > 10)
        {
            throw new \InvalidArgumentException("DaPulse only has color indexes from 0-10");
        }

        $url        = sprintf("%s/%d/columns/%s/status.json", parent::apiEndpoint(), $this->board_id, $this->column_id);

It seems like you call parent on a different method (apiEndpoint() instead of updateValue()). Are you sure this is correct? If so, you might want to change this to $this->apiEndpoint().

        $postParams = array(
            "pulse_id"    => $this->pulse_id,
            "color_index" => $color
        );

        self::sendPut($url, $postParams);

        $this->column_value = $color;
    }
}