allejo\DaPulse\Objects\PulseColumnTimelineValue

Complexity

Total Complexity

7

Size/Duplication

Total Lines	70
Duplicated Lines	20 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getValue()	14	14	3
A	updateValue()	0	17	3
A	setValue()	0	7	1

<?php

namespace allejo\DaPulse\Objects;

/**
 * Class PulseColumnTextValue
 *
 * @package allejo\DaPulse\Objects
 * @since   0.2.1
 */
class PulseColumnTimelineValue extends PulseColumnValue
{
    /**
     * Get a timeline column's content
     *
     * @api
     *
     * @since  0.2.1
     *
     * @return \DateTime[]|null The timeline's begin and end dates
     *
     *     array(
     *       'from' => \DateTime
     *       'to'   => \DateTime
     *     )
     */
    public function getValue ()

This method seems to be duplicated in your project.

    {
        if ($this->isNullValue())
        {
            return null;
        }

        if (!isset($this->column_value))
        {
            $this->setValue($this->jsonResponse);
        }

        return $this->column_value;
    }

    /**
     * Update the values of a timeline column
     *
     * @api
     *
     * @param \DateTime $from
     * @param \DateTime $to
     *
     * @since 0.3.0 \InvalidArgumentException is now thrown
     * @since 0.2.1
     *
     * @throws \InvalidArgumentException if $from or $to are not \DateTime instances
     */
    public function updateValue ($from, $to)

Avoid variables with short names like $to. Configured minimum length is 3.

    {
        if (!($from instanceof \DateTime) || !($to instanceof \DateTime))
        {
            throw new \InvalidArgumentException('$from and $to are expected to be \\DateTime instances');
        }

        $url        = sprintf("%s/%d/columns/%s/timeline.json", self::apiEndpoint(), $this->board_id, $this->column_id);
        $postParams = [
            "pulse_id" => $this->pulse_id,
            "from"     => $from->format('Y-m-d'),
            "to"       => $to->format('Y-m-d')
        ];

        $result = self::sendPut($url, $postParams);
        $this->setValue($result);
    }

    protected function setValue ($response)
    {
        $this->column_value = [
            'from' => new \DateTime($response["value"]["from"]),
            'to'   => new \DateTime($response["value"]["to"])
        ];
    }
}