allejo /
PhpPulse
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 11 | class PulseColumnNumericValue extends PulseColumnValue |
||
| 12 | { |
||
| 13 | /** |
||
| 14 | * Get a numeric column's content |
||
| 15 | * |
||
| 16 | * @api |
||
| 17 | * |
||
| 18 | * @since 0.3.0 Docs correctly specify a numeric return type |
||
| 19 | * @since 0.2.0 |
||
| 20 | * |
||
| 21 | * @return int|double|null Null is returned if there is no value set for this column |
||
| 22 | */ |
||
| 23 | 3 | View Code Duplication | public function getValue () |
|
|
|||
| 24 | { |
||
| 25 | 3 | if ($this->isNullValue()) |
|
| 26 | { |
||
| 27 | 1 | return null; |
|
| 28 | } |
||
| 29 | |||
| 30 | 2 | if (!isset($this->column_value)) |
|
| 31 | { |
||
| 32 | 1 | $this->setValue($this->jsonResponse); |
|
| 33 | } |
||
| 34 | |||
| 35 | 2 | return $this->column_value; |
|
| 36 | } |
||
| 37 | |||
| 38 | /** |
||
| 39 | * Update the value of a numeric column |
||
| 40 | * |
||
| 41 | * @api |
||
| 42 | * |
||
| 43 | * @param int|double $number |
||
| 44 | * |
||
| 45 | * @since 0.3.0 \InvalidArgumentException is now thrown |
||
| 46 | * @since 0.2.0 |
||
| 47 | * |
||
| 48 | * @throws \InvalidArgumentException if $number is not a numeric value |
||
| 49 | */ |
||
| 50 | 1 | View Code Duplication | public function updateValue ($number) |
| 51 | { |
||
| 52 | 1 | if (!is_numeric($number)) |
|
| 53 | { |
||
| 54 | throw new \InvalidArgumentException('$number is expected to be a numeric type'); |
||
| 55 | } |
||
| 56 | |||
| 57 | 1 | $url = sprintf("%s/%d/columns/%s/numeric.json", self::apiEndpoint(), $this->board_id, $this->column_id); |
|
| 58 | $postParams = array( |
||
| 59 | 1 | "pulse_id" => $this->pulse_id, |
|
| 60 | 1 | "value" => $number |
|
| 61 | ); |
||
| 62 | |||
| 63 | 1 | $result = self::sendPut($url, $postParams); |
|
| 64 | 1 | $this->setValue($result); |
|
| 65 | 1 | } |
|
| 66 | |||
| 67 | 2 | protected function setValue ($response) |
|
| 71 | } |
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.