Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 31 | class Pulse extends SubscribableObject |
||
| 32 | { |
||
| 33 | /** |
||
| 34 | * @ignore |
||
| 35 | */ |
||
| 36 | const API_PREFIX = "pulses"; |
||
| 37 | |||
| 38 | // ================================================================================================================ |
||
| 39 | // Instance Variables |
||
| 40 | // ================================================================================================================ |
||
| 41 | |||
| 42 | /** |
||
| 43 | * The resource's URL. |
||
| 44 | * |
||
| 45 | * @var string |
||
| 46 | */ |
||
| 47 | protected $url; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * The pulse's name. |
||
| 51 | * |
||
| 52 | * @var string |
||
| 53 | */ |
||
| 54 | protected $name; |
||
| 55 | |||
| 56 | /** |
||
| 57 | * The amount of updates a pulse has. |
||
| 58 | * |
||
| 59 | * @var int |
||
| 60 | */ |
||
| 61 | protected $updates_count; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * The ID of the parent board. |
||
| 65 | * |
||
| 66 | * @var int |
||
| 67 | */ |
||
| 68 | protected $board_id; |
||
| 69 | |||
| 70 | /** |
||
| 71 | * Creation time. |
||
| 72 | * |
||
| 73 | * @var \DateTime |
||
| 74 | */ |
||
| 75 | protected $created_at; |
||
| 76 | |||
| 77 | /** |
||
| 78 | * Last update time. |
||
| 79 | * |
||
| 80 | * @var \DateTime |
||
| 81 | */ |
||
| 82 | protected $updated_at; |
||
| 83 | |||
| 84 | /** |
||
| 85 | * The ID of the group this pulse belongs to |
||
| 86 | * |
||
| 87 | * @var string |
||
| 88 | */ |
||
| 89 | protected $group_id; |
||
| 90 | |||
| 91 | /** |
||
| 92 | * @var PulseColumn[] |
||
| 93 | */ |
||
| 94 | protected $column_structure; |
||
| 95 | |||
| 96 | /** |
||
| 97 | * An array containing all of the values a pulse has for each column |
||
| 98 | * |
||
| 99 | * @var mixed |
||
| 100 | */ |
||
| 101 | protected $raw_column_values; |
||
| 102 | |||
| 103 | /** |
||
| 104 | * An array containing objects extended from PulseColumnValue storing all of the values for each column |
||
| 105 | * |
||
| 106 | * @var array |
||
| 107 | */ |
||
| 108 | protected $column_values; |
||
| 109 | |||
| 110 | /** |
||
| 111 | * The common URL path for retrieving objects relating a pulse such as subscribers, notes, or updates |
||
| 112 | * |
||
| 113 | * @var string |
||
| 114 | */ |
||
| 115 | private $urlSyntax = "%s/%s/%s.json"; |
||
| 116 | |||
| 117 | // ================================================================================================================ |
||
| 118 | // Overloaded functions |
||
| 119 | // ================================================================================================================ |
||
| 120 | |||
| 121 | 107 | protected function initializeValues () |
|
| 127 | |||
| 128 | // ================================================================================================================ |
||
| 129 | // Getter functions |
||
| 130 | // ================================================================================================================ |
||
| 131 | |||
| 132 | /** |
||
| 133 | * The resource's URL. |
||
| 134 | * |
||
| 135 | * @api |
||
| 136 | * |
||
| 137 | * @since 0.1.0 |
||
| 138 | * |
||
| 139 | * @return string |
||
| 140 | */ |
||
| 141 | 1 | public function getUrl () |
|
| 147 | |||
| 148 | /** |
||
| 149 | * The pulse's name. |
||
| 150 | * |
||
| 151 | * @api |
||
| 152 | * |
||
| 153 | * @since 0.1.0 |
||
| 154 | * |
||
| 155 | * @return string |
||
| 156 | */ |
||
| 157 | 4 | public function getName () |
|
| 163 | |||
| 164 | /** |
||
| 165 | * The amount of updates a pulse has. |
||
| 166 | * |
||
| 167 | * @api |
||
| 168 | * |
||
| 169 | * @since 0.1.0 |
||
| 170 | * |
||
| 171 | * @return int |
||
| 172 | */ |
||
| 173 | 1 | public function getUpdatesCount () |
|
| 179 | |||
| 180 | /** |
||
| 181 | * The ID of the parent board. |
||
| 182 | * |
||
| 183 | * @api |
||
| 184 | * |
||
| 185 | * @since 0.1.0 |
||
| 186 | * |
||
| 187 | * @return int |
||
| 188 | */ |
||
| 189 | 44 | public function getBoardId () |
|
| 195 | |||
| 196 | /** |
||
| 197 | * Creation time. |
||
| 198 | * |
||
| 199 | * @api |
||
| 200 | * |
||
| 201 | * @since 0.1.0 |
||
| 202 | * |
||
| 203 | * @return \DateTime |
||
| 204 | */ |
||
| 205 | 1 | public function getCreatedAt () |
|
| 212 | |||
| 213 | /** |
||
| 214 | * Last update time. |
||
| 215 | * |
||
| 216 | * @api |
||
| 217 | * |
||
| 218 | * @since 0.1.0 |
||
| 219 | * |
||
| 220 | * @return \DateTime |
||
| 221 | */ |
||
| 222 | 3 | public function getUpdatedAt () |
|
| 229 | |||
| 230 | /** |
||
| 231 | * Get the ID of the group this Pulse is a part of. If this value is not available, an API call will be made to |
||
| 232 | * find the group ID via brute force. |
||
| 233 | * |
||
| 234 | * **Note** The group ID is cached if it is not available. To update the cached value, use $forceFetch to force an |
||
| 235 | * API call to get a new value. |
||
| 236 | * |
||
| 237 | * **Warning** An API call is always slower than using the cached value. |
||
| 238 | * |
||
| 239 | * @api |
||
| 240 | * |
||
| 241 | * @param bool $forceFetch Force an API call to get an updated group ID if it has been changed |
||
| 242 | * |
||
| 243 | * @since 0.1.0 |
||
| 244 | * |
||
| 245 | * @return string |
||
| 246 | */ |
||
| 247 | 3 | public function getGroupId ($forceFetch = false) |
|
| 268 | |||
| 269 | // ================================================================================================================ |
||
| 270 | // Pulse functions |
||
| 271 | // ================================================================================================================ |
||
| 272 | |||
| 273 | /** |
||
| 274 | * Edit the name of the pulse |
||
| 275 | * |
||
| 276 | * @api |
||
| 277 | * |
||
| 278 | * @param string $title |
||
| 279 | * |
||
| 280 | * @since 0.1.0 |
||
| 281 | */ |
||
| 282 | 1 | public function editName ($title) |
|
| 292 | |||
| 293 | /** |
||
| 294 | * Archive the current pulse |
||
| 295 | * |
||
| 296 | * This is the equivalent of a soft delete and can be restored from the DaPulse website. |
||
| 297 | * |
||
| 298 | * @api |
||
| 299 | * |
||
| 300 | * @since 0.1.0 |
||
| 301 | */ |
||
| 302 | 1 | public function archivePulse () |
|
| 312 | |||
| 313 | /** |
||
| 314 | * Delete the current Pulse |
||
| 315 | * |
||
| 316 | * @api |
||
| 317 | * |
||
| 318 | * @since 0.1.0 |
||
| 319 | * |
||
| 320 | * @throws InvalidObjectException |
||
| 321 | */ |
||
| 322 | 1 | View Code Duplication | public function deletePulse () |
| 332 | |||
| 333 | public function duplicatePulse ($groupId = null, $ownerId = null) |
||
| 351 | |||
| 352 | View Code Duplication | private function pulseInjection (&$result) |
|
| 361 | |||
| 362 | // ================================================================================================================ |
||
| 363 | // Column data functions |
||
| 364 | // ================================================================================================================ |
||
| 365 | |||
| 366 | /** |
||
| 367 | * Access a color type column value belonging to this pulse in order to read it or modify. |
||
| 368 | * |
||
| 369 | * This function should only be used to access color type values; an exception will be thrown otherwise. |
||
| 370 | * |
||
| 371 | * @api |
||
| 372 | * |
||
| 373 | * @param string $columnId The ID of the column to access. This is typically a slugified version of the column name |
||
| 374 | * |
||
| 375 | * @since 0.4.0 ColumnNotFoundException will no longer thrown, instead it'll be thrown when getValue() is called |
||
| 376 | * @since 0.1.0 |
||
| 377 | * |
||
| 378 | * @throws InvalidColumnException The specified column is not a "color" type column |
||
| 379 | * @throws InvalidObjectException The specified column exists but modification of its value is unsupported either |
||
| 380 | * by this library or the DaPulse API. |
||
| 381 | * |
||
| 382 | * @return PulseColumnStatusValue A column object with access to its contents |
||
| 383 | */ |
||
| 384 | 6 | public function getStatusColumn ($columnId) |
|
| 388 | |||
| 389 | /** |
||
| 390 | * Access a date type column value belonging to this pulse in order to read it or modify. |
||
| 391 | * |
||
| 392 | * This function should only be used to access date type values; an exception will be thrown otherwise. |
||
| 393 | * |
||
| 394 | * @api |
||
| 395 | * |
||
| 396 | * @param string $columnId The ID of the column to access. This is typically a slugified version of the column name |
||
| 397 | * |
||
| 398 | * @since 0.4.0 ColumnNotFoundException will no longer thrown, instead it'll be thrown when getValue() is called |
||
| 399 | * @since 0.1.0 |
||
| 400 | * |
||
| 401 | * @throws InvalidColumnException The specified column is not a "date" type column |
||
| 402 | * @throws InvalidObjectException The specified column exists but modification of its value is unsupported either |
||
| 403 | * by this library or the DaPulse API. |
||
| 404 | * |
||
| 405 | * @return PulseColumnDateValue A column object with access to its contents |
||
| 406 | */ |
||
| 407 | 9 | public function getDateColumn ($columnId) |
|
| 411 | |||
| 412 | /** |
||
| 413 | * Access a numeric type column value belonging to this pulse in order to read it or modify. |
||
| 414 | * |
||
| 415 | * This function should only be used to access number type values; an exception will be thrown otherwise. |
||
| 416 | * |
||
| 417 | * @api |
||
| 418 | * |
||
| 419 | * @param string $columnId The ID of the column to access. This is typically a slugified version of the column name |
||
| 420 | * |
||
| 421 | * @since 0.4.0 ColumnNotFoundException will no longer thrown, instead it'll be thrown when getValue() is called |
||
| 422 | * @since 0.2.0 |
||
| 423 | * |
||
| 424 | * @throws InvalidColumnException The specified column is not a "numeric" type column |
||
| 425 | * @throws InvalidObjectException The specified column exists but modification of its value is unsupported either |
||
| 426 | * by this library or the DaPulse API. |
||
| 427 | * |
||
| 428 | * @return PulseColumnNumericValue A column object with access to its contents |
||
| 429 | */ |
||
| 430 | 7 | public function getNumericColumn ($columnId) |
|
| 434 | |||
| 435 | /** |
||
| 436 | * Access a person type column value belonging to this pulse in order to read it or modify. |
||
| 437 | * |
||
| 438 | * This function should only be used to access person type values; an exception will be thrown otherwise. |
||
| 439 | * |
||
| 440 | * @api |
||
| 441 | * |
||
| 442 | * @param string $columnId The ID of the column to access. This is typically a slugified version of the column name |
||
| 443 | * |
||
| 444 | * @since 0.4.0 ColumnNotFoundException will no longer thrown, instead it'll be thrown when getValue() is called |
||
| 445 | * @since 0.1.0 |
||
| 446 | * |
||
| 447 | * @throws InvalidColumnException The specified column is not a "person" type column |
||
| 448 | * @throws InvalidObjectException The specified column exists but modification of its value is unsupported either |
||
| 449 | * by this library or the DaPulse API. |
||
| 450 | * |
||
| 451 | * @return PulseColumnPersonValue A column object with access to its contents |
||
| 452 | */ |
||
| 453 | 9 | public function getPersonColumn ($columnId) |
|
| 457 | |||
| 458 | /** |
||
| 459 | * Access a tag type column value belonging to this pulse in order to read it or modify. |
||
| 460 | * |
||
| 461 | * This function should only be used to access text type values; an exception will be thrown otherwise. |
||
| 462 | * |
||
| 463 | * @api |
||
| 464 | * |
||
| 465 | * @param string $columnId The ID of the column to access. This is typically a slugified version of the column name |
||
| 466 | * |
||
| 467 | * @since 0.4.0 ColumnNotFoundException will no longer thrown, instead it'll be thrown when getValue() is called |
||
| 468 | * @since 0.3.4 |
||
| 469 | * |
||
| 470 | * @throws InvalidColumnException The specified column is not a "text" type column |
||
| 471 | * @throws InvalidObjectException The specified column exists but modification of its value is unsupported either |
||
| 472 | * by this library or the DaPulse API. |
||
| 473 | * |
||
| 474 | * @return PulseColumnTagValue A column object with access to its contents |
||
| 475 | */ |
||
| 476 | 3 | public function getTagColumn ($columnId) |
|
| 480 | |||
| 481 | /** |
||
| 482 | * Access a text type column value belonging to this pulse in order to read it or modify. |
||
| 483 | * |
||
| 484 | * This function should only be used to access text type values; an exception will be thrown otherwise. |
||
| 485 | * |
||
| 486 | * @api |
||
| 487 | * |
||
| 488 | * @param string $columnId The ID of the column to access. This is typically a slugified version of the column name |
||
| 489 | * |
||
| 490 | * @since 0.4.0 ColumnNotFoundException will no longer thrown, instead it'll be thrown when getValue() is called |
||
| 491 | * @since 0.1.0 |
||
| 492 | * |
||
| 493 | * @throws InvalidColumnException The specified column is not a "text" type column |
||
| 494 | * @throws InvalidObjectException The specified column exists but modification of its value is unsupported either |
||
| 495 | * by this library or the DaPulse API. |
||
| 496 | * |
||
| 497 | * @return PulseColumnTextValue A column object with access to its contents |
||
| 498 | */ |
||
| 499 | 4 | public function getTextColumn ($columnId) |
|
| 503 | |||
| 504 | /** |
||
| 505 | * Access a timeline type column value belonging to this pulse in order to read it or modify. |
||
| 506 | * |
||
| 507 | * This function should only be used to access timeline type values; an exception will be thrown otherwise. |
||
| 508 | * |
||
| 509 | * @api |
||
| 510 | * |
||
| 511 | * @param string $columnId The ID of the column to access. This is typically a slugified version of the column name |
||
| 512 | * |
||
| 513 | * @since 0.4.0 ColumnNotFoundException will no longer thrown, instead it'll be thrown when getValue() is called |
||
| 514 | * @since 0.2.1 |
||
| 515 | * |
||
| 516 | * @throws InvalidColumnException The specified column is not a "numeric" type column |
||
| 517 | * @throws InvalidObjectException The specified column exists but modification of its value is unsupported either |
||
| 518 | * by this library or the DaPulse API. |
||
| 519 | * |
||
| 520 | * @return PulseColumnTimelineValue A column object with access to its contents |
||
| 521 | */ |
||
| 522 | 5 | public function getTimelineColumn ($columnId) |
|
| 526 | |||
| 527 | /** |
||
| 528 | * Access a column belonging to this pulse in order to read it or modify it. |
||
| 529 | * |
||
| 530 | * @api |
||
| 531 | * |
||
| 532 | * @param string $columnId The ID of the column to access. This is typically a slugified version of the column |
||
| 533 | * title |
||
| 534 | * @param string $columnType The type of column being accessed. **Only** use available constants or PulseColumn::getType() |
||
| 535 | * |
||
| 536 | * @see PulseColumn::Date |
||
| 537 | * @see PulseColumn::Numeric |
||
| 538 | * @see PulseColumn::Person |
||
| 539 | * @see PulseColumn::Status |
||
| 540 | * @see PulseColumn::Text |
||
| 541 | * @see PulseColumn::Timeline |
||
| 542 | * @see PulseColumnDateValue |
||
| 543 | * @see PulseColumnNumericValue |
||
| 544 | * @see PulseColumnPersonValue |
||
| 545 | * @see PulseColumnStatusValue |
||
| 546 | * @see PulseColumnTextValue |
||
| 547 | * @see PulseColumnTimelineValue |
||
| 548 | * |
||
| 549 | * @since 0.3.1 |
||
| 550 | * |
||
| 551 | * @throws InvalidColumnException The specified column is not the same type as specified in `$columnType` |
||
| 552 | * @throws InvalidObjectException The specified column exists but modification of its value is unsupported either |
||
| 553 | * by this library or the DaPulse API. |
||
| 554 | * |
||
| 555 | * @return mixed Returns an instance of an object extending the PulseColumnValue class |
||
| 556 | */ |
||
| 557 | 43 | public function getColumn ($columnId, $columnType) |
|
| 587 | |||
| 588 | // ================================================================================================================ |
||
| 589 | // Notes functions |
||
| 590 | // ================================================================================================================ |
||
| 591 | |||
| 592 | /** |
||
| 593 | * Create a new note in this project |
||
| 594 | * |
||
| 595 | * @api |
||
| 596 | * |
||
| 597 | * @param string $title The title of the note |
||
| 598 | * @param string $content The body of the note |
||
| 599 | * @param bool $ownersOnly Set to true if only pulse owners can edit this note. |
||
| 600 | * @param int|null $user The id of the user to be marked as the note's last updater |
||
| 601 | * @param bool $createUpdate Indicates whether to create an update on the pulse notifying subscribers on the |
||
| 602 | * changes (required user_id to be set). |
||
| 603 | * |
||
| 604 | * @throws \InvalidArgumentException if $createUpdate is true and $user is null or $user is not a valid user ID or |
||
| 605 | * PulseUser object |
||
| 606 | * |
||
| 607 | * @since 0.1.0 |
||
| 608 | * |
||
| 609 | * @return PulseNote |
||
| 610 | */ |
||
| 611 | 2 | public function addNote ($title, $content, $ownersOnly = false, $user = null, $createUpdate = false) |
|
| 638 | |||
| 639 | /** |
||
| 640 | * Return all of the notes belonging to this project |
||
| 641 | * |
||
| 642 | * @api |
||
| 643 | * |
||
| 644 | * @since 0.1.0 |
||
| 645 | * |
||
| 646 | * @return PulseNote[] |
||
| 647 | */ |
||
| 648 | public function getNotes () |
||
| 654 | |||
| 655 | // ================================================================================================================ |
||
| 656 | // Updates functions |
||
| 657 | // ================================================================================================================ |
||
| 658 | |||
| 659 | /** |
||
| 660 | * Get all of the updates that belong to this Pulse in reverse chronological order |
||
| 661 | * |
||
| 662 | * @api |
||
| 663 | * |
||
| 664 | * @since 0.1.0 |
||
| 665 | * |
||
| 666 | * @return PulseUpdate[] |
||
| 667 | */ |
||
| 668 | 22 | public function getUpdates () |
|
| 674 | |||
| 675 | /** |
||
| 676 | * Create an update for the current Pulse |
||
| 677 | * |
||
| 678 | * @api |
||
| 679 | * |
||
| 680 | * @param int|PulseUser $user |
||
| 681 | * @param string $text |
||
| 682 | * @param null|bool $announceToAll |
||
| 683 | * |
||
| 684 | * @since 0.3.0 A PulseUpdate object is returned containing the information of the newly created Update |
||
| 685 | * @since 0.1.0 |
||
| 686 | * |
||
| 687 | * @return PulseUpdate |
||
| 688 | */ |
||
| 689 | 2 | public function createUpdate ($user, $text, $announceToAll = null) |
|
| 693 | |||
| 694 | // ================================================================================================================ |
||
| 695 | // Static functions |
||
| 696 | // ================================================================================================================ |
||
| 697 | |||
| 698 | /** |
||
| 699 | * Get all of the pulses that belong to the organization across all boards. |
||
| 700 | * |
||
| 701 | * To modify the amount of data returned with pagination, use the following values in the array to configure your |
||
| 702 | * pagination or offsets. |
||
| 703 | * |
||
| 704 | * ```php |
||
| 705 | * $params = array( |
||
| 706 | * "page" => 1, // (int) Page offset to fetch |
||
| 707 | * "per_page" => 10, // (int) Number of results per page |
||
| 708 | * "offset" => 5, // (int) Instead of starting at result 0, start counting from result 5 |
||
| 709 | * "order_by_latest" => true // (bool) Order the pulses with the most recent first |
||
| 710 | * ); |
||
| 711 | * ``` |
||
| 712 | * |
||
| 713 | * @api |
||
| 714 | * |
||
| 715 | * @param array $params GET parameters passed to with the query to modify the data returned. |
||
| 716 | * |
||
| 717 | * @since 0.1.0 |
||
| 718 | * |
||
| 719 | * @return Pulse[] |
||
| 720 | */ |
||
| 721 | public static function getPulses ($params = []) |
||
| 727 | } |
||
| 728 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..