HandleUserTrait::validates() - Code Metrics - Inspection of "previous build failed was caused by sensio/distrib..." - allan-simon/oauth2-symfony2-vagrant-fosuserbundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dfa255...1751e9 )

by Allan

created 2015-11-29 14:28 UTC

HandleUserTrait::validates() A

↳ Parent: HandleUserTrait

Complexity

Conditions	3
Paths	4

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	20
ccs	9
cts	9
cp	1
rs	9.4286
cc	3
eloc	11
nc	4
nop	2
crap	3

<?php

namespace SMG\ManagerBundle\Controller\Traits;

trait HandleUserTrait
{
    /**
     * Check if the information in $user is enough
     * and valid to create a new User in database.
     *
     * @param User   $user  user to validate
     * @param string $group validation group to apply
     *
     * @return array contains the error(s) list,
     *               empty if no error
     */
    private function validates($user, $group)
    {
        $validationRules = array($group);

        if (!is_null($user->getEmail())) {
            $validationRules[] = 'with_email';
        }

        if (!is_null($user->getPhoneNumber())) {
            $validationRules[] = 'with_phone';
        }

        $validator = $this->container->get('validator');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $errors = $validator->validate(
            $user,
            $validationRules
        );

        return $errors;
    }
}


1		<?php
2
3		namespace SMG\ManagerBundle\Controller\Traits;
4
5		trait HandleUserTrait
6		{
7		/**
8		* Check if the information in $user is enough
9		* and valid to create a new User in database.
10		*
11		* @param User $user user to validate
12		* @param string $group validation group to apply
13		*
14		* @return array contains the error(s) list,
15		* empty if no error
16		*/
17	10	private function validates($user, $group)
18		{
19	10	$validationRules = array($group);
20
21	10	if (!is_null($user->getEmail())) {
22	5	$validationRules[] = 'with_email';
23		}
24
25	10	if (!is_null($user->getPhoneNumber())) {
26	5	$validationRules[] = 'with_phone';
27		}
28
29	10	$validator = $this->container->get('validator');
		0 ignored issues – show Bug introduced 2015-11-24 09:12 UTC by Report Bug Copy Issue Report The property `container` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
30	10	$errors = $validator->validate(
31		$user,
32		$validationRules
33		);
34
35	10	return $errors;
36		}
37		}
38

allan-simon / oauth2-symfony2-vagrant-fosuserbundle

Push — master ( dfa255...1751e9 )

HandleUserTrait::validates() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like