alkoumi / laravel-arabic-tafqeet

src/helpers/App.php

<?php


namespace Alkoumi\LaravelArabicTafqeet\Helpers;


trait App
{

    public function runBeforeComma()
    {
        $number = null;
        for ($i=0; $i < count($this->before_comma_array); $i++){

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $num = $this->before_comma_array[$i];
            $number = $number.$num;
        };
            $f = new \NumberFormatter("ar", \NumberFormatter::SPELLOUT);
            return $f->format($number);

It seems like $number can also be of type string; however, parameter $value of NumberFormatter::format() does only seem to accept double|integer, maybe add an additional type check?

    }


    public function runAfterComma()
    {
        $class =  $this->detectClass($this->after_comma_len);
        $methodName = 'Class' . $class;
        if(method_exists($this,$methodName))
        {
            return $this->$methodName($this->after_comma_array,$this->after_comma_len);
        }
        return 'عفوا هذا الرقم خارج نطاقنا حاليا حاول لاحقاً';
    }


    public function detectClass($len)
    {
        if($len == 1)
             return "A";


        if($len == 2)
            return "B";


        if($len == 3)
            return "C";


        if($len == 4)
            return "D";


        if($len == 5)
            return "E";

        if($len == 6)
            return "F";

        if($len == 7)
            return "G";

        if($len == 8)
            return "H";

        if($len == 9)
            return "I";

    }
}