Session::set() - Code Metrics - Inspection of "Session split out of Request" - alkemann/h2l - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#15)

by Alexander

created 2017-08-12 22:43 UTC

Session::set() A

↳ Parent: Session

Complexity

Conditions	3
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	5
nc	2
nop	2
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php

namespace alkemann\h2l;

/**
 * Class Session implementation that access $_SESSION directly
 *
 * @codeCoverageIgnore
 * @package alkemann\h2l
 */
class Session implements interfaces\SessionInterface
{
    /**
     * @param string $key
     * @return mixed|null
     */
    public function get(string $key)
    {
        if (session_status() != \PHP_SESSION_ACTIVE) {
            session_start();
        }
        if (isset($_SESSION[$key])) {
            return $_SESSION[$key];
        }
        if (strpos($key, '.') !== false) {
            return Util::getFromArrayByKey($key, $_SESSION);
        }
        return null;
    }

    /**
     * @param string $key
     * @param $value
     * @throws \Error if trying to set with dot notation
     */
    public function set(string $key, $value): void
    {
        if ($this->active() === false) {
            session_start();
        }
        if (strpos($key, '.') !== false) {
            throw new \Error("Dot notation setting of Session values not implemented yet");
        }
        $_SESSION[$key] = $value;
    }

    /**
     * @param string $key
     */
    public function unset(string $key): void
    {
        unset($_SESSION[$key]);
    }

    /**
     * @return bool
     */
    private function active(): bool
    {
        return session_status() === \PHP_SESSION_ACTIVE;
    }

    /**
     * @return bool
     */
    public function destroy(): bool
    {
        session_destroy();
        if ($this->active()) {
            session_destroy();
            unset($_SESSION);

            return $this->active() === false;
        }
        return false;
    }

    /**
     * @param string $key
     * @return bool
     */
    public function check(string $key): bool
    {
        return isset($_SESSION[$key]);
    }
}


1			<?php
2
3			namespace alkemann\h2l;
4
5			/**
6			* Class Session implementation that access $_SESSION directly
7			*
8			* @codeCoverageIgnore
9			* @package alkemann\h2l
10			*/
11			class Session implements interfaces\SessionInterface
12			{
13			/**
14			* @param string $key
15			* @return mixed\|null
16			*/
17			public function get(string $key)
18			{
19			if (session_status() != \PHP_SESSION_ACTIVE) {
20			session_start();
21			}
22			if (isset($_SESSION[$key])) {
23			return $_SESSION[$key];
24			}
25			if (strpos($key, '.') !== false) {
26			return Util::getFromArrayByKey($key, $_SESSION);
27			}
28			return null;
29			}
30
31			/**
32			* @param string $key
33			* @param $value
34			* @throws \Error if trying to set with dot notation
35			*/
36			public function set(string $key, $value): void
37			{
38			if ($this->active() === false) {
39			session_start();
40			}
41			if (strpos($key, '.') !== false) {
42			throw new \Error("Dot notation setting of Session values not implemented yet");
43			}
44			$_SESSION[$key] = $value;
45			}
46
47			/**
48			* @param string $key
49			*/
50			public function unset(string $key): void
51			{
52			unset($_SESSION[$key]);
53			}
54
55			/**
56			* @return bool
57			*/
58			private function active(): bool
59			{
60			return session_status() === \PHP_SESSION_ACTIVE;
61			}
62
63			/**
64			* @return bool
65			*/
66			public function destroy(): bool
67			{
68			session_destroy();
69			if ($this->active()) {
70			session_destroy();
71			unset($_SESSION);
72
73			return $this->active() === false;
74			}
75			return false;
76			}
77
78			/**
79			* @param string $key
80			* @return bool
81			*/
82			public function check(string $key): bool
83			{
84			return isset($_SESSION[$key]);
85			}
86			}
87

alkemann / h2l

Pull Request — master (#15)

Session::set() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like