Route::__toString() - Code Metrics - Inspection of "Session split out of Request" - alkemann/h2l - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#15)

by Alexander

created 2017-08-12 22:43 UTC

Route::__toString() A

↳ Parent: Route

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

namespace alkemann\h2l;

use Closure;

/**
 * Class Route
 *
 * @package alkemann\h2l
 */
class Route
{

    /**
     * @var string
     */
    private $url;
    /**
     * @var Closure
     */
    private $callback;
    /**
     * @var array
     */
    private $parameters;

    /**
     * Route constructor.
     *
     * @param string $url
     * @param Closure|null $cb
     * @param array $parameters
     */
    public function __construct(string $url, ?Closure $cb = null, array $parameters = [])
    {
        $this->url = $url;
        $this->callback = $cb;
        $this->parameters = $parameters;
    }

    public function url(): string
    {
        return $this->url;
    }

    public function parameters(): array
    {
        return $this->parameters;
    }

    public function __invoke(Request $request): Response
    {
        return call_user_func_array($this->callback, [$request]);

    }

    public function __toString(): string
    {
        return $this->url;
    }
}


1			<?php
2
3			namespace alkemann\h2l;
4
5			use Closure;
6
7			/**
8			* Class Route
9			*
10			* @package alkemann\h2l
11			*/
12			class Route
13			{
14
15			/**
16			* @var string
17			*/
18			private $url;
19			/**
20			* @var Closure
21			*/
22			private $callback;
23			/**
24			* @var array
25			*/
26			private $parameters;
27
28			/**
29			* Route constructor.
30			*
31			* @param string $url
32			* @param Closure\|null $cb
33			* @param array $parameters
34			*/
35			public function __construct(string $url, ?Closure $cb = null, array $parameters = [])
36			{
37			$this->url = $url;
38			$this->callback = $cb;
39			$this->parameters = $parameters;
40			}
41
42			public function url(): string
43			{
44			return $this->url;
45			}
46
47			public function parameters(): array
48			{
49			return $this->parameters;
50			}
51
52			public function __invoke(Request $request): Response
53			{
54			return call_user_func_array($this->callback, [$request]);
			0 ignored issues – show Bug Best Practice introduced 2017-08-12 22:39 UTC by Report Bug Copy Issue Report The expression `return call_user_func_ar...lback, array($request))` returns the type `mixed` which includes types incompatible with the type-hinted return `alkemann\h2l\Response`. Loading history...
55			}
56
57			public function __toString(): string
58			{
59			return $this->url;
60			}
61			}
62

alkemann / h2l

Pull Request — master (#15)

Route::__toString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like