Json::formattedContent() - Code Metrics - Inspection of "Refactor response pattern" - alkemann/h2l - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#25)

by Alexander

created 2017-09-07 14:41 UTC

Json::formattedContent() A

↳ Parent: Project

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	0
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

namespace alkemann\h2l\response;

use alkemann\h2l\Message;
use alkemann\h2l\Response;
use alkemann\h2l\util\Http;

/**
 * Class Json
 *
 * @package alkemann\h2l
 */
class Json extends Response
{
    public function __construct($content = null, int $code = Http::CODE_OK, array $config = [])
    {
        $this->config = $config;
        $this->message = (new Message())
            ->withCode($code)
            ->withHeaders([
                'Content-Type' => Http::CONTENT_JSON
            ])
            ->withBody($this->encodeAndContainData($content))
        ;
    }

    /**
     * Set header and return a string rendered and ready to be echo'ed as response
     *
     * Header 'Content-type:' will be set using `header` or an injeced 'header_func' through constructor
     */
    public function render(): string
    {
        $this->setHeaders();
        return $this->message->body();

    }

    private function encodeAndContainData($content): string
    {
        if (empty($content)) {
            return "";
        }
        if ($content instanceof \Generator) {
            $content = iterator_to_array($content);
        }
        return json_encode(['data' => $content]);
    }
}


1			<?php
2
3			namespace alkemann\h2l\response;
4
5			use alkemann\h2l\Message;
6			use alkemann\h2l\Response;
7			use alkemann\h2l\util\Http;
8
9			/**
10			* Class Json
11			*
12			* @package alkemann\h2l
13			*/
14			class Json extends Response
15			{
16			public function __construct($content = null, int $code = Http::CODE_OK, array $config = [])
17			{
18			$this->config = $config;
19			$this->message = (new Message())
20			->withCode($code)
21			->withHeaders([
22			'Content-Type' => Http::CONTENT_JSON
23			])
24			->withBody($this->encodeAndContainData($content))
25			;
26			}
27
28			/**
29			* Set header and return a string rendered and ready to be echo'ed as response
30			*
31			* Header 'Content-type:' will be set using `header` or an injeced 'header_func' through constructor
32			*/
33			public function render(): string
34			{
35			$this->setHeaders();
36			return $this->message->body();
			0 ignored issues – show Bug Best Practice introduced 2017-09-07 12:56 UTC by Report Bug Copy Issue Report The expression `return $this->message->body()` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
37			}
38
39			private function encodeAndContainData($content): string
40			{
41			if (empty($content)) {
42			return "";
43			}
44			if ($content instanceof \Generator) {
45			$content = iterator_to_array($content);
46			}
47			return json_encode(['data' => $content]);
48			}
49			}
50

alkemann / h2l

Pull Request — master (#25)

Json::formattedContent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like