alkemann\h2l\Response::fileEndingFromType()

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	Response::code()	0	3	1

<?php

namespace alkemann\h2l;

use alkemann\h2l\util\Http;

/**
 * Abstract class Response
 *
 * @package alkemann\h2l
 */
abstract class Response
{
    /**
     * @var array
     */
    protected $config = [];
    /**
     * @var Message
     */
    protected $message;

    public function code(): int
    {
        return $this->message->code();

The expression return $this->message->code() could return the type null which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }

    public function contentType(): string
    {
        return $this->message->contentType();
    }

    public function message(): ?Message
    {
        return $this->message;
    }

    /**
     * @throws \Error
     */
    protected function setHeaders(): void
    {
        $h = $this->config['header_func'] ?? 'header';
        if (is_callable($h) === false) {
            throw new \Error("header_func is not callable");

The call to Error::__construct() has too many arguments starting with 'header_func is not callable'.

        }
        $code = $this->message->code();
        if ($code != Http::CODE_OK) {
            $msg = Http::httpCodeToMessage($code);
            $h("HTTP/1.1 {$code} {$msg}");
        }

        foreach ($this->message->headers() as $name => $value) {
            $h("{$name}: $value");
        }
    }

    abstract public function render(): string;
}