ClientFilter::connectTimeout() - Code Metrics - Inspection of "extend timeout to support milliseconds" - aliyun/openapi-sdk-php-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#143)

by Yong

created 2019-04-30 03:11 UTC

ClientFilter::connectTimeout() A

↳ Parent: ClientFilter

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	10
ccs	6
cts	6
cp	1
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace AlibabaCloud\Client\Filter;

use AlibabaCloud\Client\SDK;
use AlibabaCloud\Client\Exception\ClientException;

/**
 * Class ClientFilter
 *
 * @package AlibabaCloud\Client\Filter
 */
class ClientFilter
{
    /**
     * @param $regionId
     *
     * @return string
     *
     * @throws ClientException
     */
    public static function regionId($regionId)
    {
        if (!is_string($regionId)) {
            throw new ClientException(
                'Region ID must be a string',
                SDK::INVALID_ARGUMENT
            );
        }

        if ($regionId === '') {
            throw new ClientException(
                'Region ID cannot be empty',
                SDK::INVALID_ARGUMENT
            );
        }

        return $regionId;
    }

    /**
     * @param $clientName
     *
     * @return string
     *
     * @throws ClientException
     */
    public static function clientName($clientName)
    {
        if (!is_string($clientName)) {
            throw new ClientException(
                'Client Name must be a string',
                SDK::INVALID_ARGUMENT
            );
        }

        if ($clientName === '') {
            throw new ClientException(
                'Client Name cannot be empty',
                SDK::INVALID_ARGUMENT
            );
        }

        return strtolower($clientName);
    }

    /**
     * @param $connectTimeout
     *
     * @return mixed
     * @throws ClientException
     */
    public static function connectTimeout($connectTimeout)
    {
        if ($connectTimeout === '') {
            throw new ClientException(
                'Connect Timeout cannot be empty',
                SDK::INVALID_ARGUMENT
            );
        }

        return $connectTimeout;
    }

    /**
     * @param $timeout
     *
     * @return mixed
     * @throws ClientException
     */
    public static function timeout($timeout)
    {
        if ($timeout === '') {
            throw new ClientException(
                'Timeout cannot be empty',
                SDK::INVALID_ARGUMENT
            );
        }

        return $timeout;
    }

    /**
     * @param int $Milliseconds
     *
     * @return mixed
     * @throws ClientException
     */
    public static function milliseconds($Milliseconds)
    {
        if (!is_int($Milliseconds)) {

            throw new ClientException(
                'Milliseconds must be int',
                SDK::INVALID_ARGUMENT
            );
        }

        return $Milliseconds;
    }
}


1		<?php
2
3		namespace AlibabaCloud\Client\Filter;
4
5		use AlibabaCloud\Client\SDK;
6		use AlibabaCloud\Client\Exception\ClientException;
7
8		/**
9		* Class ClientFilter
10		*
11		* @package AlibabaCloud\Client\Filter
12		*/
13		class ClientFilter
14		{
15		/**
16		* @param $regionId
17		*
18		* @return string
19		*
20		* @throws ClientException
21		*/
22	101	public static function regionId($regionId)
23		{
24	101	if (!is_string($regionId)) {
25	4	throw new ClientException(
26	4	'Region ID must be a string',
27		SDK::INVALID_ARGUMENT
28	4	);
29		}
30
31	97	if ($regionId === '') {
32	4	throw new ClientException(
33	4	'Region ID cannot be empty',
34		SDK::INVALID_ARGUMENT
35	4	);
36		}
37
38	93	return $regionId;
39		}
40
41		/**
42		* @param $clientName
43		*
44		* @return string
45		*
46		* @throws ClientException
47		*/
48	161	public static function clientName($clientName)
49		{
50	161	if (!is_string($clientName)) {
51	5	throw new ClientException(
52	5	'Client Name must be a string',
53		SDK::INVALID_ARGUMENT
54	5	);
55		}
56
57	156	if ($clientName === '') {
58	5	throw new ClientException(
59	5	'Client Name cannot be empty',
60		SDK::INVALID_ARGUMENT
61	5	);
62		}
63
64	151	return strtolower($clientName);
65		}
66
67		/**
68		* @param $connectTimeout
69		*
70		* @return mixed
71		* @throws ClientException
72		*/
73	60	public static function connectTimeout($connectTimeout)
74		{
75	60	if ($connectTimeout === '') {
76	2	throw new ClientException(
77	2	'Connect Timeout cannot be empty',
78		SDK::INVALID_ARGUMENT
79	2	);
80		}
81
82	58	return $connectTimeout;
83		}
84
85		/**
86		* @param $timeout
87		*
88		* @return mixed
89		* @throws ClientException
90		*/
91	61	public static function timeout($timeout)
92		{
93	61	if ($timeout === '') {
94	2	throw new ClientException(
95	2	'Timeout cannot be empty',
96		SDK::INVALID_ARGUMENT
97	2	);
98		}
99
100	59	return $timeout;
101		}
102
103		/**
104		* @param int $Milliseconds
105		*
106		* @return mixed
107		* @throws ClientException
108		*/
109	4	public static function milliseconds($Milliseconds)
110		{
111	4	if (!is_int($Milliseconds)) {
		0 ignored issues – show introduced 2019-04-30 03:17 UTC by Report Bug Copy Issue Report The condition `is_int($Milliseconds)` is always `true`. Loading history...
112	2	throw new ClientException(
113	2	'Milliseconds must be int',
114		SDK::INVALID_ARGUMENT
115	2	);
116		}
117
118	2	return $Milliseconds;
119		}
120		}
121

aliyun / openapi-sdk-php-client

GitHub Access Token became invalid

Pull Request — master (#143)

ClientFilter::connectTimeout() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like