RetryTrait::shouldRetry() - Code Metrics - Inspection of "Retry & Async" - aliyun/openapi-sdk-php-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#145)

by Yong

created 2019-05-06 07:50 UTC

RetryTrait::shouldRetry() A

↳ Parent: RetryTrait

Complexity

Conditions	5
Paths	5

Size

Total Lines	17
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	5.2

Importance

Changes

Metric	Value
cc	5
eloc	8
nc	5
nop	1
dl	0
loc	17
ccs	8
cts	10
cp	0.8
crap	5.2
rs	9.6111
c	0
b	0
f	0

<?php

namespace AlibabaCloud\Client\Request\Traits;

use Stringy\Stringy;
use AlibabaCloud\Client\Result\Result;
use AlibabaCloud\Client\Filter\ClientFilter;
use AlibabaCloud\Client\Exception\ClientException;

/**
 * Trait RetryTrait
 *
 * @package AlibabaCloud\Client\Request\Traits
 */
trait RetryTrait
{
    /**
     * Retry Times
     *
     * @var int
     */
    private $retry = 0;

    /**
     * Retry Strings
     *
     * @var string[]
     */
    private $retryStrings = [];

    /**
     * Retry Codes
     *
     * @var int[]
     */
    private $retryStatusCodes = [];

    /**
     * @param int   $times
     * @param array $strings
     * @param array $statusCodes
     *
     * @return $this
     * @throws ClientException
     */
    public function retry($times, array $strings, array $statusCodes = [])
    {
        $this->retry            = ClientFilter::retry($times);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->retryStrings     = $strings;
        $this->retryStatusCodes = $statusCodes;

        return $this;
    }

    /**
     * @param Result $result
     *
     * @return bool
     */
    private function shouldRetry(Result $result)
    {
        if ($this->retry <= 0) {
            return false;
        }

        if (in_array($result->getResponse()->getStatusCode(), $this->retryStatusCodes)) {
            return true;
        }

        foreach ($this->retryStrings as $message) {
            if (Stringy::create($result->getResponse()->getBody())->contains($message)) {
                return true;
            }
        }

        return false;
    }
}


1		<?php
2
3		namespace AlibabaCloud\Client\Request\Traits;
4
5		use Stringy\Stringy;
6		use AlibabaCloud\Client\Result\Result;
7		use AlibabaCloud\Client\Filter\ClientFilter;
8		use AlibabaCloud\Client\Exception\ClientException;
9
10		/**
11		* Trait RetryTrait
12		*
13		* @package AlibabaCloud\Client\Request\Traits
14		*/
15		trait RetryTrait
16		{
17		/**
18		* Retry Times
19		*
20		* @var int
21		*/
22		private $retry = 0;
23
24		/**
25		* Retry Strings
26		*
27		* @var string[]
28		*/
29		private $retryStrings = [];
30
31		/**
32		* Retry Codes
33		*
34		* @var int[]
35		*/
36		private $retryStatusCodes = [];
37
38		/**
39		* @param int $times
40		* @param array $strings
41		* @param array $statusCodes
42		*
43		* @return $this
44		* @throws ClientException
45		*/
46	2	public function retry($times, array $strings, array $statusCodes = [])
47		{
48	2	$this->retry = ClientFilter::retry($times);
		0 ignored issues – show Documentation Bug introduced 2019-05-06 07:55 UTC by Report Bug Copy Issue Report The property `$retry` was declared of type `integer`, but `AlibabaCloud\Client\Filt...ntFilter::retry($times)` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
49	2	$this->retryStrings = $strings;
50	2	$this->retryStatusCodes = $statusCodes;
51
52	2	return $this;
53		}
54
55		/**
56		* @param Result $result
57		*
58		* @return bool
59		*/
60	21	private function shouldRetry(Result $result)
61		{
62	21	if ($this->retry <= 0) {
63	21	return false;
64		}
65
66	2	if (in_array($result->getResponse()->getStatusCode(), $this->retryStatusCodes)) {
67	1	return true;
68		}
69
70	1	foreach ($this->retryStrings as $message) {
71	1	if (Stringy::create($result->getResponse()->getBody())->contains($message)) {
72	1	return true;
73		}
74		}
75
76		return false;
77		}
78		}
79

aliyun / openapi-sdk-php-client

GitHub Access Token became invalid

Pull Request — master (#145)

RetryTrait::shouldRetry() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like