AlibabaCloud\Client\Request\Traits\RetryTrait

Complexity

Total Complexity

6

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Test Coverage

Coverage

86.67%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	retry()	0	7	1
A	shouldRetry()	0	17	5

<?php

namespace AlibabaCloud\Client\Request\Traits;

use Stringy\Stringy;
use AlibabaCloud\Client\Result\Result;
use AlibabaCloud\Client\Filter\ClientFilter;
use AlibabaCloud\Client\Exception\ClientException;

/**
 * Trait RetryTrait
 *
 * @package AlibabaCloud\Client\Request\Traits
 */
trait RetryTrait
{
    /**
     * Retry Times
     *
     * @var int
     */
    private $retry = 0;

    /**
     * Retry Strings
     *
     * @var string[]
     */
    private $retryStrings = [];

    /**
     * Retry Codes
     *
     * @var int[]
     */
    private $retryStatusCodes = [];

    /**
     * @param int   $times
     * @param array $strings
     * @param array $statusCodes
     *
     * @return $this
     * @throws ClientException
     */
    public function retry($times, array $strings, array $statusCodes = [])
    {
        $this->retry            = ClientFilter::retry($times);

The property $retry was declared of type integer, but AlibabaCloud\Client\Filter\ClientFilter::retry($times) is of type string. Maybe add a type cast?

        $this->retryStrings     = $strings;
        $this->retryStatusCodes = $statusCodes;

        return $this;
    }

    /**
     * @param Result $result
     *
     * @return bool
     */
    private function shouldRetry(Result $result)
    {
        if ($this->retry <= 0) {
            return false;
        }

        if (in_array($result->getResponse()->getStatusCode(), $this->retryStatusCodes)) {
            return true;
        }

        foreach ($this->retryStrings as $message) {
            if (Stringy::create($result->getResponse()->getBody())->contains($message)) {
                return true;
            }
        }

        return false;
    }
}