AlibabaCloud\Client\Credentials\Providers\RamRoleArnProvider

Complexity

Total Complexity

4

Size/Duplication

Total Lines	64
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	request()	0	16	1
A	get()	0	21	3

<?php

namespace AlibabaCloud\Client\Credentials\Providers;

use AlibabaCloud\Client\SDK;
use AlibabaCloud\Client\AlibabaCloud;
use AlibabaCloud\Client\Result\Result;
use AlibabaCloud\Client\Request\Request;
use AlibabaCloud\Client\Credentials\StsCredential;
use AlibabaCloud\Client\Exception\ClientException;
use AlibabaCloud\Client\Exception\ServerException;
use AlibabaCloud\Client\Credentials\Requests\AssumeRole;

/**
 * Class RamRoleArnProvider
 *
 * @package   AlibabaCloud\Client\Credentials\Providers
 */
class RamRoleArnProvider extends Provider
{

    /**
     * Get credential.
     *
     *
     * @param int $timeout
     * @param int $connectTimeout
     *
     * @return StsCredential
     * @throws ClientException
     * @throws ServerException
     */
    public function get($timeout = Request::TIMEOUT, $connectTimeout = Request::CONNECT_TIMEOUT)
    {
        $credential = $this->getCredentialsInCache();

        if (null === $credential) {
            $result = $this->request($timeout, $connectTimeout);

            if (!isset($result['Credentials']['AccessKeyId'],
                $result['Credentials']['AccessKeySecret'],
                $result['Credentials']['SecurityToken'])) {
                throw new ServerException($result, $this->error, SDK::INVALID_CREDENTIAL);
            }

            $credential = $result['Credentials'];
            $this->cache($credential);

It seems like $credential can also be of type null; however, parameter $credential of AlibabaCloud\Client\Credentials\Providers\Provider::cache() does only seem to accept array, maybe add an additional type check?

        }

        return new StsCredential(
            $credential['AccessKeyId'],
            $credential['AccessKeySecret'],
            $credential['SecurityToken']
        );
    }

    /**
     * Get credentials by request.
     *
     * @param $timeout
     * @param $connectTimeout
     *
     * @return Result
     * @throws ClientException
     * @throws ServerException
     */
    private function request($timeout, $connectTimeout)
    {
        $clientName = __CLASS__ . \uniqid('ak', true);
        $credential = $this->client->getCredential();

        AlibabaCloud::accessKeyClient(
            $credential->getAccessKeyId(),

The method getAccessKeyId() does not exist on AlibabaCloud\Client\Credentials\CredentialsInterface. It seems like you code against a sub-type of said class. However, the method does not exist in AlibabaCloud\Client\Credentials\RsaKeyPairCredential or AlibabaCloud\Client\Credentials\EcsRamRoleCredential. Are you sure you never get one of those?

The method getAccessKeyId() does not exist on AlibabaCloud\Client\Credentials\EcsRamRoleCredential.

The method getAccessKeyId() does not exist on AlibabaCloud\Client\Credentials\RsaKeyPairCredential.

            $credential->getAccessKeySecret()

The method getAccessKeySecret() does not exist on AlibabaCloud\Client\Credentials\CredentialsInterface. It seems like you code against a sub-type of said class. However, the method does not exist in AlibabaCloud\Client\Credentials\RsaKeyPairCredential or AlibabaCloud\Client\Credentials\EcsRamRoleCredential. Are you sure you never get one of those?

The method getAccessKeySecret() does not exist on AlibabaCloud\Client\Credentials\EcsRamRoleCredential.

The method getAccessKeySecret() does not exist on AlibabaCloud\Client\Credentials\RsaKeyPairCredential.

        )->name($clientName);

        return (new AssumeRole($credential))

It seems like $credential can also be of type AlibabaCloud\Client\Credentials\AccessKeyCredential and AlibabaCloud\Client\Credentials\BearerTokenCredential and AlibabaCloud\Client\Credentials\EcsRamRoleCredential and AlibabaCloud\Client\Credentials\RsaKeyPairCredential and AlibabaCloud\Client\Credentials\StsCredential; however, parameter $arnCredential of AlibabaCloud\Client\Credentials\Requests\AssumeRole::__construct() does only seem to accept AlibabaCloud\Client\Credentials\RamRoleArnCredential, maybe add an additional type check?

            ->client($clientName)
            ->timeout($timeout)
            ->connectTimeout($connectTimeout)
            ->debug($this->client->isDebug())
            ->request();
    }
}