aliyun /
credentials-go
| Conditions | 17 |
| Total Lines | 166 |
| Code Lines | 108 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
Complex classes like providers.TestECSRAMRoleCredentialsProvider_getCredentials often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
| 1 | package providers |
||
| 112 | func TestECSRAMRoleCredentialsProvider_getCredentials(t *testing.T) { |
||
| 113 | originHttpDo := httpDo |
||
| 114 | defer func() { httpDo = originHttpDo }() |
||
| 115 | |||
| 116 | p, err := NewECSRAMRoleCredentialsProviderBuilder().Build() |
||
| 117 | assert.Nil(t, err) |
||
| 118 | |||
| 119 | // case 1: server error |
||
| 120 | httpDo = func(req *httputil.Request) (res *httputil.Response, err error) { |
||
| 121 | err = errors.New("mock server error") |
||
| 122 | return |
||
| 123 | } |
||
| 124 | _, err = p.getCredentials() |
||
| 125 | assert.NotNil(t, err) |
||
| 126 | assert.Equal(t, "get role name failed: mock server error", err.Error()) |
||
| 127 | |||
| 128 | // case 2: get role name ok, get credentials failed with server error |
||
| 129 | httpDo = func(req *httputil.Request) (res *httputil.Response, err error) { |
||
| 130 | if req.Path == "/latest/meta-data/ram/security-credentials/" { |
||
| 131 | res = &httputil.Response{ |
||
| 132 | StatusCode: 200, |
||
| 133 | Body: []byte("rolename"), |
||
| 134 | } |
||
| 135 | return |
||
| 136 | } |
||
| 137 | err = errors.New("mock server error") |
||
| 138 | return |
||
| 139 | } |
||
| 140 | |||
| 141 | _, err = p.getCredentials() |
||
| 142 | assert.NotNil(t, err) |
||
| 143 | assert.Equal(t, "refresh Ecs sts token err: mock server error", err.Error()) |
||
| 144 | |||
| 145 | // case 3: 4xx error |
||
| 146 | httpDo = func(req *httputil.Request) (res *httputil.Response, err error) { |
||
| 147 | if req.Path == "/latest/meta-data/ram/security-credentials/" { |
||
| 148 | res = &httputil.Response{ |
||
| 149 | StatusCode: 200, |
||
| 150 | Body: []byte("rolename"), |
||
| 151 | } |
||
| 152 | return |
||
| 153 | } |
||
| 154 | |||
| 155 | res = &httputil.Response{ |
||
| 156 | StatusCode: 400, |
||
| 157 | Body: []byte("4xx error"), |
||
| 158 | } |
||
| 159 | return |
||
| 160 | } |
||
| 161 | |||
| 162 | _, err = p.getCredentials() |
||
| 163 | assert.NotNil(t, err) |
||
| 164 | assert.Equal(t, "refresh Ecs sts token err, httpStatus: 400, message = 4xx error", err.Error()) |
||
| 165 | |||
| 166 | // case 4: invalid json |
||
| 167 | httpDo = func(req *httputil.Request) (res *httputil.Response, err error) { |
||
| 168 | if req.Path == "/latest/meta-data/ram/security-credentials/" { |
||
| 169 | res = &httputil.Response{ |
||
| 170 | StatusCode: 200, |
||
| 171 | Body: []byte("rolename"), |
||
| 172 | } |
||
| 173 | return |
||
| 174 | } |
||
| 175 | |||
| 176 | res = &httputil.Response{ |
||
| 177 | StatusCode: 200, |
||
| 178 | Body: []byte("invalid json"), |
||
| 179 | } |
||
| 180 | return |
||
| 181 | } |
||
| 182 | |||
| 183 | _, err = p.getCredentials() |
||
| 184 | assert.NotNil(t, err) |
||
| 185 | assert.Equal(t, "refresh Ecs sts token err, json.Unmarshal fail: invalid character 'i' looking for beginning of value", err.Error()) |
||
| 186 | |||
| 187 | // case 5: empty response json |
||
| 188 | httpDo = func(req *httputil.Request) (res *httputil.Response, err error) { |
||
| 189 | if req.Path == "/latest/meta-data/ram/security-credentials/" { |
||
| 190 | res = &httputil.Response{ |
||
| 191 | StatusCode: 200, |
||
| 192 | Body: []byte("rolename"), |
||
| 193 | } |
||
| 194 | return |
||
| 195 | } |
||
| 196 | |||
| 197 | res = &httputil.Response{ |
||
| 198 | StatusCode: 200, |
||
| 199 | Body: []byte("null"), |
||
| 200 | } |
||
| 201 | return |
||
| 202 | } |
||
| 203 | |||
| 204 | _, err = p.getCredentials() |
||
| 205 | assert.NotNil(t, err) |
||
| 206 | assert.Equal(t, "refresh Ecs sts token err, fail to get credentials", err.Error()) |
||
| 207 | |||
| 208 | // case 6: empty session ak response json |
||
| 209 | httpDo = func(req *httputil.Request) (res *httputil.Response, err error) { |
||
| 210 | if req.Path == "/latest/meta-data/ram/security-credentials/" { |
||
| 211 | res = &httputil.Response{ |
||
| 212 | StatusCode: 200, |
||
| 213 | Body: []byte("rolename"), |
||
| 214 | } |
||
| 215 | return |
||
| 216 | } |
||
| 217 | |||
| 218 | res = &httputil.Response{ |
||
| 219 | StatusCode: 200, |
||
| 220 | Body: []byte("{}"), |
||
| 221 | } |
||
| 222 | return |
||
| 223 | } |
||
| 224 | _, err = p.getCredentials() |
||
| 225 | assert.NotNil(t, err) |
||
| 226 | assert.Equal(t, "refresh Ecs sts token err, fail to get credentials", err.Error()) |
||
| 227 | |||
| 228 | // case 7: non-success response |
||
| 229 | httpDo = func(req *httputil.Request) (res *httputil.Response, err error) { |
||
| 230 | if req.Path == "/latest/meta-data/ram/security-credentials/" { |
||
| 231 | res = &httputil.Response{ |
||
| 232 | StatusCode: 200, |
||
| 233 | Body: []byte("rolename"), |
||
| 234 | } |
||
| 235 | return |
||
| 236 | } |
||
| 237 | |||
| 238 | res = &httputil.Response{ |
||
| 239 | StatusCode: 200, |
||
| 240 | Body: []byte(`{"AccessKeyId":"saki","AccessKeySecret":"saks","Expiration":"2021-10-20T04:27:09Z","SecurityToken":"token","Code":"Failed"}`), |
||
| 241 | } |
||
| 242 | return |
||
| 243 | } |
||
| 244 | _, err = p.getCredentials() |
||
| 245 | assert.NotNil(t, err) |
||
| 246 | assert.Equal(t, "refresh Ecs sts token err, Code is not Success", err.Error()) |
||
| 247 | |||
| 248 | // case 8: mock ok value |
||
| 249 | httpDo = func(req *httputil.Request) (res *httputil.Response, err error) { |
||
| 250 | if req.Path == "/latest/meta-data/ram/security-credentials/" { |
||
| 251 | res = &httputil.Response{ |
||
| 252 | StatusCode: 200, |
||
| 253 | Body: []byte("rolename"), |
||
| 254 | } |
||
| 255 | return |
||
| 256 | } |
||
| 257 | |||
| 258 | res = &httputil.Response{ |
||
| 259 | StatusCode: 200, |
||
| 260 | Body: []byte(`{"AccessKeyId":"saki","AccessKeySecret":"saks","Expiration":"2021-10-20T04:27:09Z","SecurityToken":"token","Code":"Success"}`), |
||
| 261 | } |
||
| 262 | return |
||
| 263 | } |
||
| 264 | creds, err := p.getCredentials() |
||
| 265 | assert.Nil(t, err) |
||
| 266 | assert.Equal(t, "saki", creds.AccessKeyId) |
||
| 267 | assert.Equal(t, "saks", creds.AccessKeySecret) |
||
| 268 | assert.Equal(t, "token", creds.SecurityToken) |
||
| 269 | assert.Equal(t, "2021-10-20T04:27:09Z", creds.Expiration) |
||
| 270 | |||
| 271 | // needUpdateCredential |
||
| 272 | assert.True(t, p.needUpdateCredential()) |
||
| 273 | p.expirationTimestamp = time.Now().Unix() |
||
| 274 | assert.True(t, p.needUpdateCredential()) |
||
| 275 | |||
| 276 | p.expirationTimestamp = time.Now().Unix() + 300 |
||
| 277 | assert.False(t, p.needUpdateCredential()) |
||
| 278 | } |
||
| 401 |
