http.TestDoWithError - Code Metrics - Inspection of "refine ecs ram role credentials provider" - aliyun/credentials-go - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( b5116a...3bd38f )

unknown

created 2024-08-23 09:12 UTC

http.TestDoWithError B

↳ Parent: credentials/internal/http/http_test.go

Complexity

Conditions

Size

Total Lines	57
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	8
eloc	38
nop	1
dl	0
loc	57
rs	7.1013
c	0
b	0
f	0

How to fix Long Method

package http

import (
	"errors"
	"io"
	"io/ioutil"
	"net/http"
	"testing"
	"time"

	"github.com/stretchr/testify/assert"
)

func TestRequest(t *testing.T) {
	req := &Request{
		Method:   "GET",
		Protocol: "http",
		Host:     "www.aliyun.com",
		Path:     "/",
	}
	assert.Equal(t, "GET http://www.aliyun.com/", req.BuildRequestURL())
	// With query
	req = &Request{
		Method:   "GET",
		Protocol: "http",
		Host:     "www.aliyun.com",
		Path:     "/",
		Queries: map[string]string{
			"spm": "test",
		},
	}
	assert.Equal(t, "GET http://www.aliyun.com/?spm=test", req.BuildRequestURL())
}

func TestDoGet(t *testing.T) {
	req := &Request{
		Method:   "GET",
		Protocol: "http",
		Host:     "www.aliyun.com",
		Path:     "/",
	}
	res, err := Do(req)
	assert.Nil(t, err)
	assert.NotNil(t, res)
	assert.Equal(t, 200, res.StatusCode)
	assert.Equal(t, "text/html; charset=utf-8", res.Headers["Content-Type"])
}

func TestDoPost(t *testing.T) {
	req := &Request{
		Method:   "POST",
		Protocol: "http",
		Host:     "www.aliyun.com",
		Path:     "/",
		Form: map[string]string{
			"URL": "HI",
		},
		Headers: map[string]string{
			"Accept-Language": "zh",
		},
	}
	res, err := Do(req)
	assert.Nil(t, err)
	assert.NotNil(t, res)
	assert.Equal(t, 200, res.StatusCode)
	assert.Equal(t, "text/html; charset=utf-8", res.Headers["Content-Type"])
}

type errorReader struct {
}

func (r *errorReader) Read(p []byte) (n int, err error) {
	err = errors.New("read failed")
	return
}

func TestDoWithError(t *testing.T) {
	originNewRequest := newRequest
	defer func() { newRequest = originNewRequest }()

	// case 1: mock new http request failed
	newRequest = func(method, url string, body io.Reader) (*http.Request, error) {
		return nil, errors.New("new http request failed")
	}

	req := &Request{
		Method:   "POST",
		Protocol: "http",
		Host:     "www.aliyun.com",
		Path:     "/",
		Form: map[string]string{
			"URL": "HI",
		},
		Headers: map[string]string{
			"Accept-Language": "zh",
		},
	}
	_, err := Do(req)
	assert.EqualError(t, err, "new http request failed")

	// reset new request
	newRequest = originNewRequest

	// case 2: server error
	originDo := hookDo
	defer func() { hookDo = originDo }()
	hookDo = func(fn do) do {
		return func(req *http.Request) (res *http.Response, err error) {
			err = errors.New("mock server error")
			return
		}
	}
	_, err = Do(req)
	assert.EqualError(t, err, "mock server error")

	// case 4: mock read response error
	hookDo = func(fn do) do {
		return func(req *http.Request) (res *http.Response, err error) {
			res = &http.Response{
				Proto:      "HTTP/1.1",
				ProtoMajor: 1,
				ProtoMinor: 1,
				Header:     map[string][]string{},
				StatusCode: 200,
				Status:     "200 " + http.StatusText(200),
			}
			res.Body = ioutil.NopCloser(&errorReader{})
			return
		}
	}

	_, err = Do(req)
	assert.EqualError(t, err, "read failed")
}

func TestDoWithProxy(t *testing.T) {
	req := &Request{
		Method:   "POST",
		Protocol: "http",
		Host:     "www.aliyun.com",
		Path:     "/",
		Form: map[string]string{
			"URL": "HI",
		},
		Headers: map[string]string{
			"Accept-Language": "zh",
		},
		Proxy: "http://localhost:9999/",
	}
	_, err := Do(req)
	assert.Contains(t, err.Error(), "proxyconnect tcp: dial tcp")
	assert.Contains(t, err.Error(), "connect: connection refused")

	// invalid proxy url
	req.Proxy = string([]byte{0x7f})
	_, err = Do(req)
	assert.Contains(t, err.Error(), "net/url: invalid control character in URL")
}

func TestDoWithConnectTimeout(t *testing.T) {
	req := &Request{
		Method:   "POST",
		Protocol: "http",
		Host:     "www.aliyun.com",
		Path:     "/",
		Form: map[string]string{
			"URL": "HI",
		},
		Headers: map[string]string{
			"Accept-Language": "zh",
		},
		ConnectTimeout: 1 * time.Nanosecond,
	}
	_, err := Do(req)
	assert.Contains(t, err.Error(), "dial tcp: ")
	assert.Contains(t, err.Error(), "i/o timeout")
}

func TestDoWithReadTimeout(t *testing.T) {
	req := &Request{
		Method:      "POST",
		Protocol:    "http",
		Host:        "www.aliyun.com",
		Path:        "/",
		ReadTimeout: 1 * time.Nanosecond,
	}
	_, err := Do(req)
	assert.Contains(t, err.Error(), "(Client.Timeout exceeded while awaiting headers)")
}


1			package http
2
3			import (
4			"errors"
5			"io"
6			"io/ioutil"
7			"net/http"
8			"testing"
9			"time"
10
11			"github.com/stretchr/testify/assert"
12			)
13
14			func TestRequest(t *testing.T) {
15			req := &Request{
16			Method: "GET",
17			Protocol: "http",
18			Host: "www.aliyun.com",
19			Path: "/",
20			}
21			assert.Equal(t, "GET http://www.aliyun.com/", req.BuildRequestURL())
22			// With query
23			req = &Request{
24			Method: "GET",
25			Protocol: "http",
26			Host: "www.aliyun.com",
27			Path: "/",
28			Queries: map[string]string{
29			"spm": "test",
30			},
31			}
32			assert.Equal(t, "GET http://www.aliyun.com/?spm=test", req.BuildRequestURL())
33			}
34
35			func TestDoGet(t *testing.T) {
36			req := &Request{
37			Method: "GET",
38			Protocol: "http",
39			Host: "www.aliyun.com",
40			Path: "/",
41			}
42			res, err := Do(req)
43			assert.Nil(t, err)
44			assert.NotNil(t, res)
45			assert.Equal(t, 200, res.StatusCode)
46			assert.Equal(t, "text/html; charset=utf-8", res.Headers["Content-Type"])
47			}
48
49			func TestDoPost(t *testing.T) {
50			req := &Request{
51			Method: "POST",
52			Protocol: "http",
53			Host: "www.aliyun.com",
54			Path: "/",
55			Form: map[string]string{
56			"URL": "HI",
57			},
58			Headers: map[string]string{
59			"Accept-Language": "zh",
60			},
61			}
62			res, err := Do(req)
63			assert.Nil(t, err)
64			assert.NotNil(t, res)
65			assert.Equal(t, 200, res.StatusCode)
66			assert.Equal(t, "text/html; charset=utf-8", res.Headers["Content-Type"])
67			}
68
69			type errorReader struct {
70			}
71
72			func (r *errorReader) Read(p []byte) (n int, err error) {
73			err = errors.New("read failed")
74			return
75			}
76
77			func TestDoWithError(t *testing.T) {
78			originNewRequest := newRequest
79			defer func() { newRequest = originNewRequest }()
80
81			// case 1: mock new http request failed
82			newRequest = func(method, url string, body io.Reader) (*http.Request, error) {
83			return nil, errors.New("new http request failed")
84			}
85
86			req := &Request{
87			Method: "POST",
88			Protocol: "http",
89			Host: "www.aliyun.com",
90			Path: "/",
91			Form: map[string]string{
92			"URL": "HI",
93			},
94			Headers: map[string]string{
95			"Accept-Language": "zh",
96			},
97			}
98			_, err := Do(req)
99			assert.EqualError(t, err, "new http request failed")
100
101			// reset new request
102			newRequest = originNewRequest
103
104			// case 2: server error
105			originDo := hookDo
106			defer func() { hookDo = originDo }()
107			hookDo = func(fn do) do {
108			return func(req http.Request) (res http.Response, err error) {
109			err = errors.New("mock server error")
110			return
111			}
112			}
113			_, err = Do(req)
114			assert.EqualError(t, err, "mock server error")
115
116			// case 4: mock read response error
117			hookDo = func(fn do) do {
118			return func(req http.Request) (res http.Response, err error) {
119			res = &http.Response{
120			Proto: "HTTP/1.1",
121			ProtoMajor: 1,
122			ProtoMinor: 1,
123			Header: map[string][]string{},
124			StatusCode: 200,
125			Status: "200 " + http.StatusText(200),
126			}
127			res.Body = ioutil.NopCloser(&errorReader{})
128			return
129			}
130			}
131
132			_, err = Do(req)
133			assert.EqualError(t, err, "read failed")
134			}
135
136			func TestDoWithProxy(t *testing.T) {
137			req := &Request{
138			Method: "POST",
139			Protocol: "http",
140			Host: "www.aliyun.com",
141			Path: "/",
142			Form: map[string]string{
143			"URL": "HI",
144			},
145			Headers: map[string]string{
146			"Accept-Language": "zh",
147			},
148			Proxy: "http://localhost:9999/",
149			}
150			_, err := Do(req)
151			assert.Contains(t, err.Error(), "proxyconnect tcp: dial tcp")
152			assert.Contains(t, err.Error(), "connect: connection refused")
153
154			// invalid proxy url
155			req.Proxy = string([]byte{0x7f})
156			_, err = Do(req)
157			assert.Contains(t, err.Error(), "net/url: invalid control character in URL")
158			}
159
160			func TestDoWithConnectTimeout(t *testing.T) {
161			req := &Request{
162			Method: "POST",
163			Protocol: "http",
164			Host: "www.aliyun.com",
165			Path: "/",
166			Form: map[string]string{
167			"URL": "HI",
168			},
169			Headers: map[string]string{
170			"Accept-Language": "zh",
171			},
172			ConnectTimeout: 1 * time.Nanosecond,
173			}
174			_, err := Do(req)
175			assert.Contains(t, err.Error(), "dial tcp: ")
176			assert.Contains(t, err.Error(), "i/o timeout")
177			}
178
179			func TestDoWithReadTimeout(t *testing.T) {
180			req := &Request{
181			Method: "POST",
182			Protocol: "http",
183			Host: "www.aliyun.com",
184			Path: "/",
185			ReadTimeout: 1 * time.Nanosecond,
186			}
187			_, err := Do(req)
188			assert.Contains(t, err.Error(), "(Client.Timeout exceeded while awaiting headers)")
189			}
190

aliyun / credentials-go

GitHub Access Token became invalid

Push — master ( b5116a...3bd38f )

http.TestDoWithError B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like