Conditions | 1 |
Total Lines | 71 |
Code Lines | 50 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package providers |
||
109 | func TestProfileCredentialsProvider_getCredentialsProvider(t *testing.T) { |
||
110 | provider := NewProfileCredentialsProviderBuilder().WithProfileName("custom").Build() |
||
111 | _, err := provider.getCredentialsProvider(ini.Empty()) |
||
112 | assert.NotNil(t, err) |
||
113 | assert.EqualError(t, err, "ERROR: Can not load sectionsection \"custom\" does not exist") |
||
114 | |||
115 | file, err := ini.Load([]byte(inistr)) |
||
116 | assert.Nil(t, err) |
||
117 | assert.NotNil(t, file) |
||
118 | |||
119 | // no type |
||
120 | provider = NewProfileCredentialsProviderBuilder().WithProfileName("notype").Build() |
||
121 | _, err = provider.getCredentialsProvider(file) |
||
122 | assert.NotNil(t, err) |
||
123 | assert.EqualError(t, err, "ERROR: Can not find credential typeerror when getting key of section \"notype\": key \"type\" not exists") |
||
124 | |||
125 | // no ak |
||
126 | provider = NewProfileCredentialsProviderBuilder().WithProfileName("noak").Build() |
||
127 | _, err = provider.getCredentialsProvider(file) |
||
128 | assert.NotNil(t, err) |
||
129 | assert.EqualError(t, err, "ERROR: Failed to get value") |
||
130 | |||
131 | // value is empty |
||
132 | provider = NewProfileCredentialsProviderBuilder().WithProfileName("emptyak").Build() |
||
133 | _, err = provider.getCredentialsProvider(file) |
||
134 | assert.NotNil(t, err) |
||
135 | assert.EqualError(t, err, "ERROR: Value can't be empty") |
||
136 | |||
137 | // static ak provider |
||
138 | provider = NewProfileCredentialsProviderBuilder().Build() |
||
139 | cp, err := provider.getCredentialsProvider(file) |
||
140 | assert.Nil(t, err) |
||
141 | akcp, ok := cp.(*StaticAKCredentialsProvider) |
||
142 | assert.True(t, ok) |
||
143 | cc, err := akcp.GetCredentials() |
||
144 | assert.Nil(t, err) |
||
145 | assert.Equal(t, &Credentials{AccessKeyId: "foo", AccessKeySecret: "bar", SecurityToken: "", ProviderName: "static_ak"}, cc) |
||
146 | |||
147 | // ecs_ram_role without rolename |
||
148 | provider = NewProfileCredentialsProviderBuilder().WithProfileName("noecs").Build() |
||
149 | _, err = provider.getCredentialsProvider(file) |
||
150 | assert.EqualError(t, err, "ERROR: Failed to get value") |
||
151 | |||
152 | // ecs_ram_role with rolename |
||
153 | provider = NewProfileCredentialsProviderBuilder().WithProfileName("ecs").Build() |
||
154 | cp, err = provider.getCredentialsProvider(file) |
||
155 | assert.Nil(t, err) |
||
156 | _, ok = cp.(*ECSRAMRoleCredentialsProvider) |
||
157 | assert.True(t, ok) |
||
158 | |||
159 | // ram role arn without keys |
||
160 | provider = NewProfileCredentialsProviderBuilder().WithProfileName("noram").Build() |
||
161 | _, err = provider.getCredentialsProvider(file) |
||
162 | assert.EqualError(t, err, "ERROR: Failed to get value") |
||
163 | |||
164 | // ram role arn without values |
||
165 | provider = NewProfileCredentialsProviderBuilder().WithProfileName("emptyram").Build() |
||
166 | _, err = provider.getCredentialsProvider(file) |
||
167 | assert.EqualError(t, err, "ERROR: Value can't be empty") |
||
168 | |||
169 | // normal ram role arn |
||
170 | provider = NewProfileCredentialsProviderBuilder().WithProfileName("ram").Build() |
||
171 | cp, err = provider.getCredentialsProvider(file) |
||
172 | assert.Nil(t, err) |
||
173 | _, ok = cp.(*RAMRoleARNCredentialsProvider) |
||
174 | assert.True(t, ok) |
||
175 | |||
176 | // unsupported type |
||
177 | provider = NewProfileCredentialsProviderBuilder().WithProfileName("error_type").Build() |
||
178 | _, err = provider.getCredentialsProvider(file) |
||
179 | assert.EqualError(t, err, "ERROR: Failed to get credential") |
||
180 | } |
||
233 |