Conditions | 1 |
Total Lines | 82 |
Code Lines | 61 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package providers |
||
114 | func TestProfileCredentialsProvider_getCredentialsProvider(t *testing.T) { |
||
115 | provider, err := NewProfileCredentialsProviderBuilder().WithProfileName("custom").Build() |
||
116 | assert.Nil(t, err) |
||
117 | _, err = provider.getCredentialsProvider(ini.Empty()) |
||
118 | assert.NotNil(t, err) |
||
119 | assert.EqualError(t, err, "ERROR: Can not load sectionsection \"custom\" does not exist") |
||
120 | |||
121 | file, err := ini.Load([]byte(inistr)) |
||
122 | assert.Nil(t, err) |
||
123 | assert.NotNil(t, file) |
||
124 | |||
125 | // no type |
||
126 | provider, err = NewProfileCredentialsProviderBuilder().WithProfileName("notype").Build() |
||
127 | assert.Nil(t, err) |
||
128 | _, err = provider.getCredentialsProvider(file) |
||
129 | assert.NotNil(t, err) |
||
130 | assert.EqualError(t, err, "ERROR: Can not find credential typeerror when getting key of section \"notype\": key \"type\" not exists") |
||
131 | |||
132 | // no ak |
||
133 | provider, err = NewProfileCredentialsProviderBuilder().WithProfileName("noak").Build() |
||
134 | assert.Nil(t, err) |
||
135 | _, err = provider.getCredentialsProvider(file) |
||
136 | assert.NotNil(t, err) |
||
137 | assert.EqualError(t, err, "ERROR: Failed to get value") |
||
138 | |||
139 | // value is empty |
||
140 | provider, err = NewProfileCredentialsProviderBuilder().WithProfileName("emptyak").Build() |
||
141 | assert.Nil(t, err) |
||
142 | _, err = provider.getCredentialsProvider(file) |
||
143 | assert.NotNil(t, err) |
||
144 | assert.EqualError(t, err, "ERROR: Value can't be empty") |
||
145 | |||
146 | // static ak provider |
||
147 | provider, err = NewProfileCredentialsProviderBuilder().Build() |
||
148 | assert.Nil(t, err) |
||
149 | cp, err := provider.getCredentialsProvider(file) |
||
150 | assert.Nil(t, err) |
||
151 | akcp, ok := cp.(*StaticAKCredentialsProvider) |
||
152 | assert.True(t, ok) |
||
153 | cc, err := akcp.GetCredentials() |
||
154 | assert.Nil(t, err) |
||
155 | assert.Equal(t, &Credentials{AccessKeyId: "foo", AccessKeySecret: "bar", SecurityToken: "", ProviderName: "static_ak"}, cc) |
||
156 | |||
157 | // ecs_ram_role without rolename |
||
158 | provider, err = NewProfileCredentialsProviderBuilder().WithProfileName("noecs").Build() |
||
159 | assert.Nil(t, err) |
||
160 | _, err = provider.getCredentialsProvider(file) |
||
161 | assert.EqualError(t, err, "ERROR: Failed to get value") |
||
162 | |||
163 | // ecs_ram_role with rolename |
||
164 | provider, err = NewProfileCredentialsProviderBuilder().WithProfileName("ecs").Build() |
||
165 | assert.Nil(t, err) |
||
166 | cp, err = provider.getCredentialsProvider(file) |
||
167 | assert.Nil(t, err) |
||
168 | _, ok = cp.(*ECSRAMRoleCredentialsProvider) |
||
169 | assert.True(t, ok) |
||
170 | |||
171 | // ram role arn without keys |
||
172 | provider, err = NewProfileCredentialsProviderBuilder().WithProfileName("noram").Build() |
||
173 | assert.Nil(t, err) |
||
174 | _, err = provider.getCredentialsProvider(file) |
||
175 | assert.EqualError(t, err, "ERROR: Failed to get value") |
||
176 | |||
177 | // ram role arn without values |
||
178 | provider, err = NewProfileCredentialsProviderBuilder().WithProfileName("emptyram").Build() |
||
179 | assert.Nil(t, err) |
||
180 | _, err = provider.getCredentialsProvider(file) |
||
181 | assert.EqualError(t, err, "ERROR: Value can't be empty") |
||
182 | |||
183 | // normal ram role arn |
||
184 | provider, err = NewProfileCredentialsProviderBuilder().WithProfileName("ram").Build() |
||
185 | assert.Nil(t, err) |
||
186 | cp, err = provider.getCredentialsProvider(file) |
||
187 | assert.Nil(t, err) |
||
188 | _, ok = cp.(*RAMRoleARNCredentialsProvider) |
||
189 | assert.True(t, ok) |
||
190 | |||
191 | // unsupported type |
||
192 | provider, err = NewProfileCredentialsProviderBuilder().WithProfileName("error_type").Build() |
||
193 | assert.Nil(t, err) |
||
194 | _, err = provider.getCredentialsProvider(file) |
||
195 | assert.EqualError(t, err, "ERROR: Failed to get credential") |
||
196 | } |
||
283 |