Conditions | 1 |
Total Lines | 58 |
Code Lines | 43 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package providers |
||
11 | func TestDefaultCredentialsProvider(t *testing.T) { |
||
12 | provider := NewDefaultCredentialsProvider() |
||
13 | assert.NotNil(t, provider) |
||
14 | assert.Len(t, provider.providerChain, 3) |
||
15 | _, ok := provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
16 | assert.True(t, ok) |
||
17 | |||
18 | _, ok = provider.providerChain[1].(*CLIProfileCredentialsProvider) |
||
19 | assert.True(t, ok) |
||
20 | |||
21 | _, ok = provider.providerChain[2].(*ProfileCredentialsProvider) |
||
22 | assert.True(t, ok) |
||
23 | |||
24 | // Add oidc provider |
||
25 | rollback := utils.Memory("ALIBABA_CLOUD_OIDC_TOKEN_FILE", |
||
26 | "ALIBABA_CLOUD_OIDC_PROVIDER_ARN", |
||
27 | "ALIBABA_CLOUD_ROLE_ARN", |
||
28 | "ALIBABA_CLOUD_ECS_METADATA") |
||
29 | |||
30 | defer rollback() |
||
31 | os.Setenv("ALIBABA_CLOUD_OIDC_TOKEN_FILE", "/path/to/oidc.token") |
||
32 | os.Setenv("ALIBABA_CLOUD_OIDC_PROVIDER_ARN", "oidcproviderarn") |
||
33 | os.Setenv("ALIBABA_CLOUD_ROLE_ARN", "rolearn") |
||
34 | |||
35 | provider = NewDefaultCredentialsProvider() |
||
36 | assert.NotNil(t, provider) |
||
37 | assert.Len(t, provider.providerChain, 4) |
||
38 | _, ok = provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
39 | assert.True(t, ok) |
||
40 | |||
41 | _, ok = provider.providerChain[1].(*OIDCCredentialsProvider) |
||
42 | assert.True(t, ok) |
||
43 | |||
44 | _, ok = provider.providerChain[2].(*CLIProfileCredentialsProvider) |
||
45 | assert.True(t, ok) |
||
46 | |||
47 | _, ok = provider.providerChain[3].(*ProfileCredentialsProvider) |
||
48 | assert.True(t, ok) |
||
49 | |||
50 | // Add ecs ram role |
||
51 | os.Setenv("ALIBABA_CLOUD_ECS_METADATA", "rolename") |
||
52 | provider = NewDefaultCredentialsProvider() |
||
53 | assert.NotNil(t, provider) |
||
54 | assert.Len(t, provider.providerChain, 5) |
||
55 | _, ok = provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
56 | assert.True(t, ok) |
||
57 | |||
58 | _, ok = provider.providerChain[1].(*OIDCCredentialsProvider) |
||
59 | assert.True(t, ok) |
||
60 | |||
61 | _, ok = provider.providerChain[2].(*CLIProfileCredentialsProvider) |
||
62 | assert.True(t, ok) |
||
63 | |||
64 | _, ok = provider.providerChain[3].(*ProfileCredentialsProvider) |
||
65 | assert.True(t, ok) |
||
66 | |||
67 | _, ok = provider.providerChain[4].(*ECSRAMRoleCredentialsProvider) |
||
68 | assert.True(t, ok) |
||
69 | } |
||
103 |