Conditions | 1 |
Total Lines | 88 |
Code Lines | 64 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package providers |
||
13 | func TestDefaultCredentialsProvider(t *testing.T) { |
||
14 | provider := NewDefaultCredentialsProvider() |
||
15 | assert.NotNil(t, provider) |
||
16 | assert.Len(t, provider.providerChain, 4) |
||
17 | _, ok := provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
18 | assert.True(t, ok) |
||
19 | |||
20 | _, ok = provider.providerChain[1].(*CLIProfileCredentialsProvider) |
||
21 | assert.True(t, ok) |
||
22 | |||
23 | _, ok = provider.providerChain[2].(*ProfileCredentialsProvider) |
||
24 | assert.True(t, ok) |
||
25 | |||
26 | _, ok = provider.providerChain[3].(*ECSRAMRoleCredentialsProvider) |
||
27 | assert.True(t, ok) |
||
28 | |||
29 | // Add oidc provider |
||
30 | rollback := utils.Memory("ALIBABA_CLOUD_OIDC_TOKEN_FILE", |
||
31 | "ALIBABA_CLOUD_OIDC_PROVIDER_ARN", |
||
32 | "ALIBABA_CLOUD_ROLE_ARN", |
||
33 | "ALIBABA_CLOUD_ECS_METADATA", |
||
34 | "ALIBABA_CLOUD_CREDENTIALS_URI") |
||
35 | |||
36 | defer rollback() |
||
37 | os.Setenv("ALIBABA_CLOUD_OIDC_TOKEN_FILE", "/path/to/oidc.token") |
||
38 | os.Setenv("ALIBABA_CLOUD_OIDC_PROVIDER_ARN", "oidcproviderarn") |
||
39 | os.Setenv("ALIBABA_CLOUD_ROLE_ARN", "rolearn") |
||
40 | |||
41 | provider = NewDefaultCredentialsProvider() |
||
42 | assert.NotNil(t, provider) |
||
43 | assert.Len(t, provider.providerChain, 5) |
||
44 | _, ok = provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
45 | assert.True(t, ok) |
||
46 | |||
47 | _, ok = provider.providerChain[1].(*OIDCCredentialsProvider) |
||
48 | assert.True(t, ok) |
||
49 | |||
50 | _, ok = provider.providerChain[2].(*CLIProfileCredentialsProvider) |
||
51 | assert.True(t, ok) |
||
52 | |||
53 | _, ok = provider.providerChain[3].(*ProfileCredentialsProvider) |
||
54 | assert.True(t, ok) |
||
55 | |||
56 | _, ok = provider.providerChain[4].(*ECSRAMRoleCredentialsProvider) |
||
57 | assert.True(t, ok) |
||
58 | |||
59 | // Add ecs ram role name |
||
60 | os.Setenv("ALIBABA_CLOUD_ECS_METADATA", "rolename") |
||
61 | provider = NewDefaultCredentialsProvider() |
||
62 | assert.NotNil(t, provider) |
||
63 | assert.Len(t, provider.providerChain, 5) |
||
64 | _, ok = provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
65 | assert.True(t, ok) |
||
66 | |||
67 | _, ok = provider.providerChain[1].(*OIDCCredentialsProvider) |
||
68 | assert.True(t, ok) |
||
69 | |||
70 | _, ok = provider.providerChain[2].(*CLIProfileCredentialsProvider) |
||
71 | assert.True(t, ok) |
||
72 | |||
73 | _, ok = provider.providerChain[3].(*ProfileCredentialsProvider) |
||
74 | assert.True(t, ok) |
||
75 | |||
76 | _, ok = provider.providerChain[4].(*ECSRAMRoleCredentialsProvider) |
||
77 | assert.True(t, ok) |
||
78 | |||
79 | // Add ecs ram role |
||
80 | os.Setenv("ALIBABA_CLOUD_CREDENTIALS_URI", "http://") |
||
81 | provider = NewDefaultCredentialsProvider() |
||
82 | assert.NotNil(t, provider) |
||
83 | assert.Len(t, provider.providerChain, 6) |
||
84 | _, ok = provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
85 | assert.True(t, ok) |
||
86 | |||
87 | _, ok = provider.providerChain[1].(*OIDCCredentialsProvider) |
||
88 | assert.True(t, ok) |
||
89 | |||
90 | _, ok = provider.providerChain[2].(*CLIProfileCredentialsProvider) |
||
91 | assert.True(t, ok) |
||
92 | |||
93 | _, ok = provider.providerChain[3].(*ProfileCredentialsProvider) |
||
94 | assert.True(t, ok) |
||
95 | |||
96 | _, ok = provider.providerChain[4].(*ECSRAMRoleCredentialsProvider) |
||
97 | assert.True(t, ok) |
||
98 | |||
99 | _, ok = provider.providerChain[5].(*URLCredentialsProvider) |
||
100 | assert.True(t, ok) |
||
101 | } |
||
159 |