Conditions | 1 |
Total Lines | 95 |
Code Lines | 65 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package providers |
||
70 | func TestCLIProfileCredentialsProvider_getCredentialsProvider(t *testing.T) { |
||
71 | conf := &configuration{ |
||
72 | Current: "AK", |
||
73 | Profiles: []*profile{ |
||
74 | { |
||
75 | Mode: "AK", |
||
76 | Name: "AK", |
||
77 | AccessKeyID: "akid", |
||
78 | AccessKeySecret: "secret", |
||
79 | }, |
||
80 | { |
||
81 | Mode: "RamRoleArn", |
||
82 | Name: "RamRoleArn", |
||
83 | AccessKeyID: "akid", |
||
84 | AccessKeySecret: "secret", |
||
85 | RoleArn: "arn", |
||
86 | }, |
||
87 | { |
||
88 | Mode: "RamRoleArn", |
||
89 | Name: "Invalid_RamRoleArn", |
||
90 | }, |
||
91 | { |
||
92 | Mode: "EcsRamRole", |
||
93 | Name: "EcsRamRole", |
||
94 | RoleName: "rolename", |
||
95 | }, |
||
96 | { |
||
97 | Mode: "OIDC", |
||
98 | Name: "OIDC", |
||
99 | RoleArn: "role_arn", |
||
100 | OIDCTokenFile: "path/to/oidc/file", |
||
101 | OIDCProviderARN: "provider_arn", |
||
102 | }, |
||
103 | { |
||
104 | Mode: "ChainableRamRoleArn", |
||
105 | Name: "ChainableRamRoleArn", |
||
106 | RoleArn: "arn", |
||
107 | SourceProfile: "AK", |
||
108 | }, |
||
109 | { |
||
110 | Mode: "ChainableRamRoleArn", |
||
111 | Name: "ChainableRamRoleArn2", |
||
112 | SourceProfile: "InvalidSource", |
||
113 | }, |
||
114 | { |
||
115 | Mode: "Unsupported", |
||
116 | Name: "Unsupported", |
||
117 | }, |
||
118 | }, |
||
119 | } |
||
120 | |||
121 | provider := NewCLIProfileCredentialsProviderBuilder().Build() |
||
122 | _, err := provider.getCredentialsProvider(conf, "inexist") |
||
123 | assert.EqualError(t, err, "unable to get profile with 'inexist'") |
||
124 | |||
125 | // AK |
||
126 | cp, err := provider.getCredentialsProvider(conf, "AK") |
||
127 | assert.Nil(t, err) |
||
128 | akcp, ok := cp.(*StaticAKCredentialsProvider) |
||
129 | assert.True(t, ok) |
||
130 | cc, err := akcp.GetCredentials() |
||
131 | assert.Nil(t, err) |
||
132 | assert.Equal(t, cc, &Credentials{AccessKeyId: "akid", AccessKeySecret: "secret", SecurityToken: "", ProviderName: "static_ak"}) |
||
133 | // RamRoleArn |
||
134 | cp, err = provider.getCredentialsProvider(conf, "RamRoleArn") |
||
135 | assert.Nil(t, err) |
||
136 | _, ok = cp.(*RAMRoleARNCredentialsProvider) |
||
137 | assert.True(t, ok) |
||
138 | // RamRoleArn invalid ak |
||
139 | _, err = provider.getCredentialsProvider(conf, "Invalid_RamRoleArn") |
||
140 | assert.EqualError(t, err, "the access key id is empty") |
||
141 | // EcsRamRole |
||
142 | cp, err = provider.getCredentialsProvider(conf, "EcsRamRole") |
||
143 | assert.Nil(t, err) |
||
144 | _, ok = cp.(*ECSRAMRoleCredentialsProvider) |
||
145 | assert.True(t, ok) |
||
146 | // OIDC |
||
147 | cp, err = provider.getCredentialsProvider(conf, "OIDC") |
||
148 | assert.Nil(t, err) |
||
149 | _, ok = cp.(*OIDCCredentialsProvider) |
||
150 | assert.True(t, ok) |
||
151 | |||
152 | // ChainableRamRoleArn |
||
153 | cp, err = provider.getCredentialsProvider(conf, "ChainableRamRoleArn") |
||
154 | assert.Nil(t, err) |
||
155 | _, ok = cp.(*RAMRoleARNCredentialsProvider) |
||
156 | assert.True(t, ok) |
||
157 | |||
158 | // ChainableRamRoleArn with invalid source profile |
||
159 | _, err = provider.getCredentialsProvider(conf, "ChainableRamRoleArn2") |
||
160 | assert.EqualError(t, err, "get source profile failed: unable to get profile with 'InvalidSource'") |
||
161 | |||
162 | // Unsupported |
||
163 | _, err = provider.getCredentialsProvider(conf, "Unsupported") |
||
164 | assert.EqualError(t, err, "unsupported profile mode 'Unsupported'") |
||
165 | } |
||
206 |