Conditions | 1 |
Total Lines | 88 |
Code Lines | 64 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package providers |
||
14 | func TestDefaultCredentialsProvider(t *testing.T) { |
||
15 | provider := NewDefaultCredentialsProvider() |
||
16 | assert.NotNil(t, provider) |
||
17 | assert.Len(t, provider.providerChain, 4) |
||
18 | _, ok := provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
19 | assert.True(t, ok) |
||
20 | |||
21 | _, ok = provider.providerChain[1].(*CLIProfileCredentialsProvider) |
||
22 | assert.True(t, ok) |
||
23 | |||
24 | _, ok = provider.providerChain[2].(*ProfileCredentialsProvider) |
||
25 | assert.True(t, ok) |
||
26 | |||
27 | _, ok = provider.providerChain[3].(*ECSRAMRoleCredentialsProvider) |
||
28 | assert.True(t, ok) |
||
29 | |||
30 | // Add oidc provider |
||
31 | rollback := utils.Memory("ALIBABA_CLOUD_OIDC_TOKEN_FILE", |
||
32 | "ALIBABA_CLOUD_OIDC_PROVIDER_ARN", |
||
33 | "ALIBABA_CLOUD_ROLE_ARN", |
||
34 | "ALIBABA_CLOUD_ECS_METADATA", |
||
35 | "ALIBABA_CLOUD_CREDENTIALS_URI") |
||
36 | |||
37 | defer rollback() |
||
38 | os.Setenv("ALIBABA_CLOUD_OIDC_TOKEN_FILE", "/path/to/oidc.token") |
||
39 | os.Setenv("ALIBABA_CLOUD_OIDC_PROVIDER_ARN", "oidcproviderarn") |
||
40 | os.Setenv("ALIBABA_CLOUD_ROLE_ARN", "rolearn") |
||
41 | |||
42 | provider = NewDefaultCredentialsProvider() |
||
43 | assert.NotNil(t, provider) |
||
44 | assert.Len(t, provider.providerChain, 5) |
||
45 | _, ok = provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
46 | assert.True(t, ok) |
||
47 | |||
48 | _, ok = provider.providerChain[1].(*OIDCCredentialsProvider) |
||
49 | assert.True(t, ok) |
||
50 | |||
51 | _, ok = provider.providerChain[2].(*CLIProfileCredentialsProvider) |
||
52 | assert.True(t, ok) |
||
53 | |||
54 | _, ok = provider.providerChain[3].(*ProfileCredentialsProvider) |
||
55 | assert.True(t, ok) |
||
56 | |||
57 | _, ok = provider.providerChain[4].(*ECSRAMRoleCredentialsProvider) |
||
58 | assert.True(t, ok) |
||
59 | |||
60 | // Add ecs ram role name |
||
61 | os.Setenv("ALIBABA_CLOUD_ECS_METADATA", "rolename") |
||
62 | provider = NewDefaultCredentialsProvider() |
||
63 | assert.NotNil(t, provider) |
||
64 | assert.Len(t, provider.providerChain, 5) |
||
65 | _, ok = provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
66 | assert.True(t, ok) |
||
67 | |||
68 | _, ok = provider.providerChain[1].(*OIDCCredentialsProvider) |
||
69 | assert.True(t, ok) |
||
70 | |||
71 | _, ok = provider.providerChain[2].(*CLIProfileCredentialsProvider) |
||
72 | assert.True(t, ok) |
||
73 | |||
74 | _, ok = provider.providerChain[3].(*ProfileCredentialsProvider) |
||
75 | assert.True(t, ok) |
||
76 | |||
77 | _, ok = provider.providerChain[4].(*ECSRAMRoleCredentialsProvider) |
||
78 | assert.True(t, ok) |
||
79 | |||
80 | // Add ecs ram role |
||
81 | os.Setenv("ALIBABA_CLOUD_CREDENTIALS_URI", "http://") |
||
82 | provider = NewDefaultCredentialsProvider() |
||
83 | assert.NotNil(t, provider) |
||
84 | assert.Len(t, provider.providerChain, 6) |
||
85 | _, ok = provider.providerChain[0].(*EnvironmentVariableCredentialsProvider) |
||
86 | assert.True(t, ok) |
||
87 | |||
88 | _, ok = provider.providerChain[1].(*OIDCCredentialsProvider) |
||
89 | assert.True(t, ok) |
||
90 | |||
91 | _, ok = provider.providerChain[2].(*CLIProfileCredentialsProvider) |
||
92 | assert.True(t, ok) |
||
93 | |||
94 | _, ok = provider.providerChain[3].(*ProfileCredentialsProvider) |
||
95 | assert.True(t, ok) |
||
96 | |||
97 | _, ok = provider.providerChain[4].(*ECSRAMRoleCredentialsProvider) |
||
98 | assert.True(t, ok) |
||
99 | |||
100 | _, ok = provider.providerChain[5].(*URLCredentialsProvider) |
||
101 | assert.True(t, ok) |
||
102 | } |
||
199 |