Conditions | 1 |
Total Lines | 133 |
Code Lines | 96 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | package providers |
||
87 | func TestCLIProfileCredentialsProvider_getCredentialsProvider(t *testing.T) { |
||
88 | conf := &configuration{ |
||
89 | Current: "AK", |
||
90 | Profiles: []*profile{ |
||
91 | { |
||
92 | Mode: "AK", |
||
93 | Name: "AK", |
||
94 | AccessKeyID: "akid", |
||
95 | AccessKeySecret: "secret", |
||
96 | }, |
||
97 | { |
||
98 | Mode: "StsToken", |
||
99 | Name: "StsToken", |
||
100 | AccessKeyID: "access_key_id", |
||
101 | AccessKeySecret: "access_key_secret", |
||
102 | SecurityToken: "sts_token", |
||
103 | }, |
||
104 | { |
||
105 | Mode: "RamRoleArn", |
||
106 | Name: "RamRoleArn", |
||
107 | AccessKeyID: "akid", |
||
108 | AccessKeySecret: "secret", |
||
109 | RoleArn: "arn", |
||
110 | StsRegion: "cn-hangzhou", |
||
111 | EnableVpc: true, |
||
112 | Policy: "policy", |
||
113 | ExternalId: "externalId", |
||
114 | }, |
||
115 | { |
||
116 | Mode: "RamRoleArn", |
||
117 | Name: "Invalid_RamRoleArn", |
||
118 | }, |
||
119 | { |
||
120 | Mode: "EcsRamRole", |
||
121 | Name: "EcsRamRole", |
||
122 | RoleName: "rolename", |
||
123 | }, |
||
124 | { |
||
125 | Mode: "OIDC", |
||
126 | Name: "OIDC", |
||
127 | RoleArn: "role_arn", |
||
128 | OIDCTokenFile: "path/to/oidc/file", |
||
129 | OIDCProviderARN: "provider_arn", |
||
130 | StsRegion: "cn-hangzhou", |
||
131 | EnableVpc: true, |
||
132 | Policy: "policy", |
||
133 | }, |
||
134 | { |
||
135 | Mode: "ChainableRamRoleArn", |
||
136 | Name: "ChainableRamRoleArn", |
||
137 | RoleArn: "arn", |
||
138 | SourceProfile: "AK", |
||
139 | }, |
||
140 | { |
||
141 | Mode: "ChainableRamRoleArn", |
||
142 | Name: "ChainableRamRoleArn2", |
||
143 | SourceProfile: "InvalidSource", |
||
144 | }, |
||
145 | { |
||
146 | Name: "CloudSSO", |
||
147 | Mode: "CloudSSO", |
||
148 | SignInUrl: "url", |
||
149 | AccessToken: "token", |
||
150 | AccessTokenExpire: time.Now().Unix() + 1000, |
||
151 | AccessConfig: "config", |
||
152 | AccountId: "uid", |
||
153 | }, |
||
154 | { |
||
155 | Mode: "Unsupported", |
||
156 | Name: "Unsupported", |
||
157 | }, |
||
158 | }, |
||
159 | } |
||
160 | |||
161 | provider, err := NewCLIProfileCredentialsProviderBuilder().Build() |
||
162 | assert.Nil(t, err) |
||
163 | _, err = provider.getCredentialsProvider(conf, "inexist") |
||
164 | assert.EqualError(t, err, "unable to get profile with 'inexist'") |
||
165 | |||
166 | // AK |
||
167 | cp, err := provider.getCredentialsProvider(conf, "AK") |
||
168 | assert.Nil(t, err) |
||
169 | akcp, ok := cp.(*StaticAKCredentialsProvider) |
||
170 | assert.True(t, ok) |
||
171 | cc, err := akcp.GetCredentials() |
||
172 | assert.Nil(t, err) |
||
173 | assert.Equal(t, cc, &Credentials{AccessKeyId: "akid", AccessKeySecret: "secret", SecurityToken: "", ProviderName: "static_ak"}) |
||
174 | // STS |
||
175 | cp, err = provider.getCredentialsProvider(conf, "StsToken") |
||
176 | assert.Nil(t, err) |
||
177 | stscp, ok := cp.(*StaticSTSCredentialsProvider) |
||
178 | assert.True(t, ok) |
||
179 | cc, err = stscp.GetCredentials() |
||
180 | assert.Nil(t, err) |
||
181 | assert.Equal(t, cc, &Credentials{AccessKeyId: "access_key_id", AccessKeySecret: "access_key_secret", SecurityToken: "sts_token", ProviderName: "static_sts"}) |
||
182 | // RamRoleArn |
||
183 | cp, err = provider.getCredentialsProvider(conf, "RamRoleArn") |
||
184 | assert.Nil(t, err) |
||
185 | _, ok = cp.(*RAMRoleARNCredentialsProvider) |
||
186 | assert.True(t, ok) |
||
187 | // RamRoleArn invalid ak |
||
188 | _, err = provider.getCredentialsProvider(conf, "Invalid_RamRoleArn") |
||
189 | assert.EqualError(t, err, "the access key id is empty") |
||
190 | // EcsRamRole |
||
191 | cp, err = provider.getCredentialsProvider(conf, "EcsRamRole") |
||
192 | assert.Nil(t, err) |
||
193 | _, ok = cp.(*ECSRAMRoleCredentialsProvider) |
||
194 | assert.True(t, ok) |
||
195 | // OIDC |
||
196 | cp, err = provider.getCredentialsProvider(conf, "OIDC") |
||
197 | assert.Nil(t, err) |
||
198 | _, ok = cp.(*OIDCCredentialsProvider) |
||
199 | assert.True(t, ok) |
||
200 | |||
201 | // ChainableRamRoleArn |
||
202 | cp, err = provider.getCredentialsProvider(conf, "ChainableRamRoleArn") |
||
203 | assert.Nil(t, err) |
||
204 | _, ok = cp.(*RAMRoleARNCredentialsProvider) |
||
205 | assert.True(t, ok) |
||
206 | |||
207 | // CloudSSO |
||
208 | cp, err = provider.getCredentialsProvider(conf, "CloudSSO") |
||
209 | assert.Nil(t, err) |
||
210 | _, ok = cp.(*CloudSSOCredentialsProvider) |
||
211 | assert.True(t, ok) |
||
212 | |||
213 | // ChainableRamRoleArn with invalid source profile |
||
214 | _, err = provider.getCredentialsProvider(conf, "ChainableRamRoleArn2") |
||
215 | assert.EqualError(t, err, "get source profile failed: unable to get profile with 'InvalidSource'") |
||
216 | |||
217 | // Unsupported |
||
218 | _, err = provider.getCredentialsProvider(conf, "Unsupported") |
||
219 | assert.EqualError(t, err, "unsupported profile mode 'Unsupported'") |
||
220 | } |
||
312 |