Customer - Code Metrics - alhoqbani/smsa-webservice - Measure and Improve Code Quality continuously with Scrutinizer

Customer A
last analyzed 2018-05-01 14:52 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	368
Duplicated Lines	3.53 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	24
lcom	1
cbo	0
dl	13
loc	368
rs	10
c	0
b	0
f	0

24 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	13	13	1
A	prepareForShipment()	0	17	1
A	getName()	0	4	1
A	setName()	0	6	1
A	getMobile()	0	4	1
A	setMobile()	0	6	1
A	getAddressLine1()	0	4	1
A	setAddressLine1()	0	6	1
A	getCity()	0	4	1
A	setCity()	0	6	1
A	getCountry()	0	4	1
A	setCountry()	0	6	1
A	getAddressLine2()	0	4	1
A	setAddressLine2()	0	6	1
A	getZipCode()	0	4	1
A	setZipCode()	0	6	1
A	getPOBox()	0	4	1
A	setPOBox()	0	6	1
A	getTel1()	0	4	1
A	setTel1()	0	6	1
A	getTel2()	0	4	1
A	setTel2()	0	6	1
A	getEmail()	0	4	1
A	setEmail()	0	6	1

How to fix Duplicated Code

<?php

/*
 * This file is part of Smsa WebService package.
 * (c) Hamoud Alhoqbani <[email protected]>
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Alhoqbani\SmsaWebService\Models;

use Alhoqbani\SmsaWebService\Soap\Type\AddShip;
use Alhoqbani\SmsaWebService\Soap\Type\AddShipment;
use WsdlToPhp\PackageBase\AbstractStructBase;

class Customer
{

    /**
     * Customer Name.
     * Cannot be Null
     * Correspond to (cName)
     *
     * @var string
     */
    private $name;
    /**
     * Mobile number.
     * Must be at least 9 digits
     * Mandatory
     * Correspond to (cMobile)
     *
     * @var string
     */
    private $mobile;
    /**
     * Address Line 1.
     * Either of Address fields to be filled duly
     * Correspond to (cAddr1)
     *
     * @var string
     */
    private $addressLine1;
    /**
     * Destination City Name.
     * Required
     * Correspond to (cCity)
     *
     * @var string
     */
    private $city;
    /**
     * Country.
     * Required
     * Correspond to (Cntry)
     *
     * @var string
     */
    private $country;

    /** Optional Properties */

    /**
     * Address Line 2.
     * Either of Address fields to be filled duly
     * Correspond to (cAddr2)
     *
     * @var string
     */
    private $addressLine2;
    /**
     * Zip Code.
     * Optional
     * Correspond to (cZip)
     *
     * @var string
     */
    private $zipCode;
    /**
     * PO Box.
     * Optional
     * Correspond to (cPOBox)
     *
     * @var string
     */
    private $POBox;
    /**
     * Telephone 1.
     * Optional
     * Correspond to cTel1
     *
     * @var string
     */
    private $tel1;
    /**
     * Telephone 2.
     * Optional
     * Correspond to cTel2
     *
     * @var string
     */
    private $tel2;
    /**
     * Email Address.
     * Optional
     * Correspond to (cEmail)
     *
     * @var string
     */
    private $email;

    /**
     * Customer constructor.
     *
     * @param        $name
     * @param        $mobile
     * @param        $addressLine1
     * @param        $city
     * @param string $country
     */
    public function __construct(

        string $name,
        string $mobile,
        string $addressLine1,
        string $city,
        string $country = 'KSA'
    ) {
        $this->name = $name;
        $this->mobile = $mobile;
        $this->addressLine1 = $addressLine1;
        $this->city = $city;
        $this->country = $country;
    }

    /**
     * Add customer details to the shipment object.
     *
     * @param AddShipment|AddShip $shipment
     *
     * @return AddShipment|AddShip
     */
    public function prepareForShipment($shipment): AbstractStructBase
    {
        return $shipment
            // Required fields
            ->setCName($this->name)
            ->setCntry($this->country)
            ->setCCity($this->city)
            ->setCMobile($this->mobile)
            ->setCAddr1($this->addressLine1)
            // Optional fields
            ->setCAddr2($this->addressLine2 ?? '')
            ->setCZip($this->zipCode ?? '')
            ->setCPOBox($this->POBox ?? '')
            ->setCTel1($this->tel1 ?? '')
            ->setCTel2($this->tel2 ?? '')
            ->setCEmail($this->email ?? '');
    }

    /** **************************************************************************************************************
     *  Setters and Getters
     * **************************************************************************************************************/

    /**
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    /**
     * @param string $name
     *
     * @return Customer
     */
    public function setName(string $name): self
    {
        $this->name = $name;

        return $this;
    }

    /**
     * @return string
     */
    public function getMobile(): string
    {
        return $this->mobile;
    }

    /**
     * @param string $mobile
     *
     * @return Customer
     */
    public function setMobile(string $mobile): self
    {
        $this->mobile = $mobile;

        return $this;
    }

    /**
     * @return string
     */
    public function getAddressLine1(): string
    {
        return $this->addressLine1;
    }

    /**
     * @param string $addressLine1
     *
     * @return Customer
     */
    public function setAddressLine1(string $addressLine1): self
    {
        $this->addressLine1 = $addressLine1;

        return $this;
    }

    /**
     * @return string
     */
    public function getCity(): string
    {
        return $this->city;
    }

    /**
     * @param string $city
     *
     * @return Customer
     */
    public function setCity(string $city): self
    {
        $this->city = $city;

        return $this;
    }

    /**
     * @return string
     */
    public function getCountry(): string
    {
        return $this->country;
    }

    /**
     * @param string $country
     *
     * @return Customer
     */
    public function setCountry(string $country): self
    {
        $this->country = $country;

        return $this;
    }

    /**
     * @return string
     */
    public function getAddressLine2()
    {
        return $this->addressLine2;
    }

    /**
     * @param string $addressLine2
     *
     * @return Customer
     */
    public function setAddressLine2(string $addressLine2): self
    {
        $this->addressLine2 = $addressLine2;

        return $this;
    }

    /**
     * @return string
     */
    public function getZipCode(): string
    {
        return $this->zipCode;
    }

    /**
     * @param string $zipCode
     *
     * @return Customer
     */
    public function setZipCode(string $zipCode): self
    {
        $this->zipCode = $zipCode;

        return $this;
    }

    /**
     * @return string
     */
    public function getPOBox(): string
    {
        return $this->POBox;
    }

    /**
     * @param string $POBox
     *
     * @return Customer
     */
    public function setPOBox(string $POBox): self
    {
        $this->POBox = $POBox;

        return $this;
    }

    /**
     * @return string
     */
    public function getTel1(): string
    {
        return $this->tel1;
    }

    /**
     * @param string $tel1
     *
     * @return Customer
     */
    public function setTel1(string $tel1): self
    {
        $this->tel1 = $tel1;

        return $this;
    }

    /**
     * @return string
     */
    public function getTel2(): string
    {
        return $this->tel2;
    }

    /**
     * @param string $tel2
     *
     * @return Customer
     */
    public function setTel2(string $tel2): self
    {
        $this->tel2 = $tel2;

        return $this;
    }

    /**
     * @return string
     */
    public function getEmail(): string
    {
        return $this->email;
    }

    /**
     * @param string $email
     *
     * @return Customer
     */
    public function setEmail(string $email): self
    {
        $this->email = $email;

        return $this;
    }
}


1		<?php
2
3		/*
4		* This file is part of Smsa WebService package.
5		* (c) Hamoud Alhoqbani <[email protected]>
6		* For the full copyright and license information, please view the LICENSE
7		* file that was distributed with this source code.
8		*/
9
10		namespace Alhoqbani\SmsaWebService\Models;
11
12		use Alhoqbani\SmsaWebService\Soap\Type\AddShip;
13		use Alhoqbani\SmsaWebService\Soap\Type\AddShipment;
14		use WsdlToPhp\PackageBase\AbstractStructBase;
15
16		class Customer
17		{
18
19		/**
20		* Customer Name.
21		* Cannot be Null
22		* Correspond to (cName)
23		*
24		* @var string
25		*/
26		private $name;
27		/**
28		* Mobile number.
29		* Must be at least 9 digits
30		* Mandatory
31		* Correspond to (cMobile)
32		*
33		* @var string
34		*/
35		private $mobile;
36		/**
37		* Address Line 1.
38		* Either of Address fields to be filled duly
39		* Correspond to (cAddr1)
40		*
41		* @var string
42		*/
43		private $addressLine1;
44		/**
45		* Destination City Name.
46		* Required
47		* Correspond to (cCity)
48		*
49		* @var string
50		*/
51		private $city;
52		/**
53		* Country.
54		* Required
55		* Correspond to (Cntry)
56		*
57		* @var string
58		*/
59		private $country;
60
61		/** Optional Properties */
62
63		/**
64		* Address Line 2.
65		* Either of Address fields to be filled duly
66		* Correspond to (cAddr2)
67		*
68		* @var string
69		*/
70		private $addressLine2;
71		/**
72		* Zip Code.
73		* Optional
74		* Correspond to (cZip)
75		*
76		* @var string
77		*/
78		private $zipCode;
79		/**
80		* PO Box.
81		* Optional
82		* Correspond to (cPOBox)
83		*
84		* @var string
85		*/
86		private $POBox;
87		/**
88		* Telephone 1.
89		* Optional
90		* Correspond to cTel1
91		*
92		* @var string
93		*/
94		private $tel1;
95		/**
96		* Telephone 2.
97		* Optional
98		* Correspond to cTel2
99		*
100		* @var string
101		*/
102		private $tel2;
103		/**
104		* Email Address.
105		* Optional
106		* Correspond to (cEmail)
107		*
108		* @var string
109		*/
110		private $email;
111
112		/**
113		* Customer constructor.
114		*
115		* @param $name
116		* @param $mobile
117		* @param $addressLine1
118		* @param $city
119		* @param string $country
120		*/
121	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2018-04-30 22:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
122		string $name,
123		string $mobile,
124		string $addressLine1,
125		string $city,
126		string $country = 'KSA'
127		) {
128		$this->name = $name;
129		$this->mobile = $mobile;
130		$this->addressLine1 = $addressLine1;
131		$this->city = $city;
132		$this->country = $country;
133		}
134
135		/**
136		* Add customer details to the shipment object.
137		*
138		* @param AddShipment\|AddShip $shipment
139		*
140		* @return AddShipment\|AddShip
141		*/
142		public function prepareForShipment($shipment): AbstractStructBase
143		{
144		return $shipment
145		// Required fields
146		->setCName($this->name)
147		->setCntry($this->country)
148		->setCCity($this->city)
149		->setCMobile($this->mobile)
150		->setCAddr1($this->addressLine1)
151		// Optional fields
152		->setCAddr2($this->addressLine2 ?? '')
153		->setCZip($this->zipCode ?? '')
154		->setCPOBox($this->POBox ?? '')
155		->setCTel1($this->tel1 ?? '')
156		->setCTel2($this->tel2 ?? '')
157		->setCEmail($this->email ?? '');
158		}
159
160		/ ************************************************************************************************************
161		* Setters and Getters
162		* **************************************************************************************************************/
163
164		/**
165		* @return string
166		*/
167		public function getName(): string
168		{
169		return $this->name;
170		}
171
172		/**
173		* @param string $name
174		*
175		* @return Customer
176		*/
177		public function setName(string $name): self
178		{
179		$this->name = $name;
180
181		return $this;
182		}
183
184		/**
185		* @return string
186		*/
187		public function getMobile(): string
188		{
189		return $this->mobile;
190		}
191
192		/**
193		* @param string $mobile
194		*
195		* @return Customer
196		*/
197		public function setMobile(string $mobile): self
198		{
199		$this->mobile = $mobile;
200
201		return $this;
202		}
203
204		/**
205		* @return string
206		*/
207		public function getAddressLine1(): string
208		{
209		return $this->addressLine1;
210		}
211
212		/**
213		* @param string $addressLine1
214		*
215		* @return Customer
216		*/
217		public function setAddressLine1(string $addressLine1): self
218		{
219		$this->addressLine1 = $addressLine1;
220
221		return $this;
222		}
223
224		/**
225		* @return string
226		*/
227		public function getCity(): string
228		{
229		return $this->city;
230		}
231
232		/**
233		* @param string $city
234		*
235		* @return Customer
236		*/
237		public function setCity(string $city): self
238		{
239		$this->city = $city;
240
241		return $this;
242		}
243
244		/**
245		* @return string
246		*/
247		public function getCountry(): string
248		{
249		return $this->country;
250		}
251
252		/**
253		* @param string $country
254		*
255		* @return Customer
256		*/
257		public function setCountry(string $country): self
258		{
259		$this->country = $country;
260
261		return $this;
262		}
263
264		/**
265		* @return string
266		*/
267		public function getAddressLine2()
268		{
269		return $this->addressLine2;
270		}
271
272		/**
273		* @param string $addressLine2
274		*
275		* @return Customer
276		*/
277		public function setAddressLine2(string $addressLine2): self
278		{
279		$this->addressLine2 = $addressLine2;
280
281		return $this;
282		}
283
284		/**
285		* @return string
286		*/
287		public function getZipCode(): string
288		{
289		return $this->zipCode;
290		}
291
292		/**
293		* @param string $zipCode
294		*
295		* @return Customer
296		*/
297		public function setZipCode(string $zipCode): self
298		{
299		$this->zipCode = $zipCode;
300
301		return $this;
302		}
303
304		/**
305		* @return string
306		*/
307		public function getPOBox(): string
308		{
309		return $this->POBox;
310		}
311
312		/**
313		* @param string $POBox
314		*
315		* @return Customer
316		*/
317		public function setPOBox(string $POBox): self
318		{
319		$this->POBox = $POBox;
320
321		return $this;
322		}
323
324		/**
325		* @return string
326		*/
327		public function getTel1(): string
328		{
329		return $this->tel1;
330		}
331
332		/**
333		* @param string $tel1
334		*
335		* @return Customer
336		*/
337		public function setTel1(string $tel1): self
338		{
339		$this->tel1 = $tel1;
340
341		return $this;
342		}
343
344		/**
345		* @return string
346		*/
347		public function getTel2(): string
348		{
349		return $this->tel2;
350		}
351
352		/**
353		* @param string $tel2
354		*
355		* @return Customer
356		*/
357		public function setTel2(string $tel2): self
358		{
359		$this->tel2 = $tel2;
360
361		return $this;
362		}
363
364		/**
365		* @return string
366		*/
367		public function getEmail(): string
368		{
369		return $this->email;
370		}
371
372		/**
373		* @param string $email
374		*
375		* @return Customer
376		*/
377		public function setEmail(string $email): self
378		{
379		$this->email = $email;
380
381		return $this;
382		}
383		}
384

alhoqbani / smsa-webservice

Customer A last analyzed 2018-05-01 14:52 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

24 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Customer A
last analyzed 2018-05-01 14:52 UTC