Algorit\Synchronizer\Request\Config

Complexity

Total Complexity

11

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	8
Bugs	3	Features	2

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	load()	0	7	1
B	setup()	0	27	6
A	getConfig()	0	4	1
A	getAlias()	0	4	1
A	getEntities()	0	4	1

<?php namespace Algorit\Synchronizer\Request;

use Exception;
use Illuminate\Filesystem\Filesystem;
use Algorit\Synchronizer\Request\Contracts\SystemInterface;

class Config {
	
	/**
	 * The config array.
	 *
	 * @var array
	 */
	public $config;

	/**
	 * The aliases array.
	 *
	 * @var array
	 */
	public $aliases;

	/**
	 * The date config.
	 *
	 * @var array
	 */
	public $date;

	/**
	 * The resource instance name.
	 *
	 * @var array
	 */
	public $resourceInstance;

	/**
	 * The entities config.
	 *
	 * @var array
	 */
	protected $entities;

	/**
	 * The filesystem instance.
	 *
	 * @var \Illuminate\Filesystem\Filesystem
	 */
	protected $files;

	/**
	 * Create a new instance.
	 *
	 * @param  \Illuminate\Filesystem\Filesystem  $files
	 * @return void

Adding a @return annotation to constructors is generally not recommended as a constructor does not have a meaningful return value.

	 */
	public function __construct(Filesystem $files)
	{
		$this->files = $files;
	}

	protected function load($path)
	{
		$this->config  = $this->files->getRequire($path . '/config.php');

It seems like $this->files->getRequire($path . '/config.php') of type * is incompatible with the declared type array of property $config.

		$this->aliases = $this->files->getRequire($path . '/aliases.php');

It seems like $this->files->getRequire($path . '/aliases.php') of type * is incompatible with the declared type array of property $aliases.

		return $this;
	}

	/**
	 * Setup the configuration.
	 *
	 * @param  \Algorit\Synchronizer\Request\Contracts\SystemInterface $system
	 * @return \Algorit\Synchronizer\Request\Config
	 */
	public function setup(SystemInterface $system, $resource)
	{
		$path = $system->path . '/Config';

Accessing path on the interface Algorit\Synchronizer\Request\Contracts\SystemInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

		if(isset($resource->slug))
		{
			$path = $system->path . '/Config/' . $resource->slug;

Accessing path on the interface Algorit\Synchronizer\Request\Contracts\SystemInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

		}

		$this->load($path);

		if( ! is_array($this->config))
		{
			throw new Exception('Config files not found.');
		}

		$this->date = array_get($this->config, 'date');

It seems like array_get($this->config, 'date') of type * is incompatible with the declared type array of property $date.

		$this->entities = array_get($this->config, 'entities');

It seems like array_get($this->config, 'entities') of type * is incompatible with the declared type array of property $entities.

		$this->resourceInstance = array_get($this->config, 'resourceInstance');

It seems like array_get($this->config, 'resourceInstance') of type * is incompatible with the declared type array of property $resourceInstance.

		if($this->aliases == null or $this->entities == null or $this->date == null)
		{
			throw new Exception('Wrong file format.');
		}

		return $this;
	}

	public function getConfig()
	{
		return $this->config;
	}

	public function getAlias($name)
	{
		return $this->aliases[$name];
	}

	/**
	 * Get the entities.
	 *
	 * @param  void
	 * @return array
	 */	
	public function getEntities()
	{
		return $this->entities;
	}
}