InvoiceNinjaModule\Strategy\InvoiceItemsStrategy

Complexity

Total Complexity

6

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	extract()	0	9	2
A	hydrate()	0	12	3

<?php

namespace InvoiceNinjaModule\Strategy;

use InvoiceNinjaModule\Model\Interfaces\ContactInterface;
use InvoiceNinjaModule\Model\Interfaces\InvoiceItemInterface;
use InvoiceNinjaModule\Model\InvoiceItem;
use Zend\Hydrator\ClassMethods;
use Zend\Hydrator\Exception\BadMethodCallException;
use Zend\Hydrator\HydratorInterface;
use Zend\Hydrator\Strategy\StrategyInterface;

class InvoiceItemsStrategy implements StrategyInterface
{
    /** @var ClassMethods  */
    private $hydrator;

    /**
     * InvoiceItemsStrategy constructor.
     *
     * @param HydratorInterface $hydrator
     */
    public function __construct(HydratorInterface $hydrator)
    {
        $this->hydrator = $hydrator;

$hydrator is of type object<Zend\Hydrator\HydratorInterface>, but the property $hydrator was declared to be of type object<Zend\Hydrator\ClassMethods>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

    }

    /**
     * Converts the given value so that it can be extracted by the hydrator.
     *
     * @param ContactInterface[]  $value  The original value.
     *
     * @return array Returns the value that should be extracted.
     * @throws BadMethodCallException for a non-object $contactObj
     */
    public function extract($value)
    {
        $result = [];
        /** @var InvoiceItemInterface $invoiceItem */
        foreach ($value as $invoiceItem) {
            $result[] = $this->hydrator->extract($invoiceItem);
        }
        return $result;
    }

    /**
     * Converts the given value so that it can be hydrated by the hydrator.
     * @param array $value
     *
     * @return ContactInterface[]
     * @throws BadMethodCallException for a non-object $contactObj
     */
    public function hydrate($value)
    {
        $result = [];
        if (is_array($value)) {
            foreach ($value as $invoiceItemArr) {
                $invoiceItem = new InvoiceItem();
                $this->hydrator->hydrate($invoiceItemArr, $invoiceItem);
                $result[] = $invoiceItem;
            }
        }
        return $result;
    }
}