ClientTest - Code Metrics - Inspection of "added tests fixed cs" - alexz707/InvoiceNinjaModule - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2a331f...b1d0a6 )

by Al3x

created 2017-04-27 21:08 UTC

ClientTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
wmc	2
lcom	1
cbo	2
dl	0
loc	95
rs	10
c	1
b	1
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	testCreate()	0	32	1
A	testSetters()	0	58	1

<?php
declare(strict_types=1);

namespace InvoiceNinjaModuleTest\Model;

use InvoiceNinjaModule\Model\Client;
use InvoiceNinjaModule\Model\Interfaces\ClientInterface;
use PHPUnit\Framework\TestCase;

class ClientTest extends TestCase
{
    public function testCreate() :void
    {
        $client = new Client();
        self::assertInstanceOf(ClientInterface::class, $client);

        self::assertNull($client->getCustomValue1());
        self::assertNull($client->getCustomValue2());
        self::assertNull($client->getLastLogin());

        self::assertEquals(0, $client->getBalance());
        self::assertEquals(0, $client->getCountryId());
        self::assertEquals(0, $client->getIndustryId());
        self::assertEquals(0, $client->getLanguageId());
        self::assertEquals(0, $client->getPaymentTerms());
        self::assertEquals(0, $client->getUserId());
        self::assertEquals(0, $client->getSizeId());
        self::assertEquals(0, $client->getCurrencyId());
        self::assertEquals(0, $client->getPaidToDate());

        self::assertEmpty($client->getAddress1());
        self::assertEmpty($client->getAddress2());
        self::assertEmpty($client->getCity());
        self::assertEmpty($client->getState());
        self::assertEmpty($client->getPostalCode());
        self::assertEmpty($client->getWorkPhone());
        self::assertEmpty($client->getPrivateNotes());
        self::assertEmpty($client->getWebsite());
        self::assertEmpty($client->getVatNumber());
        self::assertEmpty($client->getIdNumber());
        self::assertEmpty($client->getName());
        self::assertEmpty($client->getContacts());
    }


    public function testSetters() :void
    {
        $client = new Client();
        self::assertInstanceOf(ClientInterface::class, $client);

        $client->setCustomValue1('test1');
        $client->setCustomValue2('test2');
        $client->setBalance(123.45);
        $client->setCountryId(9);
        $client->setIndustryId(8);
        $client->setLanguageId(7);
        $client->setPaymentTerms(6);
        $client->setUserId(5);
        $client->setSizeId(4);
        $client->setCurrencyId(3);
        $client->setPaidToDate(123.45);
        $client->setAddress1('ad1');
        $client->setAddress2('ad2');
        $client->setCity('city');
        $client->setState('state');
        $client->setPostalCode('postcode');
        $client->setWorkPhone('12345');
        $client->setPrivateNotes('note');
        $client->setWebsite('wwww');
        $client->setVatNumber('1234e');
        $client->setIdNumber('1234ee');
        $client->setName('name');
        $client->setContacts([1,2,3]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        self::assertSame('test1', $client->getCustomValue1());
        self::assertSame('test2', $client->getCustomValue2());
        self::assertNull($client->getLastLogin());

        self::assertEquals(123.45, $client->getBalance());
        self::assertEquals(9, $client->getCountryId());
        self::assertEquals(8, $client->getIndustryId());
        self::assertEquals(7, $client->getLanguageId());
        self::assertEquals(6, $client->getPaymentTerms());
        self::assertEquals(5, $client->getUserId());
        self::assertEquals(4, $client->getSizeId());
        self::assertEquals(3, $client->getCurrencyId());
        self::assertEquals(123.45, $client->getPaidToDate());

        self::assertSame('ad1', $client->getAddress1());
        self::assertSame('ad2', $client->getAddress2());
        self::assertSame('city', $client->getCity());
        self::assertSame('state', $client->getState());
        self::assertSame('postcode', $client->getPostalCode());
        self::assertSame('12345', $client->getWorkPhone());
        self::assertSame('note', $client->getPrivateNotes());
        self::assertSame('wwww', $client->getWebsite());
        self::assertSame('1234e', $client->getVatNumber());
        self::assertSame('1234ee', $client->getIdNumber());
        self::assertSame('name', $client->getName());
        self::assertNotEmpty($client->getContacts());


    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace InvoiceNinjaModuleTest\Model;
5
6			use InvoiceNinjaModule\Model\Client;
7			use InvoiceNinjaModule\Model\Interfaces\ClientInterface;
8			use PHPUnit\Framework\TestCase;
9
10			class ClientTest extends TestCase
11			{
12			public function testCreate() :void
13			{
14			$client = new Client();
15			self::assertInstanceOf(ClientInterface::class, $client);
16
17			self::assertNull($client->getCustomValue1());
18			self::assertNull($client->getCustomValue2());
19			self::assertNull($client->getLastLogin());
20
21			self::assertEquals(0, $client->getBalance());
22			self::assertEquals(0, $client->getCountryId());
23			self::assertEquals(0, $client->getIndustryId());
24			self::assertEquals(0, $client->getLanguageId());
25			self::assertEquals(0, $client->getPaymentTerms());
26			self::assertEquals(0, $client->getUserId());
27			self::assertEquals(0, $client->getSizeId());
28			self::assertEquals(0, $client->getCurrencyId());
29			self::assertEquals(0, $client->getPaidToDate());
30
31			self::assertEmpty($client->getAddress1());
32			self::assertEmpty($client->getAddress2());
33			self::assertEmpty($client->getCity());
34			self::assertEmpty($client->getState());
35			self::assertEmpty($client->getPostalCode());
36			self::assertEmpty($client->getWorkPhone());
37			self::assertEmpty($client->getPrivateNotes());
38			self::assertEmpty($client->getWebsite());
39			self::assertEmpty($client->getVatNumber());
40			self::assertEmpty($client->getIdNumber());
41			self::assertEmpty($client->getName());
42			self::assertEmpty($client->getContacts());
43			}
44
45
46			public function testSetters() :void
47			{
48			$client = new Client();
49			self::assertInstanceOf(ClientInterface::class, $client);
50
51			$client->setCustomValue1('test1');
52			$client->setCustomValue2('test2');
53			$client->setBalance(123.45);
54			$client->setCountryId(9);
55			$client->setIndustryId(8);
56			$client->setLanguageId(7);
57			$client->setPaymentTerms(6);
58			$client->setUserId(5);
59			$client->setSizeId(4);
60			$client->setCurrencyId(3);
61			$client->setPaidToDate(123.45);
62			$client->setAddress1('ad1');
63			$client->setAddress2('ad2');
64			$client->setCity('city');
65			$client->setState('state');
66			$client->setPostalCode('postcode');
67			$client->setWorkPhone('12345');
68			$client->setPrivateNotes('note');
69			$client->setWebsite('wwww');
70			$client->setVatNumber('1234e');
71			$client->setIdNumber('1234ee');
72			$client->setName('name');
73			$client->setContacts([1,2,3]);
			0 ignored issues – show Documentation introduced 2017-04-27 21:13 UTC by Report Bug Copy Issue Report `array(1, 2, 3)` is of type `array<integer,integer,{"...nteger","2":"integer"}>`, but the function expects a `array<integer,object<Inv...aces\ContactInterface>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74
75			self::assertSame('test1', $client->getCustomValue1());
76			self::assertSame('test2', $client->getCustomValue2());
77			self::assertNull($client->getLastLogin());
78
79			self::assertEquals(123.45, $client->getBalance());
80			self::assertEquals(9, $client->getCountryId());
81			self::assertEquals(8, $client->getIndustryId());
82			self::assertEquals(7, $client->getLanguageId());
83			self::assertEquals(6, $client->getPaymentTerms());
84			self::assertEquals(5, $client->getUserId());
85			self::assertEquals(4, $client->getSizeId());
86			self::assertEquals(3, $client->getCurrencyId());
87			self::assertEquals(123.45, $client->getPaidToDate());
88
89			self::assertSame('ad1', $client->getAddress1());
90			self::assertSame('ad2', $client->getAddress2());
91			self::assertSame('city', $client->getCity());
92			self::assertSame('state', $client->getState());
93			self::assertSame('postcode', $client->getPostalCode());
94			self::assertSame('12345', $client->getWorkPhone());
95			self::assertSame('note', $client->getPrivateNotes());
96			self::assertSame('wwww', $client->getWebsite());
97			self::assertSame('1234e', $client->getVatNumber());
98			self::assertSame('1234ee', $client->getIdNumber());
99			self::assertSame('name', $client->getName());
100			self::assertNotEmpty($client->getContacts());
101
102
103			}
104			}
105

alexz707 / InvoiceNinjaModule

Push — master ( 2a331f...b1d0a6 )

ClientTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like