PTS\SymfonyAsset\LastModifyStrategy

Complexity

Total Complexity

7

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getVersion()	0	5	2
A	applyVersion()	0	15	4

<?php
namespace PTS\SymfonyAsset;

use Symfony\Component\Asset\VersionStrategy\VersionStrategyInterface;

class LastModifyStrategy implements VersionStrategyInterface
{
    /** @var string */
    protected $staticDir;
    /** @var null|string */
    protected $cdnHost;

    /**
     * @param string $staticDir
     * @param string|null $cdnHost
     */
    public function __construct(string $staticDir, string $cdnHost = null)
    {
        $this->staticDir = $staticDir;
        $this->cdnHost = $cdnHost;
    }

    /**
     * @inheritdoc
     */
    public function getVersion($path): string
    {
        $path = $this->staticDir . '/' . $path;
        return file_exists($path) ? (string)filemtime($path) : '';
    }

    /**
     * @inheritdoc
     */
    public function applyVersion($relPath): string
    {
        $version = $this->getVersion($relPath);
        $path = $version ? sprintf('%s?v=%s', $relPath, $version) : $relPath;

        if ($this->cdnHost) {

The expression $this->cdnHost of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            if (mb_substr($path, 0, 1, "UTF-8") !== '/') {
                $path = '/' . $path;
            }

            $path = '//' . $this->cdnHost . $path;
        }

        return $path;
    }
}