PTS\Transport\BaseTransport

Complexity

Total Complexity

6

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	write()	0	4	1
A	isConnected()	0	4	2
A	close()	0	5	2

<?php
declare(strict_types=1);

namespace PTS\Transport;

abstract class BaseTransport implements TransportInterface
{

    /**
     * @var resource|null|false
     */
    protected $target;

    /** @var string - udp:// tcp:// */
    protected $schema = '';

    protected $errorNumber = 0;
    protected $errorMessage = '';

    /** @var Writer */
    protected $writer;

    public function __construct(Writer $writer = null)
    {
        $this->writer = $writer ?? new Writer;
    }

    /**
     * @param string $buffer
     * @param int|null $length - записать число байт в сокет
     *
     * @return false|int число записанных байт или false
     */
    public function write(string $buffer, int $length = null): int
    {
        return $this->writer->write($this->target, $buffer, $length);

It seems like $this->target can also be of type false or null; however, PTS\Transport\Writer::write() does only seem to accept resource, maybe add an additional type check?

    }

    public function isConnected(): bool
    {
        return is_resource($this->target) && !feof($this->target);
    }

    public function close(): void
    {
        $this->target && fclose($this->target);
        $this->target = null;
    }
}