PTS\Transport\Socket

Complexity

Total Complexity

7

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

68.75%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	connect()	0	8	1
A	__construct()	0	4	1
A	write()	0	4	1
A	isConnected()	0	4	2
A	close()	0	5	2

<?php
declare(strict_types=1);

namespace PTS\Transport;

abstract class Socket implements TransportInterface
{

    /**
     * @var resource|null|false
     */
    protected $socket;

    /** @var string - udp:// tcp:// */
    protected $socketPrefix = '';

    protected $errorNumber = 0;
    protected $errorMessage = '';

    /** @var Writer */
    protected $writer;

    public function __construct(Writer $writer = null)
    {
        $this->writer = $writer ?? new Writer;
    }

    /**
     * @param string $address
     * @param int $port
     * @param array $options
     *
     * @return TransportInterface
     */
    public function connect(string $address, int $port = 0, array $options = []): TransportInterface
    {
        $timeout = (float)($options['timeout'] ??(float) ini_get('default_socket_timeout'));
        $url = $this->socketPrefix . $address;
        $this->socket = @fsockopen($url, $port, $this->errorNumber, $this->errorMessage, $timeout);

        return $this;
    }

    /**
     * @param string $buffer
     * @param int|null $length - записать число байт в сокет
     *
     * @return false|int число записанных байт или false
     */
    public function write(string $buffer, int $length = null): int
    {
        return $this->writer->write($this->socket, $buffer, $length);

It seems like $this->socket can also be of type false or null; however, PTS\Transport\Writer::write() does only seem to accept resource, maybe add an additional type check?

    }

    public function isConnected(): bool
    {
        return is_resource($this->socket) && !feof($this->socket);
    }

    public function close(): void
    {
        $this->socket && fclose($this->socket);
        $this->socket = null;
    }
}