Matcher::matchRule() - Code Metrics - Inspection of "Fix greedy for placeholder variables" - alexpts/php-routing - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (701f59)

by Alexpts

created 2017-04-08 16:32 UTC

Matcher::matchRule() A

↳ Parent: Matcher

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	2
crap	2

<?php
declare(strict_types = 1);
namespace PTS\Routing;

class Matcher
{
    /** @var RouteService */
    protected $routeService;
    /** @var Route */
    protected $routeNotFound;

    public function __construct(RouteService $routeService)
    {
        $this->routeService = $routeService;
        $this->routeNotFound = new Route('', function () {
            return null;
        });
    }

    public function setNotFoundHandler(Route $route)
    {
        $this->routeNotFound = $route;
        return $this;
    }

    public function match(CollectionRoute $routes, string $path) : \Generator
    {
        foreach ($routes->getRoutes() as $route) {
            $activeRoute = $this->matchRule($route, $path);
            if ($activeRoute !== null) {
                yield $activeRoute;
            }
        }

        yield $this->routeNotFound;
    }

    protected function matchRule(Route $route, string $pathUrl) : ?Route
    {
        $activeRoute = null;

        $regexp = $this->routeService->makeRegExp($route);

        if (preg_match('~^'.$regexp.'$~Uiu', $pathUrl, $values)) {
            $filterValues = array_filter(array_keys($values), 'is_string');
            $matches = array_intersect_key($values, array_flip($filterValues));
            $activeRoute = $route->setMatches($matches);
        }

        return $activeRoute;
    }
}


1		<?php
2		declare(strict_types = 1);
3		namespace PTS\Routing;
4
5		class Matcher
6		{
7		/** @var RouteService */
8		protected $routeService;
9		/** @var Route */
10		protected $routeNotFound;
11
12	5	public function __construct(RouteService $routeService)
13		{
14	5	$this->routeService = $routeService;
15	5	$this->routeNotFound = new Route('', function () {
16		return null;
17	5	});
18	5	}
19
20	1	public function setNotFoundHandler(Route $route)
21		{
22	1	$this->routeNotFound = $route;
23	1	return $this;
24		}
25
26	4	public function match(CollectionRoute $routes, string $path) : \Generator
27		{
28	4	foreach ($routes->getRoutes() as $route) {
29	4	$activeRoute = $this->matchRule($route, $path);
30	4	if ($activeRoute !== null) {
31	3	yield $activeRoute;
32		}
33		}
34
35	1	yield $this->routeNotFound;
36		}
37
38	4	protected function matchRule(Route $route, string $pathUrl) : ?Route
39		{
40	4	$activeRoute = null;
41
42	4	$regexp = $this->routeService->makeRegExp($route);
43
44	4	if (preg_match('~^'.$regexp.'$~Uiu', $pathUrl, $values)) {
45	3	$filterValues = array_filter(array_keys($values), 'is_string');
46	3	$matches = array_intersect_key($values, array_flip($filterValues));
47	3	$activeRoute = $route->setMatches($matches);
48		}
49
50	4	return $activeRoute;
51		}
52		}
53

alexpts / php-routing

Branch — master (701f59)

Matcher::matchRule() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like